From patchwork Wed Mar 2 19:06:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 8484851 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 63E33C0553 for ; Wed, 2 Mar 2016 19:09:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 89CCC2035D for ; Wed, 2 Mar 2016 19:09:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96E1B20351 for ; Wed, 2 Mar 2016 19:09:13 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1abC7e-0004DT-BB; Wed, 02 Mar 2016 19:07:46 +0000 Received: from mout.kundenserver.de ([212.227.126.130]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1abC7a-00049K-Ij for linux-arm-kernel@lists.infradead.org; Wed, 02 Mar 2016 19:07:43 +0000 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue002) with ESMTPA (Nemesis) id 0LfbRK-1a87p22N1m-00pKlm; Wed, 02 Mar 2016 20:07:14 +0100 From: Arnd Bergmann To: Karsten Keil Subject: [PATCH 1/2] isdn: icn: remove a #warning Date: Wed, 2 Mar 2016 20:06:45 +0100 Message-Id: <1456945629-1793533-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:FEFMFlIU1XQBon9mmzdJznu0uMmCTkpJn5uMTkzkDaYGNuHKvL6 mBWU3D9RkOsANTRVw8ZHFF+yqKpJy07qvsDpGy2z581M4ns8D65opETfEJjPUIO0db8wn8d iuwYbwPmfkryN2/Om79G7YEHHCDC58lgHjmN/HhcTR0vzRkuV4DEiVnt3sspNUVUPhWKenV e8qpKG+x2k0XuMiIqBkoA== X-UI-Out-Filterresults: notjunk:1; V01:K0:4c8lTejD4cU=:BPlPfJEprMwNy7iWf1mbR+ iyTt/U+PG6o6r28hvIvL2bAMhm/LSnIpNF7GskBb5/8j7ms00Cb+bt/8ZRE0miZkpEm3qbFNb IK6lYsEUn04MRg1AcY1lDfJLfZA9sGsutLJ8rkPtNkUlu75CMg6oZFqK1YG5wZcFIgOCEC6cZ GPKUd6vjtEH7sroZs5t6Fs/NuW1snDf2dsOFJjmqSy1RSfYqTaWCpydTOBqXLReZ8+ZJr+yOt htvcsqE9o2k32xoklO4rXi/ilfR6et9yKS/EYGH5bCbxIcT+zT+zOgiorrouK/eh5sOjBnz7x c5JPsgHZ7v5N1pdmrT38CeCl4jOjPofZWJHcIIuFdIjEyP13Q3bketXv2Bo2N1c6pIUdzM5PW 7TbZZUpufqt90Qs35SEotsjLWdMYuZKZMOVMXGVKmVFBoilyVSeXRgLPJ6FpMXIqRnlM5bt45 XlcF3PlPkSxlNqWODooBgNCdsanQ4YF1ELP0kJA4ccYWZJtsuOP2Mwbw4Mbr4CpQ5Z+InmEKg KN/uhSbYXsRGU85sCeqX5aUUJ1iRNaftp/ot+k0+VA9D5klnTXYPd2U9xr6FUTSJ5JjeyLfM+ v5m1ruHY1jOVel7dmSWqGFiDNnzkrLdsGs3GOyQ6Ks/YG3pvGmq8ZzTANtr0ZFECldaEzpNlE 3qGHssSoSYGrnbIGbjEdMwIKQ/ae2VjgLqMAHV2W2w7nL+Q0gnGYua92euWHAlzU3QKs= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160302_110742_986823_B6B7A091 X-CRM114-Status: GOOD ( 15.39 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , linux-arm-kernel@lists.infradead.org, "David S. Miller" MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The icn driver currently produces an unconditional #warning whenever we build it, introduced by Karsten Keil back in 2003: #warning TODO test headroom or use skb->nb to flag ACK Karsten's original commit (from BitKeeper) contains this description: - here are lot of bugs left, so ISDN is not stable yet but I think it's really time to fix it, even if it need some cycles to get it right (normally I'm only send patches if it works 100% for me). - I add some additional #warnings to address places which need fixing (I hope that some of the other ISDN developer jump in) Apparently this has not happened, and it is unlikely that it ever will, given that the driver doesn't seem to work. No substantial bug fixes other than janitorial cleanups have happened in the driver since then, and I see no indication that anyone who patched it had the hardware. We should probably either remove the driver, or remove all of i4l, but for now, this shuts up the distracting #warning by turning it into a comment. Signed-off-by: Arnd Bergmann Link: http://git.meleeweb.net/linux.git/commit/?id=b0deac0886b0056765afd149e9834373b38e096b --- drivers/isdn/icn/icn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/icn/icn.c b/drivers/isdn/icn/icn.c index 358a574d9e8b..46d957c34be1 100644 --- a/drivers/isdn/icn/icn.c +++ b/drivers/isdn/icn/icn.c @@ -718,7 +718,7 @@ icn_sendbuf(int channel, int ack, struct sk_buff *skb, icn_card *card) return 0; if (card->sndcount[channel] > ICN_MAX_SQUEUE) return 0; -#warning TODO test headroom or use skb->nb to flag ACK + /* TODO test headroom or use skb->nb to flag ACK */ nskb = skb_clone(skb, GFP_ATOMIC); if (nskb) { /* Push ACK flag as one