| Message ID | 1457005210-18485-4-git-send-email-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Mar 03, 2016 at 12:39:56PM +0100, Neil Armstrong wrote: > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > .../bindings/interrupt-controller/plxtech,rps-irq.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt b/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt > new file mode 100644 > index 0000000..db117a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt ... > +- compatible: Should be "plxtech,nas782x-rps" Hi Neil It would be nice to be consistent with the naming. Maybe also the filename of the driver itself should be changed. You had an interesting sorting problem in the Makefile, which a consistent name would help with. Andrew
Hi Andrew, On 03/03/2016 03:53 PM, Andrew Lunn wrote: > >> +- compatible: Should be "plxtech,nas782x-rps" > > Hi Neil > > It would be nice to be consistent with the naming. The compatible is now oxsemi,os810se-rps-irq which is consistent with the timer. > > Maybe also the filename of the driver itself should be changed. You > had an interesting sorting problem in the Makefile, which a consistent > name would help with. Yes, I will add -irq to the driver name and _IRQ to the config name. > > Andrew > Thanks, Neil
On Thu, Mar 03, 2016 at 03:57:10PM +0100, Neil Armstrong wrote: > Hi Andrew, > > On 03/03/2016 03:53 PM, Andrew Lunn wrote: > > > >> +- compatible: Should be "plxtech,nas782x-rps" > > > > Hi Neil > > > > It would be nice to be consistent with the naming. > The compatible is now oxsemi,os810se-rps-irq which is consistent with the timer. Ah, i had not read that far down the thread yet. Thanks Andrew
diff --git a/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt b/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt new file mode 100644 index 0000000..db117a0 --- /dev/null +++ b/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt @@ -0,0 +1,17 @@ +PLX Technology OXNAS SoCs Family RPS Interrupt Controller +========================================================= + +Required properties: +- compatible: Should be "plxtech,nas782x-rps" +- reg : Specifies base physical address and size of the registers. +- interrupt-controller : Identifies the node as an interrupt controller +- #interrupt-cells : Should be 1 + +example: + +intc: interrupt-controller@0 { + compatible = "plxtech,nas782x-rps"; + interrupt-controller; + reg = <0 0x200>; + #interrupt-cells = <1>; +};
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- .../bindings/interrupt-controller/plxtech,rps-irq.txt | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt