diff mbox

[v4,3/8] Documentation: devicetree: rockchip: Document GeekBox

Message ID 1458136727-32075-4-git-send-email-afaerber@suse.de (mailing list archive)
State New, archived
Headers show

Commit Message

Andreas Färber March 16, 2016, 1:58 p.m. UTC
Use "geekbuying,geekbox" compatible string.

Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v3 -> v4: Unchanged
 
 v2 -> v3: Unchanged

 v2: New (Heiko)
 
 Documentation/devicetree/bindings/arm/rockchip.txt | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Heiko Stuebner March 29, 2016, 8:13 p.m. UTC | #1
Am Mittwoch, 16. März 2016, 14:58:41 schrieb Andreas Färber:
> Use "geekbuying,geekbox" compatible string.
> 
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Andreas Färber <afaerber@suse.de>

I've folded this patch into the geekbox dts patch, carrying Rob's Ack for the 
binding over.


Heiko
Andreas Färber March 29, 2016, 8:45 p.m. UTC | #2
Am 29.03.2016 um 22:13 schrieb Heiko Stübner:
> Am Mittwoch, 16. März 2016, 14:58:41 schrieb Andreas Färber:
>> Use "geekbuying,geekbox" compatible string.
>>
>> Acked-by: Rob Herring <robh@kernel.org>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
> 
> I've folded this patch into the geekbox dts patch, carrying Rob's Ack for the 
> binding over.

Either you just made a mistake in my name or
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/submitting-patches.txt
needs an update. It clearly says:

"1) The Documentation/ portion of the patch should be a separate patch."

That's why I always do it this way.

Regards,
Andreas
Heiko Stuebner March 29, 2016, 9:21 p.m. UTC | #3
Am Dienstag, 29. März 2016, 22:45:18 schrieb Andreas Färber:
> Am 29.03.2016 um 22:13 schrieb Heiko Stübner:
> > Am Mittwoch, 16. März 2016, 14:58:41 schrieb Andreas Färber:
> >> Use "geekbuying,geekbox" compatible string.
> >> 
> >> Acked-by: Rob Herring <robh@kernel.org>
> >> Signed-off-by: Andreas Färber <afaerber@suse.de>
> > 
> > I've folded this patch into the geekbox dts patch, carrying Rob's Ack for
> > the binding over.
> 
> Either you just made a mistake in my name or
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Docume
> ntation/devicetree/bindings/submitting-patches.txt needs an update. It
> clearly says:
> 
> "1) The Documentation/ portion of the patch should be a separate patch."
> 
> That's why I always do it this way.

looking at the dt-bindings git log, it seems that is handled in a variety of 
ways :-) . Personally I'm doing completely new bindings separately but the 
125th addition of a board just inside the dts patch.

But I guess we can also move it out again into a separate patch if you prefer 
that :-) .


Heiko
Heiko Stuebner March 31, 2016, 5:02 p.m. UTC | #4
Am Dienstag, 29. März 2016, 23:21:51 schrieb Heiko Stübner:
> Am Dienstag, 29. März 2016, 22:45:18 schrieb Andreas Färber:
> > Am 29.03.2016 um 22:13 schrieb Heiko Stübner:
> > > Am Mittwoch, 16. März 2016, 14:58:41 schrieb Andreas Färber:
> > >> Use "geekbuying,geekbox" compatible string.
> > >> 
> > >> Acked-by: Rob Herring <robh@kernel.org>
> > >> Signed-off-by: Andreas Färber <afaerber@suse.de>
> > > 
> > > I've folded this patch into the geekbox dts patch, carrying Rob's Ack
> > > for
> > > the binding over.
> > 
> > Either you just made a mistake in my name or
> > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Do
> > cume ntation/devicetree/bindings/submitting-patches.txt needs an update.
> > It clearly says:
> > 
> > "1) The Documentation/ portion of the patch should be a separate patch."
> > 
> > That's why I always do it this way.
> 
> looking at the dt-bindings git log, it seems that is handled in a variety
> of ways :-) . Personally I'm doing completely new bindings separately but
> the 125th addition of a board just inside the dts patch.
> 
> But I guess we can also move it out again into a separate patch if you
> prefer that :-) .

I've split out that documentation addition again and applied this separate 
patch instead :-) .


Heiko
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt b/Documentation/devicetree/bindings/arm/rockchip.txt
index 078c14fcdaaa..f633595b196c 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.txt
+++ b/Documentation/devicetree/bindings/arm/rockchip.txt
@@ -87,6 +87,10 @@  Rockchip platforms device tree bindings
 		     "google,veyron-speedy-rev3", "google,veyron-speedy-rev2",
 		     "google,veyron-speedy", "google,veyron", "rockchip,rk3288";
 
+- GeekBuying GeekBox:
+    Required root node properties:
+      - compatible = "geekbuying,geekbox", "rockchip,rk3368";
+
 - Rockchip RK3368 evb:
     Required root node properties:
       - compatible = "rockchip,rk3368-evb-act8846", "rockchip,rk3368";