diff mbox

[1/2] dt/bindings: Add bindings for hisilicon random number generator

Message ID 1459474664-11264-1-git-send-email-wangkefeng.wang@huawei.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kefeng Wang April 1, 2016, 1:37 a.m. UTC
Document the devicetree bindings for the random number generator
found on Hisilicon Hip04 and Hip05 soc.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 Documentation/devicetree/bindings/rng/hisi-rng.txt | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rng/hisi-rng.txt

Comments

Rob Herring April 4, 2016, 5:15 a.m. UTC | #1
On Fri, Apr 01, 2016 at 09:37:43AM +0800, Kefeng Wang wrote:
> Document the devicetree bindings for the random number generator
> found on Hisilicon Hip04 and Hip05 soc.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  Documentation/devicetree/bindings/rng/hisi-rng.txt | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rng/hisi-rng.txt
> 
> diff --git a/Documentation/devicetree/bindings/rng/hisi-rng.txt b/Documentation/devicetree/bindings/rng/hisi-rng.txt
> new file mode 100644
> index 0000000..80f29b6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rng/hisi-rng.txt
> @@ -0,0 +1,12 @@
> +Hisilicon Random Number Generator
> +
> +Required properties:
> +- compatible : Should be "hisilicon,hisi-rng"

hisi is a bit redundant with hisilicon and please define SoC specific 
compatible strings.

> +- reg : Offset and length of the register set of this block
> +
> +Example:
> +
> +rng@d1010000 {
> +	compatible = "hisilicon,hisi-rng";
> +	reg = <0xd1010000 0x100>;
> +};
> -- 
> 1.7.12.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kefeng Wang April 5, 2016, 1:16 a.m. UTC | #2
On 2016/4/4 13:15, Rob Herring wrote:
> On Fri, Apr 01, 2016 at 09:37:43AM +0800, Kefeng Wang wrote:
>> Document the devicetree bindings for the random number generator
>> found on Hisilicon Hip04 and Hip05 soc.
[...]
>> +
>> +Required properties:
>> +- compatible : Should be "hisilicon,hisi-rng"
> 
> hisi is a bit redundant with hisilicon and please define SoC specific 
> compatible strings.

Due to it exists in both Hip04/Hip05 soc(and maybe some other chips),
how about drop hisi-, just "hisilicon,rng".

Thanks

> 
>> +- reg : Offset and length of the register set of this block
>> +
>> +Example:
>> +
>> +rng@d1010000 {
>> +	compatible = "hisilicon,hisi-rng";
>> +	reg = <0xd1010000 0x100>;
>> +};
>> -- 
>> 1.7.12.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> .
>
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/rng/hisi-rng.txt b/Documentation/devicetree/bindings/rng/hisi-rng.txt
new file mode 100644
index 0000000..80f29b6
--- /dev/null
+++ b/Documentation/devicetree/bindings/rng/hisi-rng.txt
@@ -0,0 +1,12 @@ 
+Hisilicon Random Number Generator
+
+Required properties:
+- compatible : Should be "hisilicon,hisi-rng"
+- reg : Offset and length of the register set of this block
+
+Example:
+
+rng@d1010000 {
+	compatible = "hisilicon,hisi-rng";
+	reg = <0xd1010000 0x100>;
+};