From patchwork Mon Apr 4 20:22:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 8743941 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6A8649F38C for ; Mon, 4 Apr 2016 20:24:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8441B2022A for ; Mon, 4 Apr 2016 20:24:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AFC01201CE for ; Mon, 4 Apr 2016 20:24:51 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1anB1j-0006w9-NF; Mon, 04 Apr 2016 20:23:11 +0000 Received: from mail-qg0-x22e.google.com ([2607:f8b0:400d:c04::22e]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1anB1M-0006mv-TG for linux-arm-kernel@lists.infradead.org; Mon, 04 Apr 2016 20:22:49 +0000 Received: by mail-qg0-x22e.google.com with SMTP id j35so162639994qge.0 for ; Mon, 04 Apr 2016 13:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7SswpOLerLSjpUdGB9rhKL8EiNUz9KTXhc9iDVp/9R0=; b=AlYi7GlJUOfDjKB5it3yjoBYawB6aNQICa3yPGOUpwMT+XMWMfBNsmf+0JUtr8+S/+ 19rbfCrl/GLADo0hCdMRzBRMkM5PckzKoT+YrM7fQuh4HP0bEEmxYGnweBCEogk4xV+H UCEtWdW0krQpmGaaKBeAd+Ivt6CqqGkbfl6Vk6aXRVVB4XpSErjrk35bWbTDQRPetRkB xGBAH02Lzv7TCaIw/5xM+jYqMCsmoiQ4XnNOAt26sPoBn+fEN4KkJqkasrUP/g212FTY 85flLVbRe/uwMTwrxqwpRpvi/AdXnAm6/mFVFp73DmFfuwmZt0Wb+CqVwKSGc+kPrNMf +ULA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7SswpOLerLSjpUdGB9rhKL8EiNUz9KTXhc9iDVp/9R0=; b=QCo6soVRHvhVKlqTMnG7IFx/7RxHQKFPM1gncaWQS72XZE1e7mPvLeB34wTSr+PN5I lQ5NnoEBFUTjuS0hsomIImnmBZ6Ui4oaad3y+oV/ijpbxIhCYIwTSvZxffUzRjosxXzc hSduJg57UaLxk7gPOZwfSgo1HZdvch4vogTrUKULBXtXznt+kr4x97G6t8iBLX6kNYr3 NcTE2izrQoxGaxuvzriN+Yj9GOgOkI/GU/5lnsMlSPhJ9rjrPTEBqn7E6KUYXZNaPzz3 MDMG77mvcRlP41qJ+EL0jWugfSqUZZgj6bMeqQFSoIp3gQGekGQNAO26zJlAxP/jb6YD g4Lg== X-Gm-Message-State: AD7BkJLpD/RWPg/su3F3XUMzNkAw3HpukyAN+nsYRClvTUitNwCY3+ZEnsHPI/P1xwyzow== X-Received: by 10.140.242.77 with SMTP id n74mr13082791qhc.2.1459801347824; Mon, 04 Apr 2016 13:22:27 -0700 (PDT) Received: from localhost.localdomain ([190.2.108.156]) by smtp.gmail.com with ESMTPSA id w75sm13065124qka.49.2016.04.04.13.22.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Apr 2016 13:22:26 -0700 (PDT) From: Ezequiel Garcia To: , , Subject: [PATCH 3/5] leds: trigger: panic: Use led_trigger_event_nosleep Date: Mon, 4 Apr 2016 17:22:04 -0300 Message-Id: <1459801326-5541-4-git-send-email-ezequiel@vanguardiasur.com.ar> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1459801326-5541-1-git-send-email-ezequiel@vanguardiasur.com.ar> References: <1459801326-5541-1-git-send-email-ezequiel@vanguardiasur.com.ar> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160404_132249_148148_DBF23DA6 X-CRM114-Status: GOOD ( 11.04 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Purdie , Jacek Anaszewski , Ezequiel Garcia MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Calling led_trigger_event may schedule a delayed LED set, if the LED was being used by a delayed blink trigger when the kernel paniced. Therefore, we must use led_trigger_event_nosleep to override this situation, and set the LED unconditionally. Signed-off-by: Ezequiel Garcia --- drivers/leds/trigger/ledtrig-panic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/trigger/ledtrig-panic.c b/drivers/leds/trigger/ledtrig-panic.c index 627b350c5ec3..145c238d55f2 100644 --- a/drivers/leds/trigger/ledtrig-panic.c +++ b/drivers/leds/trigger/ledtrig-panic.c @@ -17,7 +17,7 @@ static struct led_trigger *trigger; static long led_panic_blink(int state) { - led_trigger_event(trigger, state ? LED_FULL : LED_OFF); + led_trigger_event_nosleep(trigger, state ? LED_FULL : LED_OFF); return 0; }