| Message ID | 1459848697-21006-1-git-send-email-petr@barix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Petr, On Tuesday 05 April 2016 03:01 PM, Petr Kulhavy wrote: > The gpio node was missing the mandatory property #gpio-cells, which was > causing runtime errors when using GPIOs e.g. with gpio-leds or gpio-keys: > > "could not get #gpio-cells for /soc/gpio@1e26000" > > This fixes the problem and adds the missing parameter. > The value is 2 according to the gpio-davinci.txt binding. > > Signed-off-by: Petr Kulhavy <petr@barix.com> Thanks for the patch. Queuing this for v4.7 since it has been this way since beginning and there seem to be no in-kernel device-tree files with a gpio consumerm, so no one seems to be immediately affected. Thanks, Sekhar
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi index 226cda76e77c..b0e3a4c833c3 100644 --- a/arch/arm/boot/dts/da850.dtsi +++ b/arch/arm/boot/dts/da850.dtsi @@ -312,6 +312,7 @@ gpio: gpio@1e26000 { compatible = "ti,dm6441-gpio"; gpio-controller; + #gpio-cells = <2>; reg = <0x226000 0x1000>; interrupts = <42 IRQ_TYPE_EDGE_BOTH 43 IRQ_TYPE_EDGE_BOTH 44 IRQ_TYPE_EDGE_BOTH
The gpio node was missing the mandatory property #gpio-cells, which was causing runtime errors when using GPIOs e.g. with gpio-leds or gpio-keys: "could not get #gpio-cells for /soc/gpio@1e26000" This fixes the problem and adds the missing parameter. The value is 2 according to the gpio-davinci.txt binding. Signed-off-by: Petr Kulhavy <petr@barix.com> --- arch/arm/boot/dts/da850.dtsi | 1 + 1 file changed, 1 insertion(+)