From patchwork Fri Apr 15 10:24:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Glauber X-Patchwork-Id: 8846951 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B54C1C0553 for ; Fri, 15 Apr 2016 10:26:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E0E47202F0 for ; Fri, 15 Apr 2016 10:26:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DD982021F for ; Fri, 15 Apr 2016 10:26:47 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ar0wG-0003T4-QF; Fri, 15 Apr 2016 10:25:24 +0000 Received: from mail-wm0-f66.google.com ([74.125.82.66]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ar0wC-0002Ba-Rk for linux-arm-kernel@lists.infradead.org; Fri, 15 Apr 2016 10:25:22 +0000 Received: by mail-wm0-f66.google.com with SMTP id a140so4929413wma.2 for ; Fri, 15 Apr 2016 03:25:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=bSPRJUKHVZi0zWXikJ8jEDZ900aCLqKLVIs4TTTG6jM=; b=gxk7s5n3Ioi+hA/pl3CcLDpI3UZOI4vocAB+HHO2rZTQnZ0UrGUl5hodV2Qlw7fXWG H7Ly9WBeEgJdtMWzl/jcImiaTm+hFZ06JpjZf/0yFQe3OvpJsIdj9PjSNIAcQlCj8uOZ SBJuS9qlgW6tG4/6rZTddKoaj/k+QmiH8cxxCayjJ1mRoR+vBZu83YqPuGSaFrInjyLs pWqbtH03w34vdGrrFn5YQ7ukQbVsxShX7FCb8QNE37yP72WsZxTZN6xpg9+ik/ygmQQI UtNE+Y+w0tv0Tr09evrgb7msu2wJ5AuAHsJOD9c+4t441bNVvGAHzdxs9gZfr/0yZ4Lc BoPg== X-Gm-Message-State: AOPr4FUL+OVhHqopTD53xI+nK7adfdBGQ6tdktO8FZRXJBSMHi32rRs7zqAje4FwYcWvOw== X-Received: by 10.28.19.21 with SMTP id 21mr3504629wmt.74.1460715898950; Fri, 15 Apr 2016 03:24:58 -0700 (PDT) Received: from hardcore.t-mobile.de ([88.128.80.191]) by smtp.gmail.com with ESMTPSA id gg7sm48257801wjd.10.2016.04.15.03.24.56 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 15 Apr 2016 03:24:58 -0700 (PDT) From: Jan Glauber To: Catalin Marinas , Will Deacon Subject: [PATCH] arm64: Reduce verbosity on SMP CPU stop Date: Fri, 15 Apr 2016 12:24:36 +0200 Message-Id: <1460715876-10780-1-git-send-email-jglauber@cavium.com> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160415_032521_146438_6A9193E9 X-CRM114-Status: GOOD ( 11.45 ) X-Spam-Score: -2.4 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jan Glauber MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When CPUs are stopped during an abnormal operation like panic for each CPU a line is printed and the stack trace is dumped. This information is only interesting for the aborting CPU and on systems with many CPUs it only makes it harder to debug if after the aborting CPU the log is flooded with data about all other CPUs too. Therefore remove the stack dump and printk of other CPUs and only print a single line that the other CPUs are going to be stopped. Signed-off-by: Jan Glauber --- arch/arm64/kernel/smp.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c index b2d5f4e..e6c2eb1 100644 --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -770,14 +770,6 @@ static DEFINE_RAW_SPINLOCK(stop_lock); */ static void ipi_cpu_stop(unsigned int cpu) { - if (system_state == SYSTEM_BOOTING || - system_state == SYSTEM_RUNNING) { - raw_spin_lock(&stop_lock); - pr_crit("CPU%u: stopping\n", cpu); - dump_stack(); - raw_spin_unlock(&stop_lock); - } - set_cpu_online(cpu, false); local_irq_disable(); @@ -872,6 +864,9 @@ void smp_send_stop(void) cpumask_copy(&mask, cpu_online_mask); cpumask_clear_cpu(smp_processor_id(), &mask); + if (system_state == SYSTEM_BOOTING || + system_state == SYSTEM_RUNNING) + pr_crit("SMP: stopping secondary CPUs\n"); smp_cross_call(&mask, IPI_CPU_STOP); }