| Message ID | 1460826020-1256-4-git-send-email-david@lechnology.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi David, On Saturday 16 April 2016 10:30 PM, David Lechner wrote: > All other devices are disabled by default and not all boards will use > these devices, so these should be disabled too.. > > da850-evm.dtb already had status = "okay" for these devices. > da850-enbw-cmc.dts did not, so they were added. > > Signed-off-by: David Lechner <david@lechnology.com> > Tested-by: Kevin Hilman <khilman@baylibre.com> I applied this and other patches in this series. One nit-pick though. The commit description should be independently readable and not only as continuation of the headline. Even if this means repeating portion of the headline. I fixed this for most of the patches in this series. For example, for this patch, I have: ARM: dts: da850: disable mdio and eth0 in da850.dtsi Disable mdio and eth0 in da850.dtsi file. All other devices are disabled by default and not all boards will use these devices, so these should be disabled too. da850-evm.dtb already had status = "okay" for these devices. da850-enbw-cmc.dts did not, so they were added. Signed-off-by: David Lechner <david@lechnology.com> Tested-by: Kevin Hilman <khilman@baylibre.com> [nsekhar@ti.com: commit description updates] Signed-off-by: Sekhar Nori <nsekhar@ti.com> Its a minor change and I wont reply to all the patches with the changes I made. But I pushed the updated v4.7/dt branch in my tree. Do take a look at the commit description there. Thanks, Sekhar
On 04/25/2016 08:30 AM, Sekhar Nori wrote: > Hi David, > > On Saturday 16 April 2016 10:30 PM, David Lechner wrote: >> All other devices are disabled by default and not all boards will use >> these devices, so these should be disabled too.. >> >> da850-evm.dtb already had status = "okay" for these devices. >> da850-enbw-cmc.dts did not, so they were added. >> >> Signed-off-by: David Lechner <david@lechnology.com> >> Tested-by: Kevin Hilman <khilman@baylibre.com> > > I applied this and other patches in this series. One nit-pick though. > The commit description should be independently readable and not only as > continuation of the headline. Even if this means repeating portion of > the headline. I fixed this for most of the patches in this series. For > example, for this patch, I have: > > ARM: dts: da850: disable mdio and eth0 in da850.dtsi > > Disable mdio and eth0 in da850.dtsi file. All other > devices are disabled by default and not all boards > will use these devices, so these should be disabled too. > > da850-evm.dtb already had status = "okay" for these devices. > da850-enbw-cmc.dts did not, so they were added. > > Signed-off-by: David Lechner <david@lechnology.com> > Tested-by: Kevin Hilman <khilman@baylibre.com> > [nsekhar@ti.com: commit description updates] > Signed-off-by: Sekhar Nori <nsekhar@ti.com> > > Its a minor change and I wont reply to all the patches with the changes > I made. But I pushed the updated v4.7/dt branch in my tree. Do take a > look at the commit description there. > > Thanks, > Sekhar > > I had a look at the commits. I'll be sure to follow that advice in the future.
diff --git a/arch/arm/boot/dts/da850-enbw-cmc.dts b/arch/arm/boot/dts/da850-enbw-cmc.dts index 101d1a1..14dff3e 100644 --- a/arch/arm/boot/dts/da850-enbw-cmc.dts +++ b/arch/arm/boot/dts/da850-enbw-cmc.dts @@ -26,6 +26,12 @@ serial2: serial@10d000 { status = "okay"; }; + mdio: mdio@224000 { + status = "okay"; + }; + eth0: ethernet@220000 { + status = "okay"; + }; }; }; diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi index 8880d57..26fc0812 100644 --- a/arch/arm/boot/dts/da850.dtsi +++ b/arch/arm/boot/dts/da850.dtsi @@ -330,6 +330,7 @@ #address-cells = <1>; #size-cells = <0>; reg = <0x224000 0x1000>; + status = "disabled"; }; eth0: ethernet@220000 { compatible = "ti,davinci-dm6467-emac"; @@ -344,6 +345,7 @@ 35 36 >; + status = "disabled"; }; gpio: gpio@226000 { compatible = "ti,dm6441-gpio";