| Message ID | 1460903363-2197-1-git-send-email-ivo.g.dimitrov.75@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Sun, Apr 17, 2016 at 05:29:23PM +0300, Ivaylo Dimitrov wrote: > Without that, regulators are left in the mode last set by the bootloader or > by the kernel the device was rebooted from. This leads to various problems, > like non-working peripherals. > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> Reviewed-By: Sebastian Reichel <sre@kernel.org> -- Sebastian
Hello Ivaylo, On Sun, Apr 17, 2016 at 10:29 AM, Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> wrote: > Without that, regulators are left in the mode last set by the bootloader or > by the kernel the device was rebooted from. This leads to various problems, > like non-working peripherals. > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> > --- > arch/arm/boot/dts/omap3-n900.dts | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts > index b3c26a9..d9e2d9c 100644 > --- a/arch/arm/boot/dts/omap3-n900.dts > +++ b/arch/arm/boot/dts/omap3-n900.dts > @@ -329,6 +329,7 @@ > regulator-name = "V28"; > regulator-min-microvolt = <2800000>; > regulator-max-microvolt = <2800000>; > + regulator-initial-mode = <0x0e>; /* RES_STATE_ACTIVE */ As Sebastian said, it would be nice if instead of magic numbers + comments, we have defines for the modes by moving the definitions from include/linux/i2c/twl.h to include/dt-bindings/regulator/ so they can be used by DTS. But that can be done as a follow-up though, to avoid adding a dependency between the regulator and arm-soc subsystems to get this fix applied. Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards, Javier
On Sun 2016-04-17 17:29:23, Ivaylo Dimitrov wrote: > Without that, regulators are left in the mode last set by the bootloader or > by the kernel the device was rebooted from. This leads to various problems, > like non-working peripherals. > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> Reviewed-by: Pavel Machek <pavel@ucw.cz> > --- a/arch/arm/boot/dts/omap3-n900.dts > +++ b/arch/arm/boot/dts/omap3-n900.dts > @@ -329,6 +329,7 @@ > regulator-name = "V28"; > regulator-min-microvolt = <2800000>; > regulator-max-microvolt = <2800000>; > + regulator-initial-mode = <0x0e>; /* RES_STATE_ACTIVE */ > regulator-always-on; /* due to battery cover sensor */ > }; >
* Pavel Machek <pavel@ucw.cz> [160424 03:09]: > On Sun 2016-04-17 17:29:23, Ivaylo Dimitrov wrote: > > Without that, regulators are left in the mode last set by the bootloader or > > by the kernel the device was rebooted from. This leads to various problems, > > like non-working peripherals. > > > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> > > Reviewed-by: Pavel Machek <pavel@ucw.cz> Thanks applying into omap-for-v4.6/fixes-rc5. Tony
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index b3c26a9..d9e2d9c 100644 --- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -329,6 +329,7 @@ regulator-name = "V28"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; + regulator-initial-mode = <0x0e>; /* RES_STATE_ACTIVE */ regulator-always-on; /* due to battery cover sensor */ }; @@ -336,30 +337,35 @@ regulator-name = "VCSI"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-initial-mode = <0x0e>; /* RES_STATE_ACTIVE */ }; &vaux3 { regulator-name = "VMMC2_30"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <3000000>; + regulator-initial-mode = <0x0e>; /* RES_STATE_ACTIVE */ }; &vaux4 { regulator-name = "VCAM_ANA_28"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; + regulator-initial-mode = <0x0e>; /* RES_STATE_ACTIVE */ }; &vmmc1 { regulator-name = "VMMC1"; regulator-min-microvolt = <1850000>; regulator-max-microvolt = <3150000>; + regulator-initial-mode = <0x0e>; /* RES_STATE_ACTIVE */ }; &vmmc2 { regulator-name = "V28_A"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <3000000>; + regulator-initial-mode = <0x0e>; /* RES_STATE_ACTIVE */ regulator-always-on; /* due VIO leak to AIC34 VDDs */ }; @@ -367,6 +373,7 @@ regulator-name = "VPLL"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-initial-mode = <0x0e>; /* RES_STATE_ACTIVE */ regulator-always-on; }; @@ -374,6 +381,7 @@ regulator-name = "VSDI_CSI"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-initial-mode = <0x0e>; /* RES_STATE_ACTIVE */ regulator-always-on; }; @@ -381,6 +389,7 @@ regulator-name = "VMMC2_IO_18"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-initial-mode = <0x0e>; /* RES_STATE_ACTIVE */ }; &vio {
Without that, regulators are left in the mode last set by the bootloader or by the kernel the device was rebooted from. This leads to various problems, like non-working peripherals. Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> --- arch/arm/boot/dts/omap3-n900.dts | 9 +++++++++ 1 file changed, 9 insertions(+)