| Message ID | 1461230323-27891-6-git-send-email-pramod.kumar@broadcom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Apr 21, 2016 at 02:48:42PM +0530, Pramod Kumar wrote: > Adding binding doc for ethernet master present in shared > MDIO controller. > > Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com> > Reviewed-by: Ray Jui <ray.jui@broadcom.com> > Reviewed-by: Scott Branden <scott.branden@broadcom.com> > --- > .../bindings/net/brcm,iproc-mdio-shared.txt | 32 ++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/brcm,iproc-mdio-shared.txt > > diff --git a/Documentation/devicetree/bindings/net/brcm,iproc-mdio-shared.txt b/Documentation/devicetree/bindings/net/brcm,iproc-mdio-shared.txt > new file mode 100644 > index 0000000..1ffdd4b > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/brcm,iproc-mdio-shared.txt > @@ -0,0 +1,32 @@ > +Broadcom Ethernet master for shared mdio controller > + > +Required properties: > +- compatible: must be "brcm,iproc-mdio-master-eth" > +- reg: master id of Ethernet block > +- address-cells: should be 1 > +- size-cells: should be 0 > + > +Sub-nodes: > + Each port's PHY should be represented as a sub-node. > + > +Sub-nodes required properties: > +- reg: the PHY number > +- phy-mode: media type connecting the PHY and MAC. > + > + > +Example: > + eth-master@0 { Is this a child of something? Why is this not just an mdio bus underneath the ethernet controller? How is this accessed? > + compatible = "brcm,iproc-mdio-master-eth"; > + reg = <0x0>; > + #address-cells = <1>; > + #size-cells = <0>; > + gphy0: eth-phy@10 { > + reg = <0x10>; > + phy-mode = "mii"; > + }; > + status = "ok" > + }; > + > +For more info on ethernet phy binding, please,refer to: > +Documentation/devicetree/bindings/net/phy.txt > +Documentation/devicetree/bindings/net/ethernet.txt > -- > 1.9.1 >
Hi Rob, Thanks for review and providing your valuable comments. > -----Original Message----- > From: Rob Herring [mailto:robh@kernel.org] > Sent: 23 April 2016 01:44 > To: Pramod Kumar > Cc: Catalin Marinas; Will Deacon; Masahiro Yamada; Chen-Yu Tsai; BCM Kernel > Feedback; Pawel Moll; Mark Rutland; Arnd Bergmann; Suzuki K Poulose; Punit > Agrawal; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; netdev@vger.kernel.org > Subject: Re: [PATCH 5/6] Documentation: Binding doc for ethernet master in > NS2 > > On Thu, Apr 21, 2016 at 02:48:42PM +0530, Pramod Kumar wrote: > > Adding binding doc for ethernet master present in shared MDIO > > controller. > > > > Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com> > > Reviewed-by: Ray Jui <ray.jui@broadcom.com> > > Reviewed-by: Scott Branden <scott.branden@broadcom.com> > > --- > > .../bindings/net/brcm,iproc-mdio-shared.txt | 32 > ++++++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/net/brcm,iproc-mdio-shared.txt > > > > diff --git > > a/Documentation/devicetree/bindings/net/brcm,iproc-mdio-shared.txt > > b/Documentation/devicetree/bindings/net/brcm,iproc-mdio-shared.txt > > new file mode 100644 > > index 0000000..1ffdd4b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/brcm,iproc-mdio-shared.txt > > @@ -0,0 +1,32 @@ > > +Broadcom Ethernet master for shared mdio controller > > + > > +Required properties: > > +- compatible: must be "brcm,iproc-mdio-master-eth" > > +- reg: master id of Ethernet block > > +- address-cells: should be 1 > > +- size-cells: should be 0 > > + > > +Sub-nodes: > > + Each port's PHY should be represented as a sub-node. > > + > > +Sub-nodes required properties: > > +- reg: the PHY number > > +- phy-mode: media type connecting the PHY and MAC. > > + > > + > > +Example: > > + eth-master@0 { > > Is this a child of something? > This is an Shared MDIO master node as described in cover letter and is the child node of iProc_shared_mdio plarform driver. > Why is this not just an mdio bus underneath the ethernet controller? How is this > accessed? This is the part for Shared MDIO controller which is shared among other subsystem as well hence defined here. This works as glue layer between This controller and legacy MDIO framework and register the MDIO bus to legacy framework. When any read/write request is issue from Legacy MDIO controller framework it gets propagated to Shared controller platform driver via this driver and finally platform driver issue MDIO transaction over bus. > > > + compatible = "brcm,iproc-mdio-master-eth"; > > + reg = <0x0>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + gphy0: eth-phy@10 { > > + reg = <0x10>; > > + phy-mode = "mii"; > > + }; > > + status = "ok" > > + }; > > + > > +For more info on ethernet phy binding, please,refer to: > > +Documentation/devicetree/bindings/net/phy.txt > > +Documentation/devicetree/bindings/net/ethernet.txt > > -- > > 1.9.1 > > Regards, Pramod
diff --git a/Documentation/devicetree/bindings/net/brcm,iproc-mdio-shared.txt b/Documentation/devicetree/bindings/net/brcm,iproc-mdio-shared.txt new file mode 100644 index 0000000..1ffdd4b --- /dev/null +++ b/Documentation/devicetree/bindings/net/brcm,iproc-mdio-shared.txt @@ -0,0 +1,32 @@ +Broadcom Ethernet master for shared mdio controller + +Required properties: +- compatible: must be "brcm,iproc-mdio-master-eth" +- reg: master id of Ethernet block +- address-cells: should be 1 +- size-cells: should be 0 + +Sub-nodes: + Each port's PHY should be represented as a sub-node. + +Sub-nodes required properties: +- reg: the PHY number +- phy-mode: media type connecting the PHY and MAC. + + +Example: + eth-master@0 { + compatible = "brcm,iproc-mdio-master-eth"; + reg = <0x0>; + #address-cells = <1>; + #size-cells = <0>; + gphy0: eth-phy@10 { + reg = <0x10>; + phy-mode = "mii"; + }; + status = "ok" + }; + +For more info on ethernet phy binding, please,refer to: +Documentation/devicetree/bindings/net/phy.txt +Documentation/devicetree/bindings/net/ethernet.txt