diff mbox

ARM: dts: omap5-igep0050: Correct hdmi regulator

Message ID 1461925297-9734-1-git-send-email-peter.ujfalusi@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Peter Ujfalusi April 29, 2016, 10:21 a.m. UTC
ldo7_reg should not work as regulator since it is set to 'disabled' state
in the omap5-board-common.dtsi and the state is not changed to 'okay'
this means that the ldo7_reg is not available to be used in the igep0050
DTS file.
ldo4_reg is used by all other OMAP5 boards and this is most likely the
correct regulator to use with hdmi.
The hdmi needs 1.8V, but the ldo7_reg, based on the dtsi is 2V only.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
Tony,

I don't have access to the schematics, but I believe tha the ldo7_reg is not the
correct regulator to be used for hdmi.

If you have access and it is really ldo7_reg, then we should have this in the
omap5-igep0050.dts file:

&ldo5_reg {
	status = "okay";
	regulator-min-microvolt = <1800000>;
	regulator-max-microvolt = <1800000>;
};

Regards,
Peter

 arch/arm/boot/dts/omap5-igep0050.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Ujfalusi April 29, 2016, 10:22 a.m. UTC | #1
On 04/29/16 13:21, Peter Ujfalusi wrote:
> ldo7_reg should not work as regulator since it is set to 'disabled' state
> in the omap5-board-common.dtsi and the state is not changed to 'okay'
> this means that the ldo7_reg is not available to be used in the igep0050
> DTS file.
> ldo4_reg is used by all other OMAP5 boards and this is most likely the
> correct regulator to use with hdmi.
> The hdmi needs 1.8V, but the ldo7_reg, based on the dtsi is 2V only.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Tony,
> 
> I don't have access to the schematics, but I believe tha the ldo7_reg is not the
> correct regulator to be used for hdmi.
> 
> If you have access and it is really ldo7_reg, then we should have this in the
> omap5-igep0050.dts file:
> 
> &ldo5_reg {

ldo7_reg, obviously ;)

> 	status = "okay";
> 	regulator-min-microvolt = <1800000>;
> 	regulator-max-microvolt = <1800000>;
> };
> 
> Regards,
> Peter
> 
>  arch/arm/boot/dts/omap5-igep0050.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts
> index 46ecb1dd3b5c..6c8d40327c68 100644
> --- a/arch/arm/boot/dts/omap5-igep0050.dts
> +++ b/arch/arm/boot/dts/omap5-igep0050.dts
> @@ -20,7 +20,7 @@
>  };
>  
>  &hdmi {
> -	vdda-supply = <&ldo7_reg>;
> +	vdda-supply = <&ldo4_reg>;
>  };
>  
>  &i2c4 {
>
Tony Lindgren May 4, 2016, 5:26 p.m. UTC | #2
Hi,

Adding Nishanth to Cc.

* Peter Ujfalusi <peter.ujfalusi@ti.com> [160429 05:15]:
> ldo7_reg, obviously ;)
> 
> > 	status = "okay";
> > 	regulator-min-microvolt = <1800000>;
> > 	regulator-max-microvolt = <1800000>;
> > };

It really seems to be ldo7, otherwise there's no HDMI output. I don't
have the schematics either.

But it seems we have at least two other regressions in Linux next that
prevent me from testing this properly:

1. On igepv5, I get this for the MMC regulator

ldo9: bypassed regulator has no supply!
ldo9: failed to get the current voltage(-517)
palmas-pmic 48070000.i2c:palmas@48:palmas_pmic: failed to register 48070000.i2c:palmar

I'm pretty sure it really is using the ldo9 for MMC just like
omap5-uevm.. Nishanth suggested it may use something else, but
why would it as ldo9 has a nice voltage range?

2. On both omap5-uevm and igepv5, NFSroot hangs

It seems that NFSroot boots to the point where PM runtime now
just shuts down some regulator affecting the USB connected
smsc Ethernet adapter?

Regards,

Tony
Nishanth Menon May 4, 2016, 6:01 p.m. UTC | #3
On 05/04/2016 12:26 PM, Tony Lindgren wrote:
> Hi,
> 
> Adding Nishanth to Cc.
> 
> * Peter Ujfalusi <peter.ujfalusi@ti.com> [160429 05:15]:
>> ldo7_reg, obviously ;)
>>
>>> 	status = "okay";
>>> 	regulator-min-microvolt = <1800000>;
>>> 	regulator-max-microvolt = <1800000>;
>>> };
> 
> It really seems to be ldo7, otherwise there's no HDMI output. I don't
> have the schematics either.
> 
> But it seems we have at least two other regressions in Linux next that
> prevent me from testing this properly:
> 
> 1. On igepv5, I get this for the MMC regulator
> 
> ldo9: bypassed regulator has no supply!
> ldo9: failed to get the current voltage(-517)
> palmas-pmic 48070000.i2c:palmas@48:palmas_pmic: failed to register 48070000.i2c:palmar
> 
> I'm pretty sure it really is using the ldo9 for MMC just like
> omap5-uevm.. Nishanth suggested it may use something else, but
> why would it as ldo9 has a nice voltage range?
> 
> 2. On both omap5-uevm and igepv5, NFSroot hangs
> 
> It seems that NFSroot boots to the point where PM runtime now
> just shuts down some regulator affecting the USB connected
> smsc Ethernet adapter?
> 
> Regards,

This one is interesting..
BayLibre uEVM:
https://storage.kernelci.org/next/next-20160504/arm-omap2plus_defconfig/lab-baylibre-seattle/boot-omap5-uevm_rootfs:mmc.txt

My uEVM:
https://github.com/nmenon/kernel-test-logs/blob/next-20160504/omap2plus_defconfig/omap5-evm.txt

Mine boots, but BayLibre one does not. So, that got me started
thinking it was bootloader... but then I realize it could be SDCard
since they are dual voltage. U-boot starting v2013.07-rc1 included
code that would set to bypass or program voltage for LDO9 based on
card voltage needed. It is possible (since my card seems to need 3.0v,
not 3.3v), that bypass to VCC_3v3_SDIO was never needed - but the
cards that Baylibre board could probably be setup in bypass.

I will send in a patch assuming (without access to igev5 schematics -
based on how it seems to be booting), that sdio path.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts
index 46ecb1dd3b5c..6c8d40327c68 100644
--- a/arch/arm/boot/dts/omap5-igep0050.dts
+++ b/arch/arm/boot/dts/omap5-igep0050.dts
@@ -20,7 +20,7 @@ 
 };
 
 &hdmi {
-	vdda-supply = <&ldo7_reg>;
+	vdda-supply = <&ldo4_reg>;
 };
 
 &i2c4 {