| Message ID | 1462699496-16646-1-git-send-email-krzk@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Krzysztof, On 05/08/2016 05:24 AM, Krzysztof Kozlowski wrote: > The samsung_clk_init() cannot return NULL. Either it returns allocated > memory or it panics. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > drivers/clk/samsung/clk-exynos5420.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c > index 92382cef9f90..770c0f007c6b 100644 > --- a/drivers/clk/samsung/clk-exynos5420.c > +++ b/drivers/clk/samsung/clk-exynos5420.c > @@ -1356,8 +1356,6 @@ static void __init exynos5x_clk_init(struct device_node *np, > exynos5x_soc = soc; > > ctx = samsung_clk_init(np, reg_base, CLK_NR_CLKS); > - if (!ctx) > - panic("%s: unable to allocate context.\n", __func__); > Indeed, the check is superfluous. I see that most callers [0] currently do the same, so probably makes sense to remove those too in this patch. Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> [0]: drivers/clk/samsung/clk-exynos4.c drivers/clk/samsung/clk-exynos5250.c drivers/clk/samsung/clk-exynos5440.c drivers/clk/samsung/clk-s3c2410.c drivers/clk/samsung/clk-s3c2412.c drivers/clk/samsung/clk-s3c2443.c drivers/clk/samsung/clk-s3c64xx.c drivers/clk/samsung/clk-s5pv210.c Best regards,
On Mon, May 09, 2016 at 09:32:47AM -0400, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/08/2016 05:24 AM, Krzysztof Kozlowski wrote: > > The samsung_clk_init() cannot return NULL. Either it returns allocated > > memory or it panics. > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > drivers/clk/samsung/clk-exynos5420.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c > > index 92382cef9f90..770c0f007c6b 100644 > > --- a/drivers/clk/samsung/clk-exynos5420.c > > +++ b/drivers/clk/samsung/clk-exynos5420.c > > @@ -1356,8 +1356,6 @@ static void __init exynos5x_clk_init(struct device_node *np, > > exynos5x_soc = soc; > > > > ctx = samsung_clk_init(np, reg_base, CLK_NR_CLKS); > > - if (!ctx) > > - panic("%s: unable to allocate context.\n", __func__); > > > > Indeed, the check is superfluous. I see that most callers [0] currently > do the same, so probably makes sense to remove those too in this patch. > > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Thanks, I'll change this everywhere. Best regards, Krzysztof
diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c index 92382cef9f90..770c0f007c6b 100644 --- a/drivers/clk/samsung/clk-exynos5420.c +++ b/drivers/clk/samsung/clk-exynos5420.c @@ -1356,8 +1356,6 @@ static void __init exynos5x_clk_init(struct device_node *np, exynos5x_soc = soc; ctx = samsung_clk_init(np, reg_base, CLK_NR_CLKS); - if (!ctx) - panic("%s: unable to allocate context.\n", __func__); samsung_clk_of_register_fixed_ext(ctx, exynos5x_fixed_rate_ext_clks, ARRAY_SIZE(exynos5x_fixed_rate_ext_clks),
The samsung_clk_init() cannot return NULL. Either it returns allocated memory or it panics. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/clk/samsung/clk-exynos5420.c | 2 -- 1 file changed, 2 deletions(-)