diff mbox

ARM: at91/defconfig: sama5: add CONFIG_FHANDLE

Message ID 1462867383-31961-1-git-send-email-nicolas.ferre@atmel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Nicolas Ferre May 10, 2016, 8:03 a.m. UTC
CONFIG_FHANDLE is listed as a mandatory kernel option for systemd. So
explicitly enable it to allow easy use of systemd userspace.

Reported-by: Marek Vasut <marex@denx.de>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
Hi Marek,

It seems that on my side, CONFIG_FHANDLE is not selected automatically...
So I add this patch: can you tell me your thoughts?

Bye,
   Nico.

 arch/arm/configs/sama5_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Marek Vasut May 10, 2016, 12:31 p.m. UTC | #1
On 05/10/2016 10:03 AM, Nicolas Ferre wrote:
> CONFIG_FHANDLE is listed as a mandatory kernel option for systemd. So
> explicitly enable it to allow easy use of systemd userspace.
> 
> Reported-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> Hi Marek,

Hi!

> It seems that on my side, CONFIG_FHANDLE is not selected automatically...
> So I add this patch: can you tell me your thoughts?

Uh, weird, I tried this on next just now:

linux-2.6$ git describe HEAD
next-20160510

linux-2.6$ export ARCH=arm ; export CROSS_COMPILE=arm-linux-gnueabi-

linux-2.6$ make sama5_defconfig ; grep FHANDLE .config
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o
  SHIPPED scripts/kconfig/zconf.tab.c
  SHIPPED scripts/kconfig/zconf.lex.c
  SHIPPED scripts/kconfig/zconf.hash.c
  HOSTCC  scripts/kconfig/zconf.tab.o
  HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#
CONFIG_FHANDLE=y

> Bye,
>    Nico.
> 
>  arch/arm/configs/sama5_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig
> index 307f92b31e57..9cb1a85bb166 100644
> --- a/arch/arm/configs/sama5_defconfig
> +++ b/arch/arm/configs/sama5_defconfig
> @@ -1,6 +1,7 @@
>  # CONFIG_LOCALVERSION_AUTO is not set
>  # CONFIG_SWAP is not set
>  CONFIG_SYSVIPC=y
> +CONFIG_FHANDLE=y
>  CONFIG_IRQ_DOMAIN_DEBUG=y
>  CONFIG_LOG_BUF_SHIFT=14
>  CONFIG_CGROUPS=y
>
Nicolas Ferre May 10, 2016, 12:42 p.m. UTC | #2
Le 10/05/2016 14:31, Marek Vasut a écrit :
> On 05/10/2016 10:03 AM, Nicolas Ferre wrote:
>> CONFIG_FHANDLE is listed as a mandatory kernel option for systemd. So
>> explicitly enable it to allow easy use of systemd userspace.
>>
>> Reported-by: Marek Vasut <marex@denx.de>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>> ---
>> Hi Marek,
> 
> Hi!
> 
>> It seems that on my side, CONFIG_FHANDLE is not selected automatically...
>> So I add this patch: can you tell me your thoughts?
> 
> Uh, weird, I tried this on next just now:
> 
> linux-2.6$ git describe HEAD
> next-20160510
> 
> linux-2.6$ export ARCH=arm ; export CROSS_COMPILE=arm-linux-gnueabi-
> 
> linux-2.6$ make sama5_defconfig ; grep FHANDLE .config
>   HOSTCC  scripts/basic/fixdep
>   HOSTCC  scripts/kconfig/conf.o
>   SHIPPED scripts/kconfig/zconf.tab.c
>   SHIPPED scripts/kconfig/zconf.lex.c
>   SHIPPED scripts/kconfig/zconf.hash.c
>   HOSTCC  scripts/kconfig/zconf.tab.o
>   HOSTLD  scripts/kconfig/conf
> #
> # configuration written to .config
> #
> CONFIG_FHANDLE=y

Absolutely. The patch f76be61755c5 ("Make CONFIG_FHANDLE default y") has
been added in v4.6-rc2... while I was doing my tests on at91-next that
is based on v4.6-rc1 :-\

Anyway. It's in now. Thanks,

Bye,
   Nicolas

>>  arch/arm/configs/sama5_defconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig
>> index 307f92b31e57..9cb1a85bb166 100644
>> --- a/arch/arm/configs/sama5_defconfig
>> +++ b/arch/arm/configs/sama5_defconfig
>> @@ -1,6 +1,7 @@
>>  # CONFIG_LOCALVERSION_AUTO is not set
>>  # CONFIG_SWAP is not set
>>  CONFIG_SYSVIPC=y
>> +CONFIG_FHANDLE=y
>>  CONFIG_IRQ_DOMAIN_DEBUG=y
>>  CONFIG_LOG_BUF_SHIFT=14
>>  CONFIG_CGROUPS=y
>>
> 
>
Marek Vasut May 10, 2016, 12:46 p.m. UTC | #3
On 05/10/2016 02:42 PM, Nicolas Ferre wrote:
> Le 10/05/2016 14:31, Marek Vasut a écrit :
>> On 05/10/2016 10:03 AM, Nicolas Ferre wrote:
>>> CONFIG_FHANDLE is listed as a mandatory kernel option for systemd. So
>>> explicitly enable it to allow easy use of systemd userspace.
>>>
>>> Reported-by: Marek Vasut <marex@denx.de>
>>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>>> ---
>>> Hi Marek,
>>
>> Hi!
>>
>>> It seems that on my side, CONFIG_FHANDLE is not selected automatically...
>>> So I add this patch: can you tell me your thoughts?
>>
>> Uh, weird, I tried this on next just now:
>>
>> linux-2.6$ git describe HEAD
>> next-20160510
>>
>> linux-2.6$ export ARCH=arm ; export CROSS_COMPILE=arm-linux-gnueabi-
>>
>> linux-2.6$ make sama5_defconfig ; grep FHANDLE .config
>>   HOSTCC  scripts/basic/fixdep
>>   HOSTCC  scripts/kconfig/conf.o
>>   SHIPPED scripts/kconfig/zconf.tab.c
>>   SHIPPED scripts/kconfig/zconf.lex.c
>>   SHIPPED scripts/kconfig/zconf.hash.c
>>   HOSTCC  scripts/kconfig/zconf.tab.o
>>   HOSTLD  scripts/kconfig/conf
>> #
>> # configuration written to .config
>> #
>> CONFIG_FHANDLE=y
> 
> Absolutely. The patch f76be61755c5 ("Make CONFIG_FHANDLE default y") has
> been added in v4.6-rc2... while I was doing my tests on at91-next that
> is based on v4.6-rc1 :-\
> 
> Anyway. It's in now. Thanks,

Cool, thanks :)
diff mbox

Patch

diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig
index 307f92b31e57..9cb1a85bb166 100644
--- a/arch/arm/configs/sama5_defconfig
+++ b/arch/arm/configs/sama5_defconfig
@@ -1,6 +1,7 @@ 
 # CONFIG_LOCALVERSION_AUTO is not set
 # CONFIG_SWAP is not set
 CONFIG_SYSVIPC=y
+CONFIG_FHANDLE=y
 CONFIG_IRQ_DOMAIN_DEBUG=y
 CONFIG_LOG_BUF_SHIFT=14
 CONFIG_CGROUPS=y