From patchwork Wed May 25 09:49:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caesar Wang X-Patchwork-Id: 9135067 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 40F3860221 for ; Wed, 25 May 2016 09:52:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3526728110 for ; Wed, 25 May 2016 09:52:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 29A39282D7; Wed, 25 May 2016 09:52:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2995428110 for ; Wed, 25 May 2016 09:52:51 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1b5VTI-0000Ak-LS; Wed, 25 May 2016 09:51:24 +0000 Received: from mail-pf0-f196.google.com ([209.85.192.196]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1b5VSf-0007qB-9h; Wed, 25 May 2016 09:50:47 +0000 Received: by mail-pf0-f196.google.com with SMTP id 145so4865526pfz.1; Wed, 25 May 2016 02:50:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1TzOoAGxiHjuwkkG/9CEpun1ST1EbKxur51FMyYkvao=; b=ev3MxUcRgUefR1QRSxZokvbld75UWU93xekPn6mZ5V5QjkdgdnjbnFse5Qk7Ppkoil U/KknvpDwdr7btt7a9+AuF+ytmu+D8z1X6kzEFFxPK17qnmG9wn3cPYnp0w3eQL/5cdX qyr3LY3VteAiPz3cKaGraVQ8QAT9Ys59kC3WqJv/F+nKJOqu7U4+oXDT7BFvpcXEEkxl QxemvqWLsIxqBoUckOjFref/N8Qz4f3UsuvnW7FhTsqwYD+vbS83l2QgmzGb+QlxzOiF U4fArUWy3F32mzaTvcFYSOSYuUKgERk2IhgdA/57I7lzJ37W3R9UwINMaOuVV9Wa6g1g Bxmg== X-Gm-Message-State: ALyK8tJCKJfnQeLlcOwuaKzc1nqBDsqtk1Yh424bKGftdw0T8B64Eh8hhhXmUXAOn30znA== X-Received: by 10.98.113.1 with SMTP id m1mr4245273pfc.150.1464169824397; Wed, 25 May 2016 02:50:24 -0700 (PDT) Received: from localhost.localdomain ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id t8sm11406898paw.16.2016.05.25.02.50.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 25 May 2016 02:50:23 -0700 (PDT) From: Caesar Wang To: daniel.lezcano@linaro.org, Heiko Stuebner Subject: [PATCH 2/5] clocksource: rockchip: remove unnecessary clear irq before request_irq Date: Wed, 25 May 2016 17:49:59 +0800 Message-Id: <1464169802-6033-3-git-send-email-wxt@rock-chips.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464169802-6033-1-git-send-email-wxt@rock-chips.com> References: <1464169802-6033-1-git-send-email-wxt@rock-chips.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160525_025045_461270_2C1EFB5D X-CRM114-Status: UNSURE ( 9.24 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: huangtao@rock-chips.com, dianders@chromium.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, smbarber@google.com, cf@rock-chips.com, briannorris@google.com, Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Caesar Wang MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Huang Tao rk_timer_interrupt_clear and rk_timer_disable is unnecessary before request_irq. Timer should keep disabled before booting Linux. Signed-off-by: Huang Tao Cc: Daniel Lezcano Cc: Thomas Gleixner Cc: Heiko Stuebner Tested-by: Jianqun Xu Signed-off-by: Caesar Wang --- drivers/clocksource/rockchip_timer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c index b991b28..b93fed6 100644 --- a/drivers/clocksource/rockchip_timer.c +++ b/drivers/clocksource/rockchip_timer.c @@ -158,9 +158,6 @@ static void __init rk_timer_init(struct device_node *np) ce->cpumask = cpumask_of(0); ce->rating = 250; - rk_timer_interrupt_clear(ce); - rk_timer_disable(ce); - ret = request_irq(irq, rk_timer_interrupt, IRQF_TIMER, TIMER_NAME, ce); if (ret) { pr_err("Failed to initialize '%s': %d\n", TIMER_NAME, ret);