| Message ID | 1464711804-19256-6-git-send-email-wens@csie.org (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
Hi, On Wed, Jun 01, 2016 at 12:23:23AM +0800, Chen-Yu Tsai wrote: > These 3 regulators are provided in sunxi-common-regulators.dtsi. > 3.0V/3.3V and 5.0V are commonly used voltages in Allwinner devices. > These dummy regulators provide a stand-in when bindings that require > one, but the real regulator is not supported yet. > > Since these are no longer needed, we can disable them. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > arch/arm/boot/dts/sun9i-a80-optimus.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/sun9i-a80-optimus.dts b/arch/arm/boot/dts/sun9i-a80-optimus.dts > index 6cfc02194035..991337d1d6f1 100644 > --- a/arch/arm/boot/dts/sun9i-a80-optimus.dts > +++ b/arch/arm/boot/dts/sun9i-a80-optimus.dts > @@ -322,6 +322,18 @@ > > #include "axp809.dtsi" > > +®_vcc3v0 { > + status = "disabled"; > +}; > + > +®_vcc3v3 { > + status = "disabled"; > +}; > + > +®_vcc5v0 { > + status = "disabled"; > +}; > + Why not remove the include entirely? Maxime
On Wed, Jun 1, 2016 at 3:01 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Wed, Jun 01, 2016 at 12:23:23AM +0800, Chen-Yu Tsai wrote: >> These 3 regulators are provided in sunxi-common-regulators.dtsi. >> 3.0V/3.3V and 5.0V are commonly used voltages in Allwinner devices. >> These dummy regulators provide a stand-in when bindings that require >> one, but the real regulator is not supported yet. >> >> Since these are no longer needed, we can disable them. >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> >> --- >> arch/arm/boot/dts/sun9i-a80-optimus.dts | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun9i-a80-optimus.dts b/arch/arm/boot/dts/sun9i-a80-optimus.dts >> index 6cfc02194035..991337d1d6f1 100644 >> --- a/arch/arm/boot/dts/sun9i-a80-optimus.dts >> +++ b/arch/arm/boot/dts/sun9i-a80-optimus.dts >> @@ -322,6 +322,18 @@ >> >> #include "axp809.dtsi" >> >> +®_vcc3v0 { >> + status = "disabled"; >> +}; >> + >> +®_vcc3v3 { >> + status = "disabled"; >> +}; >> + >> +®_vcc5v0 { >> + status = "disabled"; >> +}; >> + > > Why not remove the include entirely? reg_usb1_vbus is still used. Or I could just copy it and get rid of the include. ChenYu
On Wed, Jun 01, 2016 at 10:45:51AM +0800, Chen-Yu Tsai wrote: > On Wed, Jun 1, 2016 at 3:01 AM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > Hi, > > > > On Wed, Jun 01, 2016 at 12:23:23AM +0800, Chen-Yu Tsai wrote: > >> These 3 regulators are provided in sunxi-common-regulators.dtsi. > >> 3.0V/3.3V and 5.0V are commonly used voltages in Allwinner devices. > >> These dummy regulators provide a stand-in when bindings that require > >> one, but the real regulator is not supported yet. > >> > >> Since these are no longer needed, we can disable them. > >> > >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> > >> --- > >> arch/arm/boot/dts/sun9i-a80-optimus.dts | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/sun9i-a80-optimus.dts b/arch/arm/boot/dts/sun9i-a80-optimus.dts > >> index 6cfc02194035..991337d1d6f1 100644 > >> --- a/arch/arm/boot/dts/sun9i-a80-optimus.dts > >> +++ b/arch/arm/boot/dts/sun9i-a80-optimus.dts > >> @@ -322,6 +322,18 @@ > >> > >> #include "axp809.dtsi" > >> > >> +®_vcc3v0 { > >> + status = "disabled"; > >> +}; > >> + > >> +®_vcc3v3 { > >> + status = "disabled"; > >> +}; > >> + > >> +®_vcc5v0 { > >> + status = "disabled"; > >> +}; > >> + > > > > Why not remove the include entirely? > > reg_usb1_vbus is still used. Or I could just copy it and > get rid of the include. Ah yes, it is on the Optimus (but not the cubieboard I initially looked at). Since we have that other regulator usb3 regulator, we can simply remove it. Maxime
diff --git a/arch/arm/boot/dts/sun9i-a80-optimus.dts b/arch/arm/boot/dts/sun9i-a80-optimus.dts index 6cfc02194035..991337d1d6f1 100644 --- a/arch/arm/boot/dts/sun9i-a80-optimus.dts +++ b/arch/arm/boot/dts/sun9i-a80-optimus.dts @@ -322,6 +322,18 @@ #include "axp809.dtsi" +®_vcc3v0 { + status = "disabled"; +}; + +®_vcc3v3 { + status = "disabled"; +}; + +®_vcc5v0 { + status = "disabled"; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&uart0_pins_a>;
These 3 regulators are provided in sunxi-common-regulators.dtsi. 3.0V/3.3V and 5.0V are commonly used voltages in Allwinner devices. These dummy regulators provide a stand-in when bindings that require one, but the real regulator is not supported yet. Since these are no longer needed, we can disable them. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- arch/arm/boot/dts/sun9i-a80-optimus.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+)