diff mbox

[RFT,4/4] ARM: dts: imx28-tx28: fix dtc warning

Message ID 1465134747-13536-1-git-send-email-stefan.wahren@i2se.com (mailing list archive)
State New, archived
Headers show

Commit Message

Stefan Wahren June 5, 2016, 1:52 p.m. UTC
This fixes the following dtc warning by removing the unnecessary unit:

Warning (unit_address_vs_reg): Node /matrix-keypad@0 has a unit name,
but no reg property

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 arch/arm/boot/dts/imx28-tx28.dts |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam June 5, 2016, 2:05 p.m. UTC | #1
On Sun, Jun 5, 2016 at 10:52 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> This fixes the following dtc warning by removing the unnecessary unit:
>
> Warning (unit_address_vs_reg): Node /matrix-keypad@0 has a unit name,
> but no reg property
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>  arch/arm/boot/dts/imx28-tx28.dts |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> index fd20e99..0ebbc83 100644
> --- a/arch/arm/boot/dts/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/imx28-tx28.dts
> @@ -173,7 +173,7 @@
>                 default-brightness-level = <50>;
>         };
>
> -       matrix_keypad: matrix-keypad@0 {
> +       matrix_keypad: matrix-keypad {
>                 compatible = "gpio-matrix-keypad";
>                 col-gpios = <
>                         &gpio5 0 GPIO_ACTIVE_HIGH

Looks good. Adding Marek on Cc.
Fabio Estevam June 5, 2016, 2:21 p.m. UTC | #2
On Sun, Jun 5, 2016 at 11:05 AM, Fabio Estevam <festevam@gmail.com> wrote:

> Looks good. Adding Marek on Cc.

Ops, this is Lothar's board not Marek's :-)
Lothar Waßmann June 6, 2016, 6:33 a.m. UTC | #3
Hi,

On Sun,  5 Jun 2016 13:52:27 +0000 Stefan Wahren wrote:
> This fixes the following dtc warning by removing the unnecessary unit:
> 
> Warning (unit_address_vs_reg): Node /matrix-keypad@0 has a unit name,
> but no reg property
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>  arch/arm/boot/dts/imx28-tx28.dts |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> index fd20e99..0ebbc83 100644
> --- a/arch/arm/boot/dts/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/imx28-tx28.dts
> @@ -173,7 +173,7 @@
>  		default-brightness-level = <50>;
>  	};
>  
> -	matrix_keypad: matrix-keypad@0 {
> +	matrix_keypad: matrix-keypad {
>  		compatible = "gpio-matrix-keypad";
>  		col-gpios = <
>  			&gpio5 0 GPIO_ACTIVE_HIGH
>
Acked-By: Lothar Waßmann <LW@KARO-electronics.de>


Lothar Waßmann
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
index fd20e99..0ebbc83 100644
--- a/arch/arm/boot/dts/imx28-tx28.dts
+++ b/arch/arm/boot/dts/imx28-tx28.dts
@@ -173,7 +173,7 @@ 
 		default-brightness-level = <50>;
 	};
 
-	matrix_keypad: matrix-keypad@0 {
+	matrix_keypad: matrix-keypad {
 		compatible = "gpio-matrix-keypad";
 		col-gpios = <
 			&gpio5 0 GPIO_ACTIVE_HIGH