| Message ID | 1465216900-11755-4-git-send-email-pramod.kumar@broadcom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 06/06/2016 05:41 AM, Pramod Kumar wrote: > Add DT binding doc for Broadcom MDIO bus multiplexer driver. > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > +for example: > + mdio_mux_iproc: mdio-mux@6602023c { I think Rob wanted you to drop the underscores here in favor of dashes, there are more below, not critical imho. > + compatible = "brcm,mdio-mux-iproc"; > + reg = <0x6602023c 0x14>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + mdio@0 { > + reg = <0x0>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + pci_phy0: pci-phy@0 {
Hi Florian, > -----Original Message----- > From: Florian Fainelli [mailto:f.fainelli@gmail.com] > Sent: 07 June 2016 00:06 > To: Pramod Kumar; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; > Kumar Gala; Catalin Marinas; Will Deacon; Kishon Vijay Abraham I; David S. > Miller > Cc: devicetree@vger.kernel.org; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; bcm-kernel-feedback-list@broadcom.com; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for > Broadcom MDIO bus multiplexer > > On 06/06/2016 05:41 AM, Pramod Kumar wrote: > > Add DT binding doc for Broadcom MDIO bus multiplexer driver. > > > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com> > > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > > > > +for example: > > + mdio_mux_iproc: mdio-mux@6602023c { > > I think Rob wanted you to drop the underscores here in favor of dashes, > there > are more below, not critical imho. > I'd changed node name in favor of dashes. I don't think Label could be written with hyphens,"-". "-" in label provides DT parsing error. > > + compatible = "brcm,mdio-mux-iproc"; > > + reg = <0x6602023c 0x14>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + mdio@0 { > > + reg = <0x0>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + pci_phy0: pci-phy@0 { > > > -- > Florian Regards, Pramod
On Tue, Jun 07, 2016 at 05:27:29PM +0530, Pramod Kumar wrote: > Hi Florian, > > > -----Original Message----- > > From: Florian Fainelli [mailto:f.fainelli@gmail.com] > > Sent: 07 June 2016 00:06 > > To: Pramod Kumar; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; > > Kumar Gala; Catalin Marinas; Will Deacon; Kishon Vijay Abraham I; David S. > > Miller > > Cc: devicetree@vger.kernel.org; netdev@vger.kernel.org; linux- > > kernel@vger.kernel.org; bcm-kernel-feedback-list@broadcom.com; linux-arm- > > kernel@lists.infradead.org > > Subject: Re: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for > > Broadcom MDIO bus multiplexer > > > > On 06/06/2016 05:41 AM, Pramod Kumar wrote: > > > Add DT binding doc for Broadcom MDIO bus multiplexer driver. > > > > > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > > Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com> > > > > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > > > > > > > +for example: > > > + mdio_mux_iproc: mdio-mux@6602023c { > > > > I think Rob wanted you to drop the underscores here in favor of dashes, > > there > > are more below, not critical imho. > > > > I'd changed node name in favor of dashes. I don't think Label could be > written with hyphens,"-". "-" in label provides DT parsing error. Right. Labels don't matter as they aren't part of the binding. Rob
On Mon, Jun 06, 2016 at 06:11:36PM +0530, Pramod Kumar wrote: > Add DT binding doc for Broadcom MDIO bus multiplexer driver. > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com> > --- > .../bindings/net/brcm,mdio-mux-iproc.txt | 59 ++++++++++++++++++++++ > 1 file changed, 59 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt b/Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt new file mode 100644 index 0000000..dfe287a --- /dev/null +++ b/Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt @@ -0,0 +1,59 @@ +Properties for an MDIO bus multiplexer found in Broadcom iProc based SoCs. + +This MDIO bus multiplexer defines buses that could be internal as well as +external to SoCs and could accept MDIO transaction compatible to C-22 or +C-45 Clause. When child bus is selected, one needs to select these two +properties as well to generate desired MDIO transaction on appropriate bus. + +Required properties in addition to the generic multiplexer properties: + +MDIO multiplexer node: +- compatible: brcm,mdio-mux-iproc. + +Every non-ethernet PHY requires a compatible so that it could be probed based +on this compatible string. + +Additional information regarding generic multiplexer properties can be found +at- Documentation/devicetree/bindings/net/mdio-mux.txt + + +for example: + mdio_mux_iproc: mdio-mux@6602023c { + compatible = "brcm,mdio-mux-iproc"; + reg = <0x6602023c 0x14>; + #address-cells = <1>; + #size-cells = <0>; + + mdio@0 { + reg = <0x0>; + #address-cells = <1>; + #size-cells = <0>; + + pci_phy0: pci-phy@0 { + compatible = "brcm,ns2-pcie-phy"; + reg = <0x0>; + #phy-cells = <0>; + }; + }; + + mdio@7 { + reg = <0x7>; + #address-cells = <1>; + #size-cells = <0>; + + pci_phy1: pci-phy@0 { + compatible = "brcm,ns2-pcie-phy"; + reg = <0x0>; + #phy-cells = <0>; + }; + }; + mdio@10 { + reg = <0x10>; + #address-cells = <1>; + #size-cells = <0>; + + gphy0: eth-phy@10 { + reg = <0x10>; + }; + }; + };