From patchwork Tue Jun 7 17:25:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Dooks X-Patchwork-Id: 9162075 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 432A260467 for ; Tue, 7 Jun 2016 17:26:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2F6522833E for ; Tue, 7 Jun 2016 17:26:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 23BEC28352; Tue, 7 Jun 2016 17:26:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4672C2833E for ; Tue, 7 Jun 2016 17:26:53 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1bAKkv-000651-NA; Tue, 07 Jun 2016 17:25:33 +0000 Received: from 82-70-136-246.dsl.in-addr.zen.co.uk ([82.70.136.246] helo=rainbowdash.ducie.codethink.co.uk) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1bAKks-0005pP-E9 for linux-arm-kernel@lists.infradead.org; Tue, 07 Jun 2016 17:25:31 +0000 Received: from ben by rainbowdash.ducie.codethink.co.uk with local (Exim 4.87) (envelope-from ) id 1bAKkU-0001Vj-Ui; Tue, 07 Jun 2016 18:25:06 +0100 From: Ben Dooks To: linux-kernel@lists.codethink.co.uk Subject: [PATCH] pinctrl: nomadik: fix warnings from unexported functions Date: Tue, 7 Jun 2016 18:25:02 +0100 Message-Id: <1465320302-5770-1-git-send-email-ben.dooks@codethink.co.uk> X-Mailer: git-send-email 2.8.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160607_102530_737883_418F4B3C X-CRM114-Status: GOOD ( 10.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, Linus Walleij , Ben Dooks , linux-arm-kernel@lists.infradead.org, Alessandro Rubini MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP There are five functions in the driver that are defined but only used locally. Make these static to avoid the following warnings: drivers/pinctrl/nomadik/pinctrl-nomadik.c:1036:6: warning: symbol 'nmk_gpio_clocks_enable' was not declared. Should it be static? drivers/pinctrl/nomadik/pinctrl-nomadik.c:1050:6: warning: symbol 'nmk_gpio_clocks_disable' was not declared. Should it be static? drivers/pinctrl/nomadik/pinctrl-nomadik.c:1073:6: warning: symbol 'nmk_gpio_wakeups_suspend' was not declared. Should it be static? drivers/pinctrl/nomadik/pinctrl-nomadik.c:1094:6: warning: symbol 'nmk_gpio_wakeups_resume' was not declared. Should it be static? drivers/pinctrl/nomadik/pinctrl-nomadik.c:1120:6: warning: symbol 'nmk_gpio_read_pull' was not declared. Should it be static? Note, this now produces warnings that these functions are defined but not used. Signed-off-by: Ben Dooks --- Cc: Linus Walleij Cc: Alessandro Rubini Cc: linux-arm-kernel@lists.infradead.org Cc: linux-gpio@vger.kernel.org --- drivers/pinctrl/nomadik/pinctrl-nomadik.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c index 38facef..a7cce0f 100644 --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c @@ -1033,7 +1033,7 @@ static inline void nmk_gpio_dbg_show_one(struct seq_file *s, #define nmk_gpio_dbg_show NULL #endif -void nmk_gpio_clocks_enable(void) +static void nmk_gpio_clocks_enable(void) { int i; @@ -1047,7 +1047,7 @@ void nmk_gpio_clocks_enable(void) } } -void nmk_gpio_clocks_disable(void) +static void nmk_gpio_clocks_disable(void) { int i; @@ -1070,7 +1070,7 @@ void nmk_gpio_clocks_disable(void) * PM ops are not used since this needs to be done at the end, after all the * other drivers are done with their suspend callbacks. */ -void nmk_gpio_wakeups_suspend(void) +static void nmk_gpio_wakeups_suspend(void) { int i; @@ -1091,7 +1091,7 @@ void nmk_gpio_wakeups_suspend(void) } } -void nmk_gpio_wakeups_resume(void) +static void nmk_gpio_wakeups_resume(void) { int i; @@ -1117,7 +1117,7 @@ void nmk_gpio_wakeups_resume(void) * Note: only pull up/down set via this driver can * be detected due to HW limitations. */ -void nmk_gpio_read_pull(int gpio_bank, u32 *pull_up) +statoc void nmk_gpio_read_pull(int gpio_bank, u32 *pull_up) { if (gpio_bank < NUM_BANKS) { struct nmk_gpio_chip *chip = nmk_gpio_chips[gpio_bank];