| Message ID | 1465368713-17866-1-git-send-email-m.szyprowski@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 06/08/2016 08:51 AM, Marek Szyprowski wrote: > Change return value back to -ENODEV when no region is defined for given > device. This restores old behavior of this function, as some drivers rely > on such error code. > > Reported-by: Liviu Dudau <liviu.dudau@arm.com> > Fixes: 59ce4039727ef40 ("of: reserved_mem: add support for using more than > one region for given device") > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> I think this needs to be added to the media tree, where the original patch it fixes was applied.
On Wed, Jun 08, 2016 at 08:51:53AM +0200, Marek Szyprowski wrote: > Change return value back to -ENODEV when no region is defined for given > device. This restores old behavior of this function, as some drivers rely > on such error code. > > Reported-by: Liviu Dudau <liviu.dudau@arm.com> > Fixes: 59ce4039727ef40 ("of: reserved_mem: add support for using more than > one region for given device") > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Liviu Dudau <Liviu.Dudau@arm.com> > --- > drivers/of/of_reserved_mem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c > index 3cf129f..06af99f 100644 > --- a/drivers/of/of_reserved_mem.c > +++ b/drivers/of/of_reserved_mem.c > @@ -334,7 +334,7 @@ int of_reserved_mem_device_init_by_idx(struct device *dev, > > target = of_parse_phandle(np, "memory-region", idx); > if (!target) > - return -EINVAL; > + return -ENODEV; > > rmem = __find_rmem(target); > of_node_put(target); > -- > 1.9.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Wed, Jun 8, 2016 at 1:51 AM, Marek Szyprowski <m.szyprowski@samsung.com> wrote: > Change return value back to -ENODEV when no region is defined for given > device. This restores old behavior of this function, as some drivers rely > on such error code. > > Reported-by: Liviu Dudau <liviu.dudau@arm.com> > Fixes: 59ce4039727ef40 ("of: reserved_mem: add support for using more than > one region for given device") > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/of/of_reserved_mem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Rob Herring <robh@kernel.org>
On 8 June 2016 at 18:35, Rob Herring <robh@kernel.org> wrote: > On Wed, Jun 8, 2016 at 1:51 AM, Marek Szyprowski > <m.szyprowski@samsung.com> wrote: >> Change return value back to -ENODEV when no region is defined for given >> device. This restores old behavior of this function, as some drivers rely >> on such error code. >> >> Reported-by: Liviu Dudau <liviu.dudau@arm.com> >> Fixes: 59ce4039727ef40 ("of: reserved_mem: add support for using more than >> one region for given device") >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> >> --- >> drivers/of/of_reserved_mem.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > Looks reasonable; FWIW Reviewed-by: Sumit Semwal <sumit.semwal@linaro.org> > Acked-by: Rob Herring <robh@kernel.org> > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c index 3cf129f..06af99f 100644 --- a/drivers/of/of_reserved_mem.c +++ b/drivers/of/of_reserved_mem.c @@ -334,7 +334,7 @@ int of_reserved_mem_device_init_by_idx(struct device *dev, target = of_parse_phandle(np, "memory-region", idx); if (!target) - return -EINVAL; + return -ENODEV; rmem = __find_rmem(target); of_node_put(target);
Change return value back to -ENODEV when no region is defined for given device. This restores old behavior of this function, as some drivers rely on such error code. Reported-by: Liviu Dudau <liviu.dudau@arm.com> Fixes: 59ce4039727ef40 ("of: reserved_mem: add support for using more than one region for given device") Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- drivers/of/of_reserved_mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)