From patchwork Thu Jun 9 01:35:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuah Khan X-Patchwork-Id: 9166123 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 19D8160572 for ; Thu, 9 Jun 2016 01:36:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0BDB0206AC for ; Thu, 9 Jun 2016 01:36:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 002DE282DC; Thu, 9 Jun 2016 01:36:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 281FA206AC for ; Thu, 9 Jun 2016 01:36:50 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1bAosc-0004LX-4Q; Thu, 09 Jun 2016 01:35:30 +0000 Received: from resqmta-po-06v.sys.comcast.net ([2001:558:fe16:19:96:114:154:165]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1bAosZ-00044r-74 for linux-arm-kernel@lists.infradead.org; Thu, 09 Jun 2016 01:35:28 +0000 Received: from resomta-po-17v.sys.comcast.net ([96.114.154.241]) by resqmta-po-06v.sys.comcast.net with SMTP id Aorxb8douBNj9AosDbsKUX; Thu, 09 Jun 2016 01:35:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1465436105; bh=yIwnhzl/Huff4lXs8e6kvTsRD6LgzbYnbq6Bn5LdnOo=; h=Received:Received:Received:From:To:Subject:Date:Message-Id; b=QbHFLAOJDaJA0jNSG5b0P8apD5rG2szmqo3hIaCddWr1dbnohQhGB8nDBI8pq0Rx0 /2J7FlqRg6VPIu6jtgKpK4TfrRRgqmdC6KfZavSXoGMcSpE/7ifkzUAYItRoe4+HPL ey4F6nZrrT9owNeS/GwDKwIFPXhRHPfqpOkoioYpQ0klMZncLylEbakpY2pY0BJEdd C7nwJkC1/4q4qBhAYbHJMwb+gd9txJq5AZKMz4QrtbowI2uF9/JDqLJNA5mOaBnV98 Q5PYUiLMw9Qs/q4n6ANGrwreYE2mbA3O08YrNjvRtpJQVala3ObszWtwemlKaXiti5 2cITM2PJC1cMw== Received: from mail.gonehiking.org ([73.181.52.62]) by resomta-po-17v.sys.comcast.net with comcast id 4Rb41t00H1LXgTt01Rb443; Thu, 09 Jun 2016 01:35:05 +0000 Received: from shuah-XPS-13-9350.sisa.samsung.com (shuah-xps.internal [192.168.1.87]) by mail.gonehiking.org (Postfix) with ESMTP id 19EB39F301; Wed, 8 Jun 2016 19:35:04 -0600 (MDT) From: Shuah Khan To: kyungmin.park@samsung.com, k.debski@samsung.com, jtp.park@samsung.com, mchehab@osg.samsung.com Subject: [PATCH] media: s5p-mfc fix video device release double release in probe error path Date: Wed, 8 Jun 2016 19:35:02 -0600 Message-Id: <1465436102-13827-1-git-send-email-shuahkh@osg.samsung.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160608_183527_339789_FAA54FFD X-CRM114-Status: UNSURE ( 6.34 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Fix Decoder and encoder video device double release in probe error path. video_device_release(dev->vfd_dec) get called twice if decoder register fails. Also, video_device_release(dev->vfd_enc) get called twice if encoder register fails. Signed-off-by: Shuah Khan Reviewed-by: Javier Martinez Canillas --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index 6ee620e..274b4f1 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c @@ -1266,7 +1266,6 @@ static int s5p_mfc_probe(struct platform_device *pdev) ret = video_register_device(dev->vfd_dec, VFL_TYPE_GRABBER, 0); if (ret) { v4l2_err(&dev->v4l2_dev, "Failed to register video device\n"); - video_device_release(dev->vfd_dec); goto err_dec_reg; } v4l2_info(&dev->v4l2_dev, @@ -1275,7 +1274,6 @@ static int s5p_mfc_probe(struct platform_device *pdev) ret = video_register_device(dev->vfd_enc, VFL_TYPE_GRABBER, 0); if (ret) { v4l2_err(&dev->v4l2_dev, "Failed to register video device\n"); - video_device_release(dev->vfd_enc); goto err_enc_reg; } v4l2_info(&dev->v4l2_dev,