diff mbox

ARM: dts: imx6ul-pico-hobbit: Fix Ethernet PHY reset GPIO

Message ID 1466008481-10576-1-git-send-email-diego.dorta@nxp.com (mailing list archive)
State New, archived
Headers show

Commit Message

Diego Dorta June 15, 2016, 4:34 p.m. UTC 
According to the imx6ul-pico-hobbit schematics the Ethernet PHY reset GPIO
is GPIO1_28, so fix it accordingly.

Also adjust the reset duration to 1ms, because the KSZ8081 datasheet
requires 500μs.

Signed-off-by: Diego Dorta <diego.dorta@nxp.com>
---
 arch/arm/boot/dts/imx6ul-pico-hobbit.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Fabio Estevam June 15, 2016, 4:59 p.m. UTC | #1 
On Wed, Jun 15, 2016 at 1:34 PM, Diego Dorta <diego.dorta@nxp.com> wrote:
> According to the imx6ul-pico-hobbit schematics the Ethernet PHY reset GPIO
> is GPIO1_28, so fix it accordingly.
>
> Also adjust the reset duration to 1ms, because the KSZ8081 datasheet
> requires 500μs.
>
> Signed-off-by: Diego Dorta <diego.dorta@nxp.com>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Shawn Guo June 16, 2016, 2:05 a.m. UTC | #2 
On Wed, Jun 15, 2016 at 01:34:41PM -0300, Diego Dorta wrote:
> According to the imx6ul-pico-hobbit schematics the Ethernet PHY reset GPIO
> is GPIO1_28, so fix it accordingly.
> 
> Also adjust the reset duration to 1ms, because the KSZ8081 datasheet
> requires 500μs.
> 
> Signed-off-by: Diego Dorta <diego.dorta@nxp.com>

Applied, thanks.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx6ul-pico-hobbit.dts b/arch/arm/boot/dts/imx6ul-pico-hobbit.dts
index 8ce1fec..e760cda 100644
--- a/arch/arm/boot/dts/imx6ul-pico-hobbit.dts
+++ b/arch/arm/boot/dts/imx6ul-pico-hobbit.dts
@@ -151,8 +151,8 @@ 
 	phy-mode = "rmii";
 	phy-handle = <&ethphy1>;
 	status = "okay";
-	phy-reset-gpios = <&gpio2 15 GPIO_ACTIVE_LOW>;
-	phy-reset-duration = <11>;
+	phy-reset-gpios = <&gpio1 28 GPIO_ACTIVE_LOW>;
+	phy-reset-duration = <1>;
 
 	mdio {
 		#address-cells = <1>;