From patchwork Wed Jun 22 11:42:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerd Hoffmann X-Patchwork-Id: 9192513 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A3AE36075A for ; Wed, 22 Jun 2016 11:44:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 90CB028364 for ; Wed, 22 Jun 2016 11:44:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 82A16283FA; Wed, 22 Jun 2016 11:44:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3ADF128364 for ; Wed, 22 Jun 2016 11:44:13 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bFgYW-0002Vw-SF; Wed, 22 Jun 2016 11:42:52 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bFgYN-0002QV-Im; Wed, 22 Jun 2016 11:42:44 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AE56678231; Wed, 22 Jun 2016 11:42:22 +0000 (UTC) Received: from nilsson.home.kraxel.org (ovpn-116-26.ams2.redhat.com [10.36.116.26]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5MBgLb7007305; Wed, 22 Jun 2016 07:42:22 -0400 Received: by nilsson.home.kraxel.org (Postfix, from userid 500) id E0414827AE; Wed, 22 Jun 2016 13:42:20 +0200 (CEST) From: Gerd Hoffmann To: linux-rpi-kernel@lists.infradead.org Subject: [PATCH 3/5] mmc: bcm2835-sdhost: zap mmiowb() [fixup] Date: Wed, 22 Jun 2016 13:42:16 +0200 Message-Id: <1466595738-2229-4-git-send-email-kraxel@redhat.com> In-Reply-To: <1466595738-2229-1-git-send-email-kraxel@redhat.com> References: <1466595738-2229-1-git-send-email-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 22 Jun 2016 11:42:22 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160622_044243_731297_0E8679FE X-CRM114-Status: UNSURE ( 8.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Stephen Warren , Lee Jones , linux-mmc@vger.kernel.org, open list , Eric Anholt , Gerd Hoffmann , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Arnd asked why they are needed. Seems they are not needed at all. Things are still working fine if I remove them. Guess the arm{,64} versions of writel() & friends take care already. Signed-off-by: Gerd Hoffmann --- drivers/mmc/host/bcm2835-sdhost.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/drivers/mmc/host/bcm2835-sdhost.c b/drivers/mmc/host/bcm2835-sdhost.c index cafe6ad..8a05c02 100644 --- a/drivers/mmc/host/bcm2835-sdhost.c +++ b/drivers/mmc/host/bcm2835-sdhost.c @@ -327,7 +327,6 @@ static void bcm2835_sdhost_reset_internal(struct bcm2835_host *host) host->clock = 0; bcm2835_sdhost_write(host, host->hcfg, SDHCFG); bcm2835_sdhost_write(host, host->cdiv, SDCDIV); - mmiowb(); } static void bcm2835_sdhost_reset(struct mmc_host *mmc) @@ -1035,8 +1034,6 @@ static void bcm2835_sdhost_timeout(unsigned long data) tasklet_schedule(&host->finish_tasklet); } } - - mmiowb(); spin_unlock_irqrestore(&host->lock, flags); } @@ -1187,8 +1184,6 @@ static irqreturn_t bcm2835_sdhost_irq(int irq, void *dev_id) result = IRQ_HANDLED; } - mmiowb(); - spin_unlock(&host->lock); return result; @@ -1303,7 +1298,6 @@ static void bcm2835_sdhost_request(struct mmc_host *mmc, bcm2835_sdhost_dumpregs(host); mrq->cmd->error = -EILSEQ; tasklet_schedule(&host->finish_tasklet); - mmiowb(); spin_unlock_irqrestore(&host->lock, flags); return; } @@ -1324,8 +1318,6 @@ static void bcm2835_sdhost_request(struct mmc_host *mmc, bcm2835_sdhost_finish_command(host, &flags); } - mmiowb(); - spin_unlock_irqrestore(&host->lock, flags); } @@ -1353,8 +1345,6 @@ static void bcm2835_sdhost_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) bcm2835_sdhost_write(host, host->hcfg, SDHCFG); - mmiowb(); - spin_unlock_irqrestore(&host->lock, flags); } @@ -1383,8 +1373,6 @@ static void bcm2835_sdhost_cmd_wait_work(struct work_struct *work) bcm2835_sdhost_finish_command(host, &flags); - mmiowb(); - spin_unlock_irqrestore(&host->lock, flags); } @@ -1415,8 +1403,6 @@ static void bcm2835_sdhost_tasklet_finish(unsigned long param) host->cmd = NULL; host->data = NULL; - mmiowb(); - host->dma_desc = NULL; terminate_chan = host->dma_chan; host->dma_chan = NULL; @@ -1515,7 +1501,6 @@ int bcm2835_sdhost_add_host(struct bcm2835_host *host) goto untasklet; } - mmiowb(); mmc_add_host(mmc); pio_limit_string[0] = '\0';