From patchwork Tue Jul 26 14:51:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9248307 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6CCD56077C for ; Tue, 26 Jul 2016 14:54:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5EE0626D08 for ; Tue, 26 Jul 2016 14:54:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 534802723E; Tue, 26 Jul 2016 14:54:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EA3A326D08 for ; Tue, 26 Jul 2016 14:54:29 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bS3il-0004Im-MJ; Tue, 26 Jul 2016 14:52:35 +0000 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bS3ii-0004DW-CA; Tue, 26 Jul 2016 14:52:32 +0000 Received: by mail-pf0-x244.google.com with SMTP id g202so117004pfb.1; Tue, 26 Jul 2016 07:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3O1Ls/asaJcTiyvOSj9G8wcIs2JUtZy0pHLFMsDdmV8=; b=FxZqCRLpsmHLRJFT38R23wdci2j5cTapPzmgkGgJ3FXXZqK4MOzk4nlkvQGxQwC2Ge 7tQ+MrMehXNadBcbMScVdIOLhZFNKUf9sPbpDKgiuPFIy80pFxWFcinR5yw9qSqhWacv HExwTyk6mq9TidVV77DkP0ziYU2pHEFZVMaM0mp9VRUJmWpX6S73uX/jX53D74oS6G9n GmZsFNUDoirOTrsQwOiEh9R21xhtNf2U6rCvW7jgsrku9agU90SLZgpo59umofsJ21Ru V8tIPhw+6ZTaZm+2ocYmuaUjwLh1ODBDCdAOOUhe16uETe5JRD8RmLolj6biqxvExqVV 1JvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3O1Ls/asaJcTiyvOSj9G8wcIs2JUtZy0pHLFMsDdmV8=; b=ZgBQDco6Hawj+UTgjvFj6hpFIc+C4Gfe6ho0mdZMJcFLg6biOmmnScFZAdfPwhJntm n2UgFU7J5o8pR3jF3SYgAFzZY4ZL4AJgm755jU8zknwfWcp9dI6x38Xv+cCK0q2N2DxI rWN+hn1xNCubf49mcauDITdf6U6iF27oTzlFjMmDE0Afmyju+0PnxxMX3xTSWNwCL+en N631VaSpW9PLHn6pEEmm/puHr/MGFBjrPMW2+P1CcVIqP9ch/FzSBdCRT2a0cSUTzl+J uLRR/rEDg0M+5KteyybZpHahuut34fGutcG8a1LUmrt6ONc+XcCns9l/han48AzcQ6QG JVAg== X-Gm-Message-State: AEkoouvnHi8OVnf4ze1WUOD4Dg2fXQETTULPvYM/1fBG7MLkpkeXb2YwYru6pKApRjlxwg== X-Received: by 10.98.12.200 with SMTP id 69mr40075072pfm.15.1469544731473; Tue, 26 Jul 2016 07:52:11 -0700 (PDT) Received: from localhost.localdomain.localdomain (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id x5sm2153483pax.33.2016.07.26.07.52.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Jul 2016 07:52:10 -0700 (PDT) From: Wei Yongjun To: Linus Walleij , Carlo Caione , Kevin Hilman Subject: [PATCH] pinctrl: meson: Drop pinctrl_unregister for devm_ registered device Date: Tue, 26 Jul 2016 14:51:58 +0000 Message-Id: <1469544718-32001-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160726_075232_466580_B64BA318 X-CRM114-Status: GOOD ( 11.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, Wei Yongjun , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP It's not necessary to unregister pin controller device registered with devm_pinctrl_register() and using pinctrl_unregister() leads to a double free. This is detected by Coccinelle semantic patch. Signed-off-by: Wei Yongjun Reviewed-by: Dmitry Torokhov Acked-by: Kevin Hilman --- drivers/pinctrl/meson/pinctrl-meson.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c index 11623c6..44e69c9 100644 --- a/drivers/pinctrl/meson/pinctrl-meson.c +++ b/drivers/pinctrl/meson/pinctrl-meson.c @@ -727,13 +727,7 @@ static int meson_pinctrl_probe(struct platform_device *pdev) return PTR_ERR(pc->pcdev); } - ret = meson_gpiolib_register(pc); - if (ret) { - pinctrl_unregister(pc->pcdev); - return ret; - } - - return 0; + return meson_gpiolib_register(pc); } static struct platform_driver meson_pinctrl_driver = {