From patchwork Mon Aug 8 23:48:20 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuah Khan X-Patchwork-Id: 9269995 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B2CF2607D6 for ; Mon, 8 Aug 2016 23:50:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A37F22766D for ; Mon, 8 Aug 2016 23:50:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9846827FE4; Mon, 8 Aug 2016 23:50:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 39D1E2766D for ; Mon, 8 Aug 2016 23:50:10 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bWuHs-0001KC-BQ; Mon, 08 Aug 2016 23:48:52 +0000 Received: from resqmta-po-07v.sys.comcast.net ([2001:558:fe16:19:96:114:154:166]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bWuHn-0001Ay-MW for linux-arm-kernel@lists.infradead.org; Mon, 08 Aug 2016 23:48:48 +0000 Received: from resomta-po-05v.sys.comcast.net ([96.114.154.229]) by resqmta-po-07v.sys.comcast.net with SMTP id WuGtbG8sDqbrLWuHQbGtmQ; Mon, 08 Aug 2016 23:48:24 +0000 Received: from mail.gonehiking.org ([73.181.52.62]) by comcast with SMTP id WuHObnRk2C5sCWuHObZHX6; Mon, 08 Aug 2016 23:48:24 +0000 Received: from shuah-XPS-13-9350.sisa.samsung.com (shuah-xps.internal [192.168.1.87]) by mail.gonehiking.org (Postfix) with ESMTP id B11729F302; Mon, 8 Aug 2016 17:48:21 -0600 (MDT) From: Shuah Khan To: inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, airlied@linux.ie, kgene@kernel.org, k.kozlowski@samsung.com Subject: [PATCH v2] exynos-drm: Fix unsupported GEM memory type error message to be clear Date: Mon, 8 Aug 2016 17:48:20 -0600 Message-Id: <1470700100-13306-1-git-send-email-shuahkh@osg.samsung.com> X-Mailer: git-send-email 2.7.4 X-CMAE-Envelope: MS4wfIX+nQdjTD2ed9PPOxF6EpIttcCSvAXkmO3YHqycudxkX/dDn0hGjjk9nqBQKmlOw9ircCwRPKesy4h65LpxCJX0d7o2FiQnMTYYd4Tp5U1/6jhdvcZ6 CaIYmmHmONa4SiYbLYbmMKHiCzw52DNNTAjD4QMAeM0H1nbkPOjxQF5MD2ziZEA5ZMzTwO3AI6M0R/IxU0fd7X92RrSas7bSeerqM9z3KdD2KkTiwHgKD1q5 hpAslgK0xj5jrVgHhajcUccXJu6zkLrlHFhF8XovC3nzXNqoFZBP2bvX/7LJr5zghfdL1LfJLFMfD87BZoNYIa7ui3bl6RG6rR27diqXhXmnYdX90zijma7C fw573uVuML0aKslW8HTrPxfJM6MwXeQY6Xhz9XElrN4t5BYK6seGWxK09r3NbO2oh3BgovnvWsWJIZ9PEf85hOKI1CJIiDJ1Yn7HPPW2h3GfiZX1APf5jR8V kIq0SrehbTgjDF2xzcXq/AcAho2ME5s6lQLh7Giv6uL9sV5hj++m2H2SlhBMinqFEMWnStEGghXCCcsvQo2xYblepgRQe7jvomvzOYcBC8hvtrHpzoAWz2GD uLaLlFjC0Z0o0BxUMhRghk4l X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160808_164847_860603_21ABFBE7 X-CRM114-Status: UNSURE ( 8.12 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Shuah Khan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Fix unsupported GEM memory type error message to include the memory type information. Signed-off-by: Shuah Khan Reviewed-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- Changes since v1: -- Comment changed to read clearly drivers/gpu/drm/exynos/exynos_drm_fb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c index e016640..40ce841 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c @@ -55,11 +55,11 @@ static int check_fb_gem_memory_type(struct drm_device *drm_dev, flags = exynos_gem->flags; /* - * without iommu support, not support physically non-continuous memory - * for framebuffer. + * Physically non-contiguous memory type for framebuffer is not + * supported without IOMMU. */ if (IS_NONCONTIG_BUFFER(flags)) { - DRM_ERROR("cannot use this gem memory type for fb.\n"); + DRM_ERROR("Non-contiguous GEM memory is not supported.\n"); return -EINVAL; }