From patchwork Sun Aug 21 22:46:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9292755 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A5C5F607F0 for ; Sun, 21 Aug 2016 22:48:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 807BC2877B for ; Sun, 21 Aug 2016 22:48:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7292A288E4; Sun, 21 Aug 2016 22:48:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0AFBE2877B for ; Sun, 21 Aug 2016 22:48:54 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bbbWH-0002vi-Ki; Sun, 21 Aug 2016 22:47:09 +0000 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bbbWB-0002uj-K8 for linux-arm-kernel@lists.infradead.org; Sun, 21 Aug 2016 22:47:04 +0000 Received: by mail-pf0-x243.google.com with SMTP id h186so5113917pfg.2 for ; Sun, 21 Aug 2016 15:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hcxiEUCRUFnEG+cWebN9QWSQt90a2fQWrgGxyFAGim8=; b=CW6KVI+g0bsXLN7sdkymt1RIeO/aOlC980E8nfjei0oPloK5B4kn6JMrc4SLvow6P3 DHIg2Wq9UkHtfB7ofxLkivN6n0oD+gpik93g3ssXMQTlanTWnUJebu7E9UqP0aQtiMjd FeS7gygYaTSFbvI14pnvzAfSs+/7eJwaT10ViMKdkXR8zvleb6zNGU+4ULJqApSMUx4k umgf+hMTqOGr8A+CqlDSJsO8vy0vcBRKAc7gman9R6hoCC8fWTlvyYXhuKHLs8UUoASM fmEsjU3PhfgYXzxzraovx5/G2Coo4xrcs1qSt0/IbdqtzJINY6e5Hwlxu3/rGqh2f8ah fwcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hcxiEUCRUFnEG+cWebN9QWSQt90a2fQWrgGxyFAGim8=; b=lcn2G7xmdC6Tba6Hnr3y8fghsmNJdG8ktQH2RZ1G3CXX0ki6T4CE+GcV0n4FS4sHBk IrMrdOoI/2i+kHBsqGaFLYGUaAipvX2z8aPWDPRJ/ygc7FlSjiGUWfUN0O1W+D2PGI4b UCwxTuFu0fkfX8hFyODZAhTXvfb2m0ZUqW9jEMUkbKEDMIvirNNaAFWIUsZTZxu7kh7l DPDHT7QDGGPUI8n1iu1z6ChUNrBQk+WXdvFW9L7k5S2ZSekiDU1F8Dr2k6oNdBNbo1Eu QnxQPBloNQKTm08HFOG0mvU1gz0Ku6XI+NErnC0dN6ingdxqGl/pMWwJQdyJb/2eyk4z o1jA== X-Gm-Message-State: AEkoouvC+4nPLpvSnaUnq8DrDPyShVlhF1TnpeSEgUoAmVzuMxaNqCBYnjTaxb+rYE4SJA== X-Received: by 10.98.77.70 with SMTP id a67mr36738345pfb.151.1471819601160; Sun, 21 Aug 2016 15:46:41 -0700 (PDT) Received: from localhost.localdomain.localdomain (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id g27sm22226206pfd.47.2016.08.21.15.46.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Aug 2016 15:46:40 -0700 (PDT) From: Wei Yongjun To: f.fainelli@gmail.com, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, Andrew Lunn , David Miller Subject: [PATCH -next v2] net: phy: Add missing of_node_put() in xgmiitorgmii_probe() Date: Sun, 21 Aug 2016 22:46:15 +0000 Message-Id: <1471819575-13389-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1471706815-27723-1-git-send-email-weiyj.lk@gmail.com> References: <1471706815-27723-1-git-send-email-weiyj.lk@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160821_154703_767245_F09011AE X-CRM114-Status: UNSURE ( 8.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Wei Yongjun , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This node pointer is returned by of_parse_phandle() with refcount incremented in this function. of_node_put() on it before exitting this function. This is detected by Coccinelle semantic patch. Signed-off-by: Wei Yongjun Reviewed-by: Kedareswara rao Appana --- v1 -> v2: release it unconditionally as Andrew and David's suggestion --- drivers/net/phy/xilinx_gmii2rgmii.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c index cad6e19..73b50f3 100644 --- a/drivers/net/phy/xilinx_gmii2rgmii.c +++ b/drivers/net/phy/xilinx_gmii2rgmii.c @@ -73,6 +73,7 @@ int xgmiitorgmii_probe(struct mdio_device *mdiodev) } priv->phy_dev = of_phy_find_device(phy_node); + of_node_put(phy_node); if (!priv->phy_dev) { dev_info(dev, "Couldn't find phydev\n"); return -EPROBE_DEFER;