From patchwork Fri Aug 26 14:25:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9301383 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 031BF601C0 for ; Fri, 26 Aug 2016 14:27:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E8D3828F0F for ; Fri, 26 Aug 2016 14:27:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DDA09295B8; Fri, 26 Aug 2016 14:27:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 77A1728F0F for ; Fri, 26 Aug 2016 14:27:51 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bdI5P-0001ke-LW; Fri, 26 Aug 2016 14:26:23 +0000 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bdI5E-0001VG-Nx for linux-arm-kernel@lists.infradead.org; Fri, 26 Aug 2016 14:26:16 +0000 Received: by mail-pf0-x243.google.com with SMTP id i6so4998277pfe.0 for ; Fri, 26 Aug 2016 07:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=W8MNZgUYeQBtUYzb0v43/IF0sgCbdHg+UtQpnlMxpN4=; b=VlYpYMOolXcQzvJ6X0NUIuRyU/IuRzin0MAZjoWuoZXwyvOBCXg+J3ArJE/LNcEmN5 wUb1twaHN3rLZIlTpsUbatH+U+fFQvOoe7VzTi2gc0P861LvxrBRTFOUC1XBoKXf8jYO G7vm8Dlz79ZE8p0o9+sj46k9E707Lc9CAz+OeeNTTDImbQomAGZKUYi9hCw+7pKrrffu IDo99+VWVCefNqE9htTR0sMptw23cCN9fqiCpyA6DfzNS2R2teNyC4qlClAsDmvvXrAl EHn/O6HbKKvdFpKc0fKBcYc5DTqK2Irq0rwEJuBt0ja081kwm1PpidymAXEFVAQsTj4u ZW1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=W8MNZgUYeQBtUYzb0v43/IF0sgCbdHg+UtQpnlMxpN4=; b=cd8aqremyAA2kTTSz4F2ieRoh4Mau4/xH3czNykqWsT3gq2f0fz2LQnCx2WGKj2CZ3 MF+m8MVEWnkhlMCpcc6DIHpI3NHRLB0zTh4BPGjVV63KjtoDwajLTeWRNqD0E/J2W9YT fOb7FC1cLSQttxZvZ660DaLZMyRSNhwB+vZfqte/FKsHgdVuALzLb20Q5ZXDo7zUa8EJ bM9fGG18x5m2uNpEqhOe6sbOwCcp5aghkj30Whlft9QLmyDnGeBf0a+7cSYAwREiTbdB 9knBOEj1ORqIbmE2+YQ/Fuz+K41v2/SXhrZ+l2BavsTaDasx1Zx5OthtipGaDljVxlAE ycCA== X-Gm-Message-State: AE9vXwPMNVGQMu5zia4NiCy2046N3IbTqxDnbzsFTgy5BawljUnUiBdwx3iQDFUIx2W+0A== X-Received: by 10.98.14.72 with SMTP id w69mr6398760pfi.119.1472221551160; Fri, 26 Aug 2016 07:25:51 -0700 (PDT) Received: from localhost.localdomain.localdomain (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id o80sm29282871pfa.67.2016.08.26.07.25.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Aug 2016 07:25:50 -0700 (PDT) From: Wei Yongjun To: Maxime Ripard , David Airlie , Chen-Yu Tsai Subject: [PATCH -next] drm/sun4i: Remove redundant dev_err call in sun4i_tcon_init_regmap() Date: Fri, 26 Aug 2016 14:25:25 +0000 Message-Id: <1472221525-27706-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160826_072612_959127_C5007321 X-CRM114-Status: UNSURE ( 9.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wei Yongjun , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index 2145ecf..9180e7e 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c @@ -374,10 +374,8 @@ static int sun4i_tcon_init_regmap(struct device *dev, res = platform_get_resource(pdev, IORESOURCE_MEM, 0); regs = devm_ioremap_resource(dev, res); - if (IS_ERR(regs)) { - dev_err(dev, "Couldn't map the TCON registers\n"); + if (IS_ERR(regs)) return PTR_ERR(regs); - } tcon->regs = devm_regmap_init_mmio(dev, regs, &sun4i_tcon_regmap_config);