From patchwork Sat Aug 27 16:19:49 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 9302459 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DB76A6077C for ; Sat, 27 Aug 2016 16:23:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C34E028119 for ; Sat, 27 Aug 2016 16:23:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A77D2289F1; Sat, 27 Aug 2016 16:23:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F1207289CA for ; Sat, 27 Aug 2016 16:23:09 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bdgLw-0002iX-5W; Sat, 27 Aug 2016 16:21:04 +0000 Received: from mout.kundenserver.de ([212.227.17.10]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bdgLr-0002gO-K3 for linux-arm-kernel@lists.infradead.org; Sat, 27 Aug 2016 16:21:00 +0000 Received: from localhost.localdomain ([95.91.36.119]) by mrelayeu.kundenserver.de (mreue103) with ESMTPSA (Nemesis) id 0MGXWy-1bqpVN2Rea-00DHTA; Sat, 27 Aug 2016 18:20:21 +0200 From: Stefan Wahren To: Mark Rutland , Will Deacon Subject: [PATCH 1/2] drivers/perf: arm_pmu: Fix leak in error path Date: Sat, 27 Aug 2016 16:19:49 +0000 Message-Id: <1472314790-4268-1-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 1.7.9.5 X-Provags-ID: V03:K0:VkXl8ZtN7R3qwfB56ofb9AQg7KFePF6HjADcp9V39dyJxsxUPq5 wHfPcwqKcwg/IYkecKkFBmLEFBQHqRJsy7moJMMKdA34VjVJcGV/tdshbzOOq2XrU/w59ZG sTfg5BvClStjuUc+yaQ88KsGkwBsGKyO+Boeg3sj8dZEtRN22NeoMQEkFWnEvhkwnDeMrFl wbPLNmPFdMw5Ji/1D88cw== X-UI-Out-Filterresults: notjunk:1; V01:K0:HHwDyYzeFmA=:4sYOjiCjI3DcfEf7xbBsvu 5qizGGjQzOUKpGomp2o9OisERpGET/8RIDCj3Upp8JZTjvKesbjbfWEArPGVKZcE4VKXSpvWm x8se8soPHeOq65DJD08ZleNkH3AHniZ4Syhzjz5AxWXdgG6noAxLWA7zBjf8hsso08h/qAv9d 25iDYqGLeYJXR0kMDNo9QbDxrrnOpDImwLS6pBBhT+/EvugB5SIA8nC7gwk9RjjHYdkCOX0gQ CHKkzHbI1vEmKvREnTM59xja5yqO0GomWxQ8xy71lq8aaCB3mMB478BYg78ZE633KM05RgG7w rTrJ+fXqCFHnpvVRk3VT5zOB92oANjEp16MubD+Iuc1WpOgsETzONZSu5C4mmFmuTI2u6z5U0 NfFoUR3zYLQAL9yo5euxGtZNl1MDsiQve4sXUxXmRk8IY2H6zlr2vyYjZIldmdWQvnHUefJNo XsaAlUhemcPOl3+bxDeaQvd0Qp3Ij+0xKrPHJ809Y9/+4QCAbLWQZb5G5Rr3eScyLuWG8hTjD /a08i2iB/fCWKuseRz/TqS5HNQqoB5b/56hvn4K2661AXcI+ZWdlldRPmnFjj9WfzDOFyUKOq uivjbGmz79x5PLGAfNI8gC3z5zs8nVKnIMgO1vnx2Ynb04BOpyIbmNz7xT4fNvTL4iS5Iw67t MkSxP+N92S/Fop2L08sd904CnbnQRPZqzU+KWWa9uQTHWmCLm5pHNqp2NszLD0YtXV8g= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160827_092100_052191_629ADD69 X-CRM114-Status: UNSURE ( 8.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , Eric Anholt , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP In case of a IRQ type mismatch in of_pmu_irq_cfg() the device node for interrupt affinity isn't freed. So fix this issue by calling of_node_put(). Signed-off-by: Stefan Wahren Fixes: fa8ad7889d83 ("arm: perf: factor arm_pmu core out to drivers") --- drivers/perf/arm_pmu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c index c494613..1b48bf0 100644 --- a/drivers/perf/arm_pmu.c +++ b/drivers/perf/arm_pmu.c @@ -925,6 +925,7 @@ static int of_pmu_irq_cfg(struct arm_pmu *pmu) if (i > 0 && spi != using_spi) { pr_err("PPI/SPI IRQ type mismatch for %s!\n", dn->name); + of_node_put(dn); kfree(irqs); return -EINVAL; }