| Message ID | 1472722201-31872-4-git-send-email-wenyou.yang@atmel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 01 Sep 2016, Wenyou Yang wrote: > Since the act8945a-charger is regarded as a sub-device and it using > "interrupts" property, update the examples section. > > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> > --- > > Changes in v9: None > Changes in v8: None > Changes in v7: None > Changes in v6: None > Changes in v4: None > > Documentation/devicetree/bindings/mfd/act8945a.txt | 22 +++++++++++++++------- > 1 file changed, 15 insertions(+), 7 deletions(-) This is a functional change. I'll require a DT Ack. > diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt b/Documentation/devicetree/bindings/mfd/act8945a.txt > index f712830..462819a 100644 > --- a/Documentation/devicetree/bindings/mfd/act8945a.txt > +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt > @@ -14,13 +14,6 @@ Example: > reg = <0x5b>; > status = "okay"; > > - pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_charger_chglev>; > - active-semi,chglev-gpio = <&pioA 12 GPIO_ACTIVE_HIGH>; > - active-semi,input-voltage-threshold-microvolt = <6600>; > - active-semi,precondition-timeout = <40>; > - active-semi,total-timeout = <3>; > - > active-semi,vsel-high; > > regulators { > @@ -73,4 +66,19 @@ Example: > regulator-always-on; > }; > }; > + > + charger { > + compatible = "active-semi,act8945a-charger"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>; > + interrupt-parent = <&pioA>; > + interrupts = <45 GPIO_ACTIVE_LOW>; > + > + active-semi,chglev-gpios = <&pioA 12 GPIO_ACTIVE_HIGH>; > + active-semi,lbo-gpios = <&pioA 72 GPIO_ACTIVE_LOW>; > + active-semi,input-voltage-threshold-microvolt = <6600>; > + active-semi,precondition-timeout = <40>; > + active-semi,total-timeout = <3>; > + status = "okay"; > + }; > };
Hi Lee, On Thu, Sep 01, 2016 at 12:22:51PM +0100, Lee Jones wrote: > On Thu, 01 Sep 2016, Wenyou Yang wrote: > > > Since the act8945a-charger is regarded as a sub-device and it using > > "interrupts" property, update the examples section. > > > > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> > > --- > > > > Changes in v9: None > > Changes in v8: None > > Changes in v7: None > > Changes in v6: None > > Changes in v4: None > > > > Documentation/devicetree/bindings/mfd/act8945a.txt | 22 +++++++++++++++------- > > 1 file changed, 15 insertions(+), 7 deletions(-) > > This is a functional change. I'll require a DT Ack. Wenyou Yang forgot to take over Rob's Acked-By from the previous version: https://patchwork.kernel.org/patch/9298871/ -- Sebastian
> -----Original Message----- > From: Sebastian Reichel [mailto:sre@kernel.org] > Sent: 2016年9月1日 20:48 > To: Lee Jones <lee.jones@linaro.org> > Cc: Wenyou Yang - A41535 <Wenyou.Yang@microchip.com>; Dmitry Eremin- > Solenikov <dbaryshkov@gmail.com>; David Woodhouse > <dwmw2@infradead.org>; Rob Herring <robh+dt@kernel.org>; Pawel Moll > <pawel.moll@arm.com>; Mark Rutland <mark.rutland@arm.com>; Ian Campbell > <ijc+devicetree@hellion.org.uk>; Kumar Gala <galak@codeaurora.org>; Nicolas > Ferre <nicolas.ferre@atmel.com>; Alexandre Belloni <alexandre.belloni@free- > electrons.com>; linux-kernel@vger.kernel.org; Wenyou Yang - A41535 > <Wenyou.Yang@microchip.com>; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-pm@vger.kernel.org > Subject: Re: [PATCH v9 3/4] doc: bindings: mfd: act8945a: Update the example > > Hi Lee, > > On Thu, Sep 01, 2016 at 12:22:51PM +0100, Lee Jones wrote: > > On Thu, 01 Sep 2016, Wenyou Yang wrote: > > > > > Since the act8945a-charger is regarded as a sub-device and it using > > > "interrupts" property, update the examples section. > > > > > > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> > > > --- > > > > > > Changes in v9: None > > > Changes in v8: None > > > Changes in v7: None > > > Changes in v6: None > > > Changes in v4: None > > > > > > Documentation/devicetree/bindings/mfd/act8945a.txt | 22 > > > +++++++++++++++------- > > > 1 file changed, 15 insertions(+), 7 deletions(-) > > > > This is a functional change. I'll require a DT Ack. > > Wenyou Yang forgot to take over Rob's Acked-By from the previous > version: https://patchwork.kernel.org/patch/9298871/ Yes, sorry. I forgot. Best Regards, Wenyou Yang
On Thu, 01 Sep 2016, Wenyou.Yang@microchip.com wrote: > > > > -----Original Message----- > > From: Sebastian Reichel [mailto:sre@kernel.org] > > Sent: 2016年9月1日 20:48 > > To: Lee Jones <lee.jones@linaro.org> > > Cc: Wenyou Yang - A41535 <Wenyou.Yang@microchip.com>; Dmitry Eremin- > > Solenikov <dbaryshkov@gmail.com>; David Woodhouse > > <dwmw2@infradead.org>; Rob Herring <robh+dt@kernel.org>; Pawel Moll > > <pawel.moll@arm.com>; Mark Rutland <mark.rutland@arm.com>; Ian Campbell > > <ijc+devicetree@hellion.org.uk>; Kumar Gala <galak@codeaurora.org>; Nicolas > > Ferre <nicolas.ferre@atmel.com>; Alexandre Belloni <alexandre.belloni@free- > > electrons.com>; linux-kernel@vger.kernel.org; Wenyou Yang - A41535 > > <Wenyou.Yang@microchip.com>; devicetree@vger.kernel.org; linux-arm- > > kernel@lists.infradead.org; linux-pm@vger.kernel.org > > Subject: Re: [PATCH v9 3/4] doc: bindings: mfd: act8945a: Update the example > > > > Hi Lee, > > > > On Thu, Sep 01, 2016 at 12:22:51PM +0100, Lee Jones wrote: > > > On Thu, 01 Sep 2016, Wenyou Yang wrote: > > > > > > > Since the act8945a-charger is regarded as a sub-device and it using > > > > "interrupts" property, update the examples section. > > > > > > > > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> > > > > --- > > > > > > > > Changes in v9: None > > > > Changes in v8: None > > > > Changes in v7: None > > > > Changes in v6: None > > > > Changes in v4: None > > > > > > > > Documentation/devicetree/bindings/mfd/act8945a.txt | 22 > > > > +++++++++++++++------- > > > > 1 file changed, 15 insertions(+), 7 deletions(-) > > > > > > This is a functional change. I'll require a DT Ack. > > > > Wenyou Yang forgot to take over Rob's Acked-By from the previous > > version: https://patchwork.kernel.org/patch/9298871/ > > Yes, sorry. I forgot. Very well. Applied, thanks.
diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt b/Documentation/devicetree/bindings/mfd/act8945a.txt index f712830..462819a 100644 --- a/Documentation/devicetree/bindings/mfd/act8945a.txt +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt @@ -14,13 +14,6 @@ Example: reg = <0x5b>; status = "okay"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_charger_chglev>; - active-semi,chglev-gpio = <&pioA 12 GPIO_ACTIVE_HIGH>; - active-semi,input-voltage-threshold-microvolt = <6600>; - active-semi,precondition-timeout = <40>; - active-semi,total-timeout = <3>; - active-semi,vsel-high; regulators { @@ -73,4 +66,19 @@ Example: regulator-always-on; }; }; + + charger { + compatible = "active-semi,act8945a-charger"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>; + interrupt-parent = <&pioA>; + interrupts = <45 GPIO_ACTIVE_LOW>; + + active-semi,chglev-gpios = <&pioA 12 GPIO_ACTIVE_HIGH>; + active-semi,lbo-gpios = <&pioA 72 GPIO_ACTIVE_LOW>; + active-semi,input-voltage-threshold-microvolt = <6600>; + active-semi,precondition-timeout = <40>; + active-semi,total-timeout = <3>; + status = "okay"; + }; };
Since the act8945a-charger is regarded as a sub-device and it using "interrupts" property, update the examples section. Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> --- Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: None Changes in v4: None Documentation/devicetree/bindings/mfd/act8945a.txt | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-)