diff mbox

[1/2] arm64: dts: marvell: remove msi-parent from PCIe on Armada 3700

Message ID 1472744484-19132-2-git-send-email-thomas.petazzoni@free-electrons.com (mailing list archive)
State New, archived
Headers show

Commit Message

Thomas Petazzoni Sept. 1, 2016, 3:41 p.m. UTC
Following the switch of the Aardvark PCIe controller driver to the
generic MSI support, the msi-parent property in the PCIe controller,
pointing to itself is no longer needed: since the MSI irq domain is
associated to the PCIe controller Device Tree node, this is sufficient
for the interrupt resolution logic to work.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
Please only apply once "pci: pci-aardvark: move to MSI handling using
generic MSI support" is merged, or it will break MSI support on Armada
3700.
---
 arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Gregory CLEMENT Feb. 15, 2017, 2:12 p.m. UTC | #1
Hi Thomas,
 
 On jeu., sept. 01 2016, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> Following the switch of the Aardvark PCIe controller driver to the
> generic MSI support, the msi-parent property in the PCIe controller,
> pointing to itself is no longer needed: since the MSI irq domain is
> associated to the PCIe controller Device Tree node, this is sufficient
> for the interrupt resolution logic to work.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> Please only apply once "pci: pci-aardvark: move to MSI handling using
> generic MSI support" is merged, or it will break MSI support on Armada
> 3700.

What is the status of this patch?
Can I remove it from my mailbox?

it seemed that "pci: pci-aardvark: move to MSI handling using generic
MSI support" was never merged.

Thanks,

Gregory

> ---
>  arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> index c476253..e56a34a 100644
> --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> @@ -187,7 +187,6 @@
>  			bus-range = <0x00 0xff>;
>  			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
>  			#interrupt-cells = <1>;
> -			msi-parent = <&pcie0>;
>  			msi-controller;
>  			ranges = <0x82000000 0 0xe8000000   0 0xe8000000 0 0x1000000 /* Port 0 MEM */
>  				  0x81000000 0 0xe9000000   0 0xe9000000 0 0x10000>; /* Port 0 IO*/
> -- 
> 2.7.4
>
Thomas Petazzoni Feb. 15, 2017, 2:21 p.m. UTC | #2
Hello,

On Wed, 15 Feb 2017 15:12:44 +0100, Gregory CLEMENT wrote:

> What is the status of this patch?
> Can I remove it from my mailbox?

Yes, remove it from your inbox, I'll resend once the patch it depends
on has been merged.

Thanks!

Thomas
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
index c476253..e56a34a 100644
--- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
@@ -187,7 +187,6 @@ 
 			bus-range = <0x00 0xff>;
 			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
 			#interrupt-cells = <1>;
-			msi-parent = <&pcie0>;
 			msi-controller;
 			ranges = <0x82000000 0 0xe8000000   0 0xe8000000 0 0x1000000 /* Port 0 MEM */
 				  0x81000000 0 0xe9000000   0 0xe9000000 0 0x10000>; /* Port 0 IO*/