From patchwork Tue Sep 6 08:03:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 9315915 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4C32360752 for ; Tue, 6 Sep 2016 08:06:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4C9B728824 for ; Tue, 6 Sep 2016 08:06:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 414C82886F; Tue, 6 Sep 2016 08:06:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, HK_RANDOM_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0EC5E28824 for ; Tue, 6 Sep 2016 08:06:30 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bhBN4-0006Ws-MM; Tue, 06 Sep 2016 08:04:42 +0000 Received: from mail-pf0-x235.google.com ([2607:f8b0:400e:c00::235]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bhBMx-0006Uk-F5 for linux-arm-kernel@lists.infradead.org; Tue, 06 Sep 2016 08:04:39 +0000 Received: by mail-pf0-x235.google.com with SMTP id p64so72057190pfb.1 for ; Tue, 06 Sep 2016 01:04:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=MCyCgKLLiI8XGsOmU/HSQT+4BMHM8m50oVxBM7Bg8v0=; b=VAcWSy5lk6DlVoDiT0WRIwJ7yULwES7z7YQ5ipnFkEb7IpoMJUvFTJng9Ia6nH9vqo 0zB2XDYbPuAQU5S1iaHg3DB0l+Tvq8Q1KJOUgHMIpsLk1c1jqwSc7Cy5bsoQFU71Xz46 FEU5h5knqZyfeoYD3xQ7E1811MRonWZboFkag= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=MCyCgKLLiI8XGsOmU/HSQT+4BMHM8m50oVxBM7Bg8v0=; b=Oj7HVkHhoPxRqE2HQkD++S+cHTxL6Uy05ZuqjlkReG+Nlu8qrVQlc//+h4KE0tvRMN tK48K0ulFSSkJ92MewudhuZnx7+F8g7qhSY3QNWQ6kc6l9KG7g5NjSdm1V7NAZie4jqS iedcP72XK6az1XaNdIxa3XLhFFfKDZZdZsTNl8t40WgHXkGUBF4o+LSMWbx3opazoIqI 3CCb1koYYbAigq+EW5ZwE9BPe9EtqO/c/YkBrPWUanSz3tc/83rlHmM9jRSf20NdXLkJ LUEDunLjlApMJwS+64I2rGVDqJg0IGYC41TvS9gQ2eGETPqBfQzroPYeQJCP+o1ZHu/W koRA== X-Gm-Message-State: AE9vXwNQan/ZijIgPFhwc2wFqrWOVVp1PK14+tYwc7QBrQXHfkftCpFo6sU6g19o+rsL9QHI X-Received: by 10.98.17.83 with SMTP id z80mr70827123pfi.38.1473149054335; Tue, 06 Sep 2016 01:04:14 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.17]) by smtp.gmail.com with ESMTPSA id y2sm38671707pan.31.2016.09.06.01.04.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 06 Sep 2016 01:04:13 -0700 (PDT) From: Baoyou Xie To: mathieu.poirier@linaro.org Subject: [PATCH] coresight: tmc: mark symbols static where possible Date: Tue, 6 Sep 2016 16:03:50 +0800 Message-Id: <1473149030-25576-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160906_010435_573333_88C02D0C X-CRM114-Status: GOOD ( 14.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: xie.baoyou@zte.com.cn, baoyou.xie@linaro.org, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP We get a few warnings when building kernel with W=1: drivers/hwtracing/coresight/coresight-tmc-etr.c:23:6: warning: no previous prototype for 'tmc_etr_enable_hw' [-Wmissing-prototypes] drivers/hwtracing/coresight/coresight-tmc-etf.c:25:6: warning: no previous prototype for 'tmc_etb_enable_hw' [-Wmissing-prototypes] ... In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/hwtracing/coresight/coresight-tmc-etf.c | 2 +- drivers/hwtracing/coresight/coresight-tmc-etr.c | 2 +- drivers/hwtracing/coresight/coresight-tmc.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c b/drivers/hwtracing/coresight/coresight-tmc-etf.c index 466af86..a9a525f 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c @@ -22,7 +22,7 @@ #include "coresight-priv.h" #include "coresight-tmc.h" -void tmc_etb_enable_hw(struct tmc_drvdata *drvdata) +static void tmc_etb_enable_hw(struct tmc_drvdata *drvdata) { CS_UNLOCK(drvdata->base); diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c index 688be9e..1ff5451 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c @@ -20,7 +20,7 @@ #include "coresight-priv.h" #include "coresight-tmc.h" -void tmc_etr_enable_hw(struct tmc_drvdata *drvdata) +static void tmc_etr_enable_hw(struct tmc_drvdata *drvdata) { u32 axictl; diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c index 9e02ac9..45947f3 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.c +++ b/drivers/hwtracing/coresight/coresight-tmc.c @@ -249,8 +249,8 @@ static struct attribute *coresight_tmc_mgmt_attrs[] = { NULL, }; -ssize_t trigger_cntr_show(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t trigger_cntr_show(struct device *dev, + struct device_attribute *attr, char *buf) { struct tmc_drvdata *drvdata = dev_get_drvdata(dev->parent); unsigned long val = drvdata->trigger_cntr;