| Message ID | 1473177196-29371-1-git-send-email-fabio.estevam@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Shawn, On Tue, Sep 6, 2016 at 12:53 PM, Fabio Estevam <fabio.estevam@nxp.com> wrote: > The inclusion of skeleton.dtsi causes the following build warning: > > Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name > > Instead of fixing skeleton.dtsi, just add the top level definitions > for address-cells and size-cell and remove its inclusion. > > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> Are you OK with this series?
On Sat, Nov 05, 2016 at 05:35:50PM -0200, Fabio Estevam wrote: > Hi Shawn, > > On Tue, Sep 6, 2016 at 12:53 PM, Fabio Estevam <fabio.estevam@nxp.com> wrote: > > The inclusion of skeleton.dtsi causes the following build warning: > > > > Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name > > > > Instead of fixing skeleton.dtsi, just add the top level definitions > > for address-cells and size-cell and remove its inclusion. > > > > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> > > Are you OK with this series? Has the series cleaned up all i.MX dts files? I do not like to see so many patches doing such small cleanups. Can we do it with 3 patches maybe? - one for skeleton.dtsi cleanup - one for memory node - one for cpu node Each one covers all i.MX dts files. Shawn
diff --git a/arch/arm/boot/dts/imx1.dtsi b/arch/arm/boot/dts/imx1.dtsi index 22f5d1d..b792eee 100644 --- a/arch/arm/boot/dts/imx1.dtsi +++ b/arch/arm/boot/dts/imx1.dtsi @@ -9,7 +9,6 @@ * http://www.gnu.org/copyleft/gpl.html */ -#include "skeleton.dtsi" #include "imx1-pinfunc.h" #include <dt-bindings/clock/imx1-clock.h> @@ -17,6 +16,9 @@ #include <dt-bindings/interrupt-controller/irq.h> / { + #address-cells = <1>; + #size-cells = <1>; + aliases { gpio0 = &gpio1; gpio1 = &gpio2;
The inclusion of skeleton.dtsi causes the following build warning: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name Instead of fixing skeleton.dtsi, just add the top level definitions for address-cells and size-cell and remove its inclusion. Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> --- arch/arm/boot/dts/imx1.dtsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)