From patchwork Sun Sep 18 14:02:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 9337845 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AD0326077F for ; Sun, 18 Sep 2016 14:05:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F3CE32854E for ; Sun, 18 Sep 2016 14:05:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E5072285A5; Sun, 18 Sep 2016 14:05:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 810132854E for ; Sun, 18 Sep 2016 14:05:12 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1blchK-0005Rf-RR; Sun, 18 Sep 2016 14:03:58 +0000 Received: from mail-pf0-x22a.google.com ([2607:f8b0:400e:c00::22a]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1blchE-0005EM-UA for linux-arm-kernel@lists.infradead.org; Sun, 18 Sep 2016 14:03:54 +0000 Received: by mail-pf0-x22a.google.com with SMTP id p64so41991388pfb.1 for ; Sun, 18 Sep 2016 07:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=qGINNA9trQCGMMHZ/ojEHR4RLQgMZui7eBY3PAT7c2U=; b=E2+uOG4+szrmhj6ahjSbyxa+Geo30XHKB7MnHgk/SWHbDBM5PR5tQGXcK2ZY7RzI1W 61O92VNrDwFUatLXIknDN+3ev4hL0JyHxN40M0mACRPITB/4vEboEkrSj+nWp1PsAl6B FkFD/2/PA7lqudHnJgFNnnsl0zMUFAZdTTgSU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=qGINNA9trQCGMMHZ/ojEHR4RLQgMZui7eBY3PAT7c2U=; b=kFOusihYzWtnP8/sX0j/J1Ic4Dhfj+01N7AsiuL2vhFgmWmk3aPjrKSWvwE78eVz7o A4pOeSCCC5auMg/iFJ+qgiH8gYFzlLdsGVUSfqSat1qdLh3rX2V/zctba1lYxQ+3fh+P HGA6WbGtquC/jaQ82WXPYkWjIxVVB/Mt7GIjpGIo3yWX11C/+aSVY2EfkWsuQFSiTKNn tTfG2nnIGdYibaHzrHa6Bse9nhsQUzfJ8mfcDkCOSFalpNcMDuqLSNUZ/Ckk+QIRONE0 Z6ao/xJ4r8rcG0rsZbZjgkjZD3BfoP7ATD3PxGJ1fRHSLv0cKvctwwlv8LaVYm5G6tAX Rn1A== X-Gm-Message-State: AE9vXwNAf+FkUL/RnUm7umZum8jt5dDV9XzP/JANthWef9KSlnXMeK2/RwvIwVqhO3CLvPEz X-Received: by 10.98.159.194 with SMTP id v63mr38969483pfk.91.1474207409730; Sun, 18 Sep 2016 07:03:29 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.172]) by smtp.gmail.com with ESMTPSA id e71sm38963793pfc.75.2016.09.18.07.03.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 18 Sep 2016 07:03:29 -0700 (PDT) From: Baoyou Xie To: ck.hu@mediatek.com, p.zabel@pengutronix.de, airlied@linux.ie, matthias.bgg@gmail.com Subject: [PATCH] drm/mediatek: mark symbols static where possible Date: Sun, 18 Sep 2016 22:02:15 +0800 Message-Id: <1474207335-21966-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160918_070353_110127_00BB2AEF X-CRM114-Status: GOOD ( 10.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arnd@arndb.de, xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, baoyou.xie@linaro.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP We get 4 warnings when building kernel with W=1: drivers/gpu/drm/mediatek/mtk_hdmi.c:1089:6: warning: no previous prototype for 'mtk_hdmi_audio_enable' [-Wmissing-prototypes] drivers/gpu/drm/mediatek/mtk_hdmi.c:1095:6: warning: no previous prototype for 'mtk_hdmi_audio_disable' [-Wmissing-prototypes] drivers/gpu/drm/mediatek/mtk_hdmi.c:1101:5: warning: no previous prototype for 'mtk_hdmi_audio_set_param' [-Wmissing-prototypes] drivers/gpu/drm/mediatek/mtk_hdmi.c:1627:5: warning: no previous prototype for 'mtk_hdmi_audio_digital_mute' [-Wmissing-prototypes] In fact, both functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks both functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index 334562d..be4e19c 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c @@ -1086,19 +1086,19 @@ static int mtk_hdmi_output_init(struct mtk_hdmi *hdmi) return 0; } -void mtk_hdmi_audio_enable(struct mtk_hdmi *hdmi) +static void mtk_hdmi_audio_enable(struct mtk_hdmi *hdmi) { mtk_hdmi_aud_enable_packet(hdmi, true); hdmi->audio_enable = true; } -void mtk_hdmi_audio_disable(struct mtk_hdmi *hdmi) +static void mtk_hdmi_audio_disable(struct mtk_hdmi *hdmi) { mtk_hdmi_aud_enable_packet(hdmi, false); hdmi->audio_enable = false; } -int mtk_hdmi_audio_set_param(struct mtk_hdmi *hdmi, +static int mtk_hdmi_audio_set_param(struct mtk_hdmi *hdmi, struct hdmi_audio_param *param) { if (!hdmi->audio_enable) { @@ -1624,7 +1624,8 @@ static void mtk_hdmi_audio_shutdown(struct device *dev, void *data) mtk_hdmi_audio_disable(hdmi); } -int mtk_hdmi_audio_digital_mute(struct device *dev, void *data, bool enable) +static int +mtk_hdmi_audio_digital_mute(struct device *dev, void *data, bool enable) { struct mtk_hdmi *hdmi = dev_get_drvdata(dev);