From patchwork Sat Sep 24 05:36:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 9349101 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6E312601C2 for ; Sat, 24 Sep 2016 05:39:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5333029FA7 for ; Sat, 24 Sep 2016 05:39:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 43D3729FB9; Sat, 24 Sep 2016 05:39:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, HK_RANDOM_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C21C129FA7 for ; Sat, 24 Sep 2016 05:39:38 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bnfeX-0008AM-AH; Sat, 24 Sep 2016 05:37:33 +0000 Received: from mail-pa0-x22f.google.com ([2607:f8b0:400e:c03::22f]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bnfeQ-0007j6-Kn for linux-arm-kernel@lists.infradead.org; Sat, 24 Sep 2016 05:37:28 +0000 Received: by mail-pa0-x22f.google.com with SMTP id qn7so28830100pac.3 for ; Fri, 23 Sep 2016 22:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=u77sED1EkgbHENUBRgtLGg5EjalTCbfEUHY7CfIwTmY=; b=RGjnmYwHQX6yj0PPeOoNEk44KsAkk3+kces2TQUQyET3B9Q0n/lGEL16Sts+eC9AHK LnMjWqeo9ro5iHY8PnW/+pydeJdmfWYSezRKhwxmmaCJflPN2woQBIpgPKFYYO3FtOxE ug8tKRsxsKV2q0N8O0LJEiUiSsoiINPm1qOpE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=u77sED1EkgbHENUBRgtLGg5EjalTCbfEUHY7CfIwTmY=; b=fh4tjnguD02C57uOGKrMQhDouSawyoitllOR+lPCXBoUlcpEXpY+t6rXYvfzANqjr8 Gbmr/aQ5rDD/SJcgLfa1tbldVx75BNws4VegDGDQTpbjbM6unK4PYKXJjor/1QBr6K9V 59GNqyo5j1hBYQN5qe0Y8n5+H2ZVWSj7KA9HOsgzfRZ/SlLUclKFWxzRRNI1ZCwDtTfb dHzYAa1V68ZNFMXV5th7yeQnXqn6gtOwP8aV6sN18Z1ztsldeGMaUzBfvItoa2jvqOjh S9SG8QjjUmmW+D4nI+TrUnBA0V6r80JHybFHIU0T6hecgONkSfZs0ZuMYTUt3vzBIt83 E0cg== X-Gm-Message-State: AE9vXwMPYlb7B1d+ZIl4ePfnqqgz8oN3ylgrSIhkjCJsjGbJzHhl6W1QMprOBY0LsTv8HtFd X-Received: by 10.66.48.8 with SMTP id h8mr18835135pan.92.1474695425427; Fri, 23 Sep 2016 22:37:05 -0700 (PDT) Received: from localhost.localdomain ([45.56.152.27]) by smtp.gmail.com with ESMTPSA id m82sm15165404pfk.64.2016.09.23.22.37.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 23 Sep 2016 22:37:04 -0700 (PDT) From: Baoyou Xie To: linus.walleij@linaro.org, lee.jones@linaro.org Subject: [PATCH 2/2] mfd: ab8500-debugfs: remove unused function Date: Sat, 24 Sep 2016 13:36:53 +0800 Message-Id: <1474695413-30460-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160923_223726_729128_45034C2E X-CRM114-Status: GOOD ( 10.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: xie.baoyou@zte.com.cn, baoyou.xie@linaro.org, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP We get 1 warning when building kernel with W=1: drivers/mfd/ab8500-debugfs.c:1395:6: warning: no previous prototype for 'ab8500_dump_all_banks_to_mem' [-Wmissing-prototypes] In fact, this function is called by no one and not exported, so this patch removes it. Signed-off-by: Baoyou Xie Acked-by: Linus Walleij --- drivers/mfd/ab8500-debugfs.c | 54 -------------------------------------------- 1 file changed, 54 deletions(-) diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c index 0aecd7b..9f04a25 100644 --- a/drivers/mfd/ab8500-debugfs.c +++ b/drivers/mfd/ab8500-debugfs.c @@ -1382,60 +1382,6 @@ void ab8500_dump_all_banks(struct device *dev) } } -/* Space for 500 registers. */ -#define DUMP_MAX_REGS 700 -static struct ab8500_register_dump -{ - u8 bank; - u8 reg; - u8 value; -} ab8500_complete_register_dump[DUMP_MAX_REGS]; - -/* This shall only be called upon kernel panic! */ -void ab8500_dump_all_banks_to_mem(void) -{ - int i, r = 0; - u8 bank; - int err = 0; - - pr_info("Saving all ABB registers for crash analysis.\n"); - - for (bank = 0; bank < AB8500_NUM_BANKS; bank++) { - for (i = 0; i < debug_ranges[bank].num_ranges; i++) { - u8 reg; - - for (reg = debug_ranges[bank].range[i].first; - reg <= debug_ranges[bank].range[i].last; - reg++) { - u8 value; - - err = prcmu_abb_read(bank, reg, &value, 1); - - if (err < 0) - goto out; - - ab8500_complete_register_dump[r].bank = bank; - ab8500_complete_register_dump[r].reg = reg; - ab8500_complete_register_dump[r].value = value; - - r++; - - if (r >= DUMP_MAX_REGS) { - pr_err("%s: too many register to dump!\n", - __func__); - err = -EINVAL; - goto out; - } - } - } - } -out: - if (err >= 0) - pr_info("Saved all ABB registers.\n"); - else - pr_info("Failed to save all ABB registers.\n"); -} - static int ab8500_all_banks_open(struct inode *inode, struct file *file) { struct seq_file *s;