| Message ID | 1475166715-7857-3-git-send-email-bgolaszewski@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thursday 29 September 2016 10:01 PM, Bartosz Golaszewski wrote: > From: Karl Beldan <kbeldan@baylibre.com> > > Add a disabled LCDC node to be reused in device trees including > da850.dtsi for boards equipped with tilcdc enabled. > > Signed-off-by: Karl Beldan <kbeldan@baylibre.com> > [Bartosz: added the commit description] > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > arch/arm/boot/dts/da850.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi > index f79e1b9..9f39296 100644 > --- a/arch/arm/boot/dts/da850.dtsi > +++ b/arch/arm/boot/dts/da850.dtsi > @@ -399,6 +399,14 @@ > <&edma0 0 1>; > dma-names = "tx", "rx"; > }; > + > + lcdc: lcdc@213000 { node name should be generic per the ePAPR so please use "display". > + compatible = "ti,am33xx-tilcdc"; Can you please introduce a da850 specific compatible. Something like: compatible = "ti,da850-tilcdc", "ti,am33xx-tilcdc"; Even if you dont use it in the driver today, please have it in the .dts I am pretty sure there will be some da850 specific tweak required for the LCDC at some point. Having a compatible already in place will make migration easier. You will have to document the compatible though. This will affect 1/6 too. Thanks, Sekhar
2016-09-30 11:34 GMT+02:00 Sekhar Nori <nsekhar@ti.com>: > On Thursday 29 September 2016 10:01 PM, Bartosz Golaszewski wrote: >> From: Karl Beldan <kbeldan@baylibre.com> >> >> Add a disabled LCDC node to be reused in device trees including >> da850.dtsi for boards equipped with tilcdc enabled. >> >> Signed-off-by: Karl Beldan <kbeldan@baylibre.com> >> [Bartosz: added the commit description] >> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> >> --- >> arch/arm/boot/dts/da850.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi >> index f79e1b9..9f39296 100644 >> --- a/arch/arm/boot/dts/da850.dtsi >> +++ b/arch/arm/boot/dts/da850.dtsi >> @@ -399,6 +399,14 @@ >> <&edma0 0 1>; >> dma-names = "tx", "rx"; >> }; >> + >> + lcdc: lcdc@213000 { > > node name should be generic per the ePAPR so please use "display". > >> + compatible = "ti,am33xx-tilcdc"; > > Can you please introduce a da850 specific compatible. Something like: > > compatible = "ti,da850-tilcdc", "ti,am33xx-tilcdc"; > I sent a relevant patch to the drm mailing list. > Even if you dont use it in the driver today, please have it in the .dts > I am pretty sure there will be some da850 specific tweak required for > the LCDC at some point. Having a compatible already in place will make > migration easier. You will have to document the compatible though. > > This will affect 1/6 too. > I'll include these changes in v2. Thanks, Bartosz
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi index f79e1b9..9f39296 100644 --- a/arch/arm/boot/dts/da850.dtsi +++ b/arch/arm/boot/dts/da850.dtsi @@ -399,6 +399,14 @@ <&edma0 0 1>; dma-names = "tx", "rx"; }; + + lcdc: lcdc@213000 { + compatible = "ti,am33xx-tilcdc"; + reg = <0x213000 0x1000>; + interrupt-parent = <&intc>; + interrupts = <52>; + status = "disabled"; + }; }; aemif: aemif@68000000 { compatible = "ti,da850-aemif";