| Message ID | 1475875432-13627-1-git-send-email-scott.branden@broadcom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 10/07/2016 02:23 PM, Scott Branden wrote: > Enable support for on board SPI EEPROM by turning on > CONFIG_EEPROM_AT25. > > Signed-off-by: Scott Branden <scott.branden@broadcom.com> Looks fine to me, unless this needs to be a module, Arnd, what do you think? > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index eadf485..9955ee1 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -136,6 +136,7 @@ CONFIG_MTD_SPI_NOR=y > CONFIG_BLK_DEV_LOOP=y > CONFIG_BLK_DEV_NBD=m > CONFIG_VIRTIO_BLK=y > +CONFIG_EEPROM_AT25=y > CONFIG_SRAM=y > # CONFIG_SCSI_PROC_FS is not set > CONFIG_BLK_DEV_SD=y >
On Monday, October 10, 2016 2:08:05 AM CEST Florian Fainelli wrote: > On 10/07/2016 02:23 PM, Scott Branden wrote: > > Enable support for on board SPI EEPROM by turning on > > CONFIG_EEPROM_AT25. > > > > Signed-off-by: Scott Branden <scott.branden@broadcom.com> > > Looks fine to me, unless this needs to be a module, Arnd, what do you think? Please either make it a module or explain in the patch description why it should be built-in. Arnd
Hi Arnd, On 16-10-10 02:20 AM, Arnd Bergmann wrote: > On Monday, October 10, 2016 2:08:05 AM CEST Florian Fainelli wrote: >> On 10/07/2016 02:23 PM, Scott Branden wrote: >>> Enable support for on board SPI EEPROM by turning on >>> CONFIG_EEPROM_AT25. >>> >>> Signed-off-by: Scott Branden <scott.branden@broadcom.com> >> >> Looks fine to me, unless this needs to be a module, Arnd, what do you think? > > Please either make it a module or explain in the patch description > why it should be built-in. We use a fixed rootfs image to test the kernel. For simplicity we don't construct a rootfs or load any modules. We just test the kernel image. So for us every defconfig we use needs to be set to y to use the upstreamed kernel. > > Arnd > Regards, Scott
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index eadf485..9955ee1 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -136,6 +136,7 @@ CONFIG_MTD_SPI_NOR=y CONFIG_BLK_DEV_LOOP=y CONFIG_BLK_DEV_NBD=m CONFIG_VIRTIO_BLK=y +CONFIG_EEPROM_AT25=y CONFIG_SRAM=y # CONFIG_SCSI_PROC_FS is not set CONFIG_BLK_DEV_SD=y
Enable support for on board SPI EEPROM by turning on CONFIG_EEPROM_AT25. Signed-off-by: Scott Branden <scott.branden@broadcom.com> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)