| Message ID | 1477075018-20176-3-git-send-email-david@lechnology.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Saturday 22 October 2016 12:06 AM, David Lechner wrote: > In the davinci default configuration, don't append the git revision to > the local kernel version by. This seems like the more desirable default > value. Why? To the contrary I actually quite like the fact that the git commit is appended to version string. Makes it easy for me to cross-check that I am booting the right image. > > Signed-off-by: David Lechner <david@lechnology.com> Thanks, Sekhar
On 10/24/2016 06:35 AM, Sekhar Nori wrote: > On Saturday 22 October 2016 12:06 AM, David Lechner wrote: >> In the davinci default configuration, don't append the git revision to >> the local kernel version by. This seems like the more desirable default >> value. > > Why? To the contrary I actually quite like the fact that the git commit > is appended to version string. Makes it easy for me to cross-check that > I am booting the right image. > >> >> Signed-off-by: David Lechner <david@lechnology.com> > > Thanks, > Sekhar > Each time you make a commit, you get a new version, which installs another copy of the kernel modules on the device. This will fill up the SD card if you are making many commits. Also, if someone wants to build the mainline kernel using the default configuration, it seems odd to have a git revision tacked on to the end even though you made no revisions.
On Monday 24 October 2016 08:45 PM, David Lechner wrote: > On 10/24/2016 06:35 AM, Sekhar Nori wrote: >> On Saturday 22 October 2016 12:06 AM, David Lechner wrote: >>> In the davinci default configuration, don't append the git revision to >>> the local kernel version by. This seems like the more desirable default >>> value. >> >> Why? To the contrary I actually quite like the fact that the git commit >> is appended to version string. Makes it easy for me to cross-check that >> I am booting the right image. >> >>> >>> Signed-off-by: David Lechner <david@lechnology.com> >> >> Thanks, >> Sekhar >> > > Each time you make a commit, you get a new version, which installs > another copy of the kernel modules on the device. This will fill up the > SD card if you are making many commits. Right, but thats easily fixable by removing existing modules before installing new ones. > Also, if someone wants to build the mainline kernel using the default > configuration, it seems odd to have a git revision tacked on to the end > even though you made no revisions. If you checkout a tag and build, then no commit information is added. Which I guess is what most end users will do. I don't see this done in other defconfigs like omap2plus and multi_v7 as well. I would like to keep it similar for davinci. Thanks, Sekhar
On 10/26/2016 05:54 AM, Sekhar Nori wrote: > On Monday 24 October 2016 08:45 PM, David Lechner wrote: >> On 10/24/2016 06:35 AM, Sekhar Nori wrote: >>> On Saturday 22 October 2016 12:06 AM, David Lechner wrote: >>>> In the davinci default configuration, don't append the git revision to >>>> the local kernel version by. This seems like the more desirable default >>>> value. >>> >>> Why? To the contrary I actually quite like the fact that the git commit >>> is appended to version string. Makes it easy for me to cross-check that >>> I am booting the right image. >>> >>>> >>>> Signed-off-by: David Lechner <david@lechnology.com> >>> >>> Thanks, >>> Sekhar >>> >> >> Each time you make a commit, you get a new version, which installs >> another copy of the kernel modules on the device. This will fill up the >> SD card if you are making many commits. > > Right, but thats easily fixable by removing existing modules before > installing new ones. > >> Also, if someone wants to build the mainline kernel using the default >> configuration, it seems odd to have a git revision tacked on to the end >> even though you made no revisions. > > If you checkout a tag and build, then no commit information is added. > Which I guess is what most end users will do. > > I don't see this done in other defconfigs like omap2plus and multi_v7 as > well. I would like to keep it similar for davinci. > > Thanks, > Sekhar > OK, I will drop this patch.
diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig index a2f89a3..9254609 100644 --- a/arch/arm/configs/davinci_all_defconfig +++ b/arch/arm/configs/davinci_all_defconfig @@ -1,3 +1,4 @@ +# CONFIG_LOCALVERSION_AUTO is not set # CONFIG_SWAP is not set CONFIG_SYSVIPC=y CONFIG_POSIX_MQUEUE=y
In the davinci default configuration, don't append the git revision to the local kernel version by. This seems like the more desirable default value. Signed-off-by: David Lechner <david@lechnology.com> --- arch/arm/configs/davinci_all_defconfig | 1 + 1 file changed, 1 insertion(+)