From patchwork Thu Nov 10 18:18:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 9421925 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C66F8601C0 for ; Thu, 10 Nov 2016 18:21:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D2C11297FA for ; Thu, 10 Nov 2016 18:21:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C7C2B297FD; Thu, 10 Nov 2016 18:21:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8B26B297FA for ; Thu, 10 Nov 2016 18:21:29 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1c4tx0-0000Lk-Sd; Thu, 10 Nov 2016 18:19:50 +0000 Received: from mail-it0-x22b.google.com ([2607:f8b0:4001:c0b::22b]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1c4twU-0000Bd-3W for linux-arm-kernel@lists.infradead.org; Thu, 10 Nov 2016 18:19:19 +0000 Received: by mail-it0-x22b.google.com with SMTP id u205so59573086itc.0 for ; Thu, 10 Nov 2016 10:18:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pAt8dWMispOpste6bELYS+OlKNP4dcrXQ8CQciSQIho=; b=OASgm1SsqskDroHUxagxBitj2XrWk0Ir0gVZw6M6ZJICWtdGxOQodGwLJtpORboI2B DcZBQ1CJoY2+w1+JUY/887FaF+uwjXIRaOttPsEzndi+6TevETB1g4OjbJNKuHYqyJk/ rryWRAIkWpeMzbxKY2MTvhyjzHyQ28KPlMlpQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pAt8dWMispOpste6bELYS+OlKNP4dcrXQ8CQciSQIho=; b=J9ZppNiUe+8FgAxoEoqxx2swYCPtrH7NSnuE0KM+aLwIGenXKPby9csfTQ6BP8PlSA 8mqur0XwYW2mlVEYn1BHRB2MR/OVfQehYPkR7GfCPt1U1qGws8HjMOtQpLimeMz1LaPL KtnWoW1K8R8KpzJww7aXTphgX8z15/+JwfMwhXLe+t9VIzXq+wsQ5wj5GCJf7rR0za9u bzgEfw5Iy0AkVl5gQ8roEdA4nWIeAo2U4714gMXTCsMQhbwHDhakOUPoPSBONlJzIOTv rj4sFuUTzfTpU13Z3GMPZvwIAmjwqb5q9KbtMU6d3UzqV8URB9Ljik3POOUF4LrSN7GW 9zqA== X-Gm-Message-State: ABUngvcA+TnPCNOk+wqsk+etKgqClLyqgOkBxrHmOqX4JqlnP8PgoeFawB5dIlpGUD64zS7T X-Received: by 10.36.237.3 with SMTP id r3mr5176609ith.76.1478801937111; Thu, 10 Nov 2016 10:18:57 -0800 (PST) Received: from t430.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id 62sm10377930itl.19.2016.11.10.10.18.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 10 Nov 2016 10:18:56 -0800 (PST) From: Mathieu Poirier To: gregkh@linuxfoundation.org Subject: [PATCH 1/8] coresight: stm: return error code instead of zero in .packet() Date: Thu, 10 Nov 2016 11:18:47 -0700 Message-Id: <1478801934-26904-2-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1478801934-26904-1-git-send-email-mathieu.poirier@linaro.org> References: <1478801934-26904-1-git-send-email-mathieu.poirier@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161110_101918_271274_90D8F4A0 X-CRM114-Status: GOOD ( 12.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Chunyan Zhang In STM framework driver, the trace data writing loop would keep running until it received a negative return value or the whole trace packet has been written to STM device. So if the .packet() of STM device always returns zero since the device is not enabled or the parameter isn't supported, STM framework driver will stall into a dead loop. Returning -EACCES (Permission denied) in .packet() if the device is disabled makes more sense, and this is the same for returning -EINVAL if the channel passed into is not supported. Signed-off-by: Chunyan Zhang Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-stm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c index 49e0f1b925a5..d397849c2c6a 100644 --- a/drivers/hwtracing/coresight/coresight-stm.c +++ b/drivers/hwtracing/coresight/coresight-stm.c @@ -419,10 +419,10 @@ static ssize_t stm_generic_packet(struct stm_data *stm_data, struct stm_drvdata, stm); if (!(drvdata && local_read(&drvdata->mode))) - return 0; + return -EACCES; if (channel >= drvdata->numsp) - return 0; + return -EINVAL; ch_addr = (unsigned long)stm_channel_addr(drvdata, channel);