diff mbox

[2/2] MAINTAINERS: Add myself as co-maintainer to fpga mgr framework.

Message ID 1479764942-14321-2-git-send-email-mdf@kernel.org (mailing list archive)
State New, archived
Headers show

Commit Message

Moritz Fischer Nov. 21, 2016, 9:49 p.m. UTC
Add myself as co-maintainer to fpga mgr framework.

Signed-off-by: Moritz Fischer <mdf@kernel.org>
Cc: Alan Tull <atull@opensource.altera.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Cc: linux-fpga@vger.kernel.org
---
Hi all,

Lately we've fallen behind a bit on reviewing patches lately.

'Behind the scenes', Alan has worked on getting a git tree setup
for us on kernel.org and I've worked on getting the mailing list setup.
The mailing list is up and running (see patch [1/2]) of this series.

Greg said he'd be happy to take pull requests from now on, so I hope
once we have figured out the exact workflow things will be much smoother
getting your patches merged into the fpga mgr framework.

Feel free to comment / speak up if you're not cool with this change.

Thanks,

Moritz

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marek Vasut Nov. 21, 2016, 10:09 p.m. UTC | #1
On 11/21/2016 10:49 PM, Moritz Fischer wrote:
> Add myself as co-maintainer to fpga mgr framework.
> 
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> Cc: Alan Tull <atull@opensource.altera.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-fpga@vger.kernel.org

Acked-by: Marek Vasut <marex@denx.de>

> ---
> Hi all,
> 
> Lately we've fallen behind a bit on reviewing patches lately.
> 
> 'Behind the scenes', Alan has worked on getting a git tree setup
> for us on kernel.org and I've worked on getting the mailing list setup.
> The mailing list is up and running (see patch [1/2]) of this series.
> 
> Greg said he'd be happy to take pull requests from now on, so I hope
> once we have figured out the exact workflow things will be much smoother
> getting your patches merged into the fpga mgr framework.
> 
> Feel free to comment / speak up if you're not cool with this change.
> 
> Thanks,
> 
> Moritz
> 
> ---
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 19527a0..1856594 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5004,7 +5004,7 @@ K:	fmc_d.*register
>  
>  FPGA MANAGER FRAMEWORK
>  M:	Alan Tull <atull@opensource.altera.com>
> -R:	Moritz Fischer <moritz.fischer@ettus.com>
> +M:	Moritz Fischer <moritz.fischer@ettus.com>
>  L:	linux-fpga@vger.kernel.org
>  S:	Maintained
>  F:	drivers/fpga/
>
Alan Tull Nov. 22, 2016, 2:29 a.m. UTC | #2
On Mon, 21 Nov 2016, Moritz Fischer wrote:

> Add myself as co-maintainer to fpga mgr framework.
> 
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> Cc: Alan Tull <atull@opensource.altera.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-fpga@vger.kernel.org
> ---
> Hi all,
> 
> Lately we've fallen behind a bit on reviewing patches lately.

Hi Moritz,

drivers/fpga has been in the upstream kernel a year now.  Most of that
time, traffic has been very slow.  Recently we had more traffic while
I was travelling and moving to a new office, both cases leaving me
with bad network connectivity.  Things will probably return to normal.
I appreciate your passion and all your effort reviewing stuff.  I
don't see a need for two maintainers at this point.

Alan

> 
> 'Behind the scenes', Alan has worked on getting a git tree setup
> for us on kernel.org and I've worked on getting the mailing list setup.
> The mailing list is up and running (see patch [1/2]) of this series.
> 
> Greg said he'd be happy to take pull requests from now on, so I hope
> once we have figured out the exact workflow things will be much smoother
> getting your patches merged into the fpga mgr framework.
> 
> Feel free to comment / speak up if you're not cool with this change.
> 
> Thanks,
> 
> Moritz
> 
> ---
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 19527a0..1856594 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5004,7 +5004,7 @@ K:	fmc_d.*register
>  
>  FPGA MANAGER FRAMEWORK
>  M:	Alan Tull <atull@opensource.altera.com>
> -R:	Moritz Fischer <moritz.fischer@ettus.com>
> +M:	Moritz Fischer <moritz.fischer@ettus.com>
>  L:	linux-fpga@vger.kernel.org
>  S:	Maintained
>  F:	drivers/fpga/
> -- 
> 2.7.4
> 
>
Michal Simek Nov. 22, 2016, 7:48 a.m. UTC | #3
On 22.11.2016 03:29, atull wrote:
> On Mon, 21 Nov 2016, Moritz Fischer wrote:
> 
>> Add myself as co-maintainer to fpga mgr framework.
>>
>> Signed-off-by: Moritz Fischer <mdf@kernel.org>
>> Cc: Alan Tull <atull@opensource.altera.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: linux-kernel@vger.kernel.org
>> Cc: linux-fpga@vger.kernel.org
>> ---
>> Hi all,
>>
>> Lately we've fallen behind a bit on reviewing patches lately.
> 
> Hi Moritz,
> 
> drivers/fpga has been in the upstream kernel a year now.  Most of that
> time, traffic has been very slow.  Recently we had more traffic while
> I was travelling and moving to a new office, both cases leaving me
> with bad network connectivity.  Things will probably return to normal.
> I appreciate your passion and all your effort reviewing stuff.  I
> don't see a need for two maintainers at this point.

TBH. I think it is not a bad option. I do normally have backup person
for all repos I do maintain. It doesn't mean that second maintainer does
something but it has all accesses to repos you maintain.
It means if something really happens to you (hopefully not) than this
person can continue in this work without any delay which is not a bad
thing.
It is really just about talking to each other what that second person
will do - probably just review patches as is done now. You can also
learn from each other.
I would like to be involved more in this but unfortunately I don't have
enough time to do it properly.

Regarding maintaining this repo. It is just standard process. Apply
sensible things, well described and test it. And then send pull request
to Greg based on signed tags and you are done.
Greg should told you what should be the base which you should use for
pull request. Someone is taking patches based on rc1 tag, someone is
rebasing it on the final tag.

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal
Greg KH Nov. 22, 2016, 8:07 a.m. UTC | #4
On Tue, Nov 22, 2016 at 08:48:57AM +0100, Michal Simek wrote:
> On 22.11.2016 03:29, atull wrote:
> > On Mon, 21 Nov 2016, Moritz Fischer wrote:
> > 
> >> Add myself as co-maintainer to fpga mgr framework.
> >>
> >> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> >> Cc: Alan Tull <atull@opensource.altera.com>
> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >> Cc: linux-kernel@vger.kernel.org
> >> Cc: linux-fpga@vger.kernel.org
> >> ---
> >> Hi all,
> >>
> >> Lately we've fallen behind a bit on reviewing patches lately.
> > 
> > Hi Moritz,
> > 
> > drivers/fpga has been in the upstream kernel a year now.  Most of that
> > time, traffic has been very slow.  Recently we had more traffic while
> > I was travelling and moving to a new office, both cases leaving me
> > with bad network connectivity.  Things will probably return to normal.
> > I appreciate your passion and all your effort reviewing stuff.  I
> > don't see a need for two maintainers at this point.
> 
> TBH. I think it is not a bad option. I do normally have backup person
> for all repos I do maintain. It doesn't mean that second maintainer does
> something but it has all accesses to repos you maintain.
> It means if something really happens to you (hopefully not) than this
> person can continue in this work without any delay which is not a bad
> thing.
> It is really just about talking to each other what that second person
> will do - probably just review patches as is done now. You can also
> learn from each other.
> I would like to be involved more in this but unfortunately I don't have
> enough time to do it properly.
> 
> Regarding maintaining this repo. It is just standard process. Apply
> sensible things, well described and test it. And then send pull request
> to Greg based on signed tags and you are done.
> Greg should told you what should be the base which you should use for
> pull request. Someone is taking patches based on rc1 tag, someone is
> rebasing it on the final tag.

Greg doesn't care what base you use, as long as you don't rebase
patches.  What subsystem does that?  I need to go yell at someone...

And I take patches just as easily, what ever works best for the
subsystem.

thanks,

greg k-h
Michal Simek Nov. 22, 2016, 8:28 a.m. UTC | #5
On 22.11.2016 09:07, Greg Kroah-Hartman wrote:
> On Tue, Nov 22, 2016 at 08:48:57AM +0100, Michal Simek wrote:
>> On 22.11.2016 03:29, atull wrote:
>>> On Mon, 21 Nov 2016, Moritz Fischer wrote:
>>>
>>>> Add myself as co-maintainer to fpga mgr framework.
>>>>
>>>> Signed-off-by: Moritz Fischer <mdf@kernel.org>
>>>> Cc: Alan Tull <atull@opensource.altera.com>
>>>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>> Cc: linux-kernel@vger.kernel.org
>>>> Cc: linux-fpga@vger.kernel.org
>>>> ---
>>>> Hi all,
>>>>
>>>> Lately we've fallen behind a bit on reviewing patches lately.
>>>
>>> Hi Moritz,
>>>
>>> drivers/fpga has been in the upstream kernel a year now.  Most of that
>>> time, traffic has been very slow.  Recently we had more traffic while
>>> I was travelling and moving to a new office, both cases leaving me
>>> with bad network connectivity.  Things will probably return to normal.
>>> I appreciate your passion and all your effort reviewing stuff.  I
>>> don't see a need for two maintainers at this point.
>>
>> TBH. I think it is not a bad option. I do normally have backup person
>> for all repos I do maintain. It doesn't mean that second maintainer does
>> something but it has all accesses to repos you maintain.
>> It means if something really happens to you (hopefully not) than this
>> person can continue in this work without any delay which is not a bad
>> thing.
>> It is really just about talking to each other what that second person
>> will do - probably just review patches as is done now. You can also
>> learn from each other.
>> I would like to be involved more in this but unfortunately I don't have
>> enough time to do it properly.
>>
>> Regarding maintaining this repo. It is just standard process. Apply
>> sensible things, well described and test it. And then send pull request
>> to Greg based on signed tags and you are done.
>> Greg should told you what should be the base which you should use for
>> pull request. Someone is taking patches based on rc1 tag, someone is
>> rebasing it on the final tag.
> 
> Greg doesn't care what base you use, as long as you don't rebase
> patches.  What subsystem does that?  I need to go yell at someone...

:-) Not sure if there is any subsystem which use this.
And for my microblaze tree I do normally base patches on the top of
rc7/8 or final tag but that's done mostly because I collect patches at
that time. But IIRC when I started with this someone mentioned that for
small number of patches this is fine.

Thanks,
Michal
Jason Gunthorpe Nov. 22, 2016, 4:35 p.m. UTC | #6
On Tue, Nov 22, 2016 at 08:48:57AM +0100, Michal Simek wrote:

> TBH. I think it is not a bad option. I do normally have backup person
> for all repos I do maintain. It doesn't mean that second maintainer does
> something but it has all accesses to repos you maintain.

I agree, it is a good idea to have a maintainer team model as early as
possible just because stuff does happen. We've had to recover from MIA
maintainers in RDMA and TPM, and it is not really nice. Generally
a lot of patches just get dropped :(

Jason
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 19527a0..1856594 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5004,7 +5004,7 @@  K:	fmc_d.*register
 
 FPGA MANAGER FRAMEWORK
 M:	Alan Tull <atull@opensource.altera.com>
-R:	Moritz Fischer <moritz.fischer@ettus.com>
+M:	Moritz Fischer <moritz.fischer@ettus.com>
 L:	linux-fpga@vger.kernel.org
 S:	Maintained
 F:	drivers/fpga/