From patchwork Tue Nov 29 16:47:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 9452701 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E1A1E60710 for ; Tue, 29 Nov 2016 16:49:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D18AB28249 for ; Tue, 29 Nov 2016 16:49:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C36D6283C2; Tue, 29 Nov 2016 16:49:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5393928249 for ; Tue, 29 Nov 2016 16:49:39 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1cBlZM-00062d-Ct; Tue, 29 Nov 2016 16:47:48 +0000 Received: from mail-io0-x22d.google.com ([2607:f8b0:4001:c06::22d]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cBlZH-0005wH-HI for linux-arm-kernel@lists.infradead.org; Tue, 29 Nov 2016 16:47:44 +0000 Received: by mail-io0-x22d.google.com with SMTP id a124so299163229ioe.2 for ; Tue, 29 Nov 2016 08:47:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pAt8dWMispOpste6bELYS+OlKNP4dcrXQ8CQciSQIho=; b=bDif/j1SKwb5UHn4oJ5209z4KC0Exq8M8H0OoaVFzTzGPQ2PYxfB9gCrKFFo80Lnpb mh2JP/MPCIzn48xBWn4PhteykDfpPCicYsafTSB11rDR5Fp4R453zgCTtMfgeV50IERi YBGNtRuoS1iZQ7TcOS4SPWJSwvJLx1AV3B+xw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pAt8dWMispOpste6bELYS+OlKNP4dcrXQ8CQciSQIho=; b=a91SKBoeoR4txpuxGnxYxvbKIHTe8ZIR4uztJwpaTEZIKr0AVg3L2rPiMwl5IUjtR9 /4d7c3u2nCwkqsdePCT1tyMs6Ix8mLtMlM+xfuOD3IBins2noqDVKR0qJxMg358MgfVx yLWM79Fb4i+WXxK6CscG/oNTM71jsSJEtJsRarzE7N6Hg+vd1Du1oDvFK3EolaQJJu+T Cki8ptqishqg5814mQ5J/9SY1SV9c1/ATqJI8nrr6FEP4x4P7INHYa8PmPw4SzpPWtu3 TO4oQNMSmrYOomQH5XIyWyThG6N855Zayo5JviCHW3bR40m0h82iq36Yo8x6XoqCYKf9 F+6A== X-Gm-Message-State: AKaTC00/QG7lRA1t5/4jHEXiKgb41NVEK3j3BwxP7rvxJr7/ad9G43ctwuvACBo71EdSDq8E X-Received: by 10.36.77.207 with SMTP id l198mr24073083itb.18.1480438042025; Tue, 29 Nov 2016 08:47:22 -0800 (PST) Received: from t430.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id l3sm21810442ioa.7.2016.11.29.08.47.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 29 Nov 2016 08:47:21 -0800 (PST) From: Mathieu Poirier To: gregkh@linuxfoundation.org Subject: [PATCH 1/9] coresight: stm: return error code instead of zero in .packet() Date: Tue, 29 Nov 2016 09:47:11 -0700 Message-Id: <1480438039-24960-2-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1480438039-24960-1-git-send-email-mathieu.poirier@linaro.org> References: <1480438039-24960-1-git-send-email-mathieu.poirier@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161129_084743_687609_C7FD1C41 X-CRM114-Status: GOOD ( 12.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Chunyan Zhang In STM framework driver, the trace data writing loop would keep running until it received a negative return value or the whole trace packet has been written to STM device. So if the .packet() of STM device always returns zero since the device is not enabled or the parameter isn't supported, STM framework driver will stall into a dead loop. Returning -EACCES (Permission denied) in .packet() if the device is disabled makes more sense, and this is the same for returning -EINVAL if the channel passed into is not supported. Signed-off-by: Chunyan Zhang Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-stm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c index 49e0f1b925a5..d397849c2c6a 100644 --- a/drivers/hwtracing/coresight/coresight-stm.c +++ b/drivers/hwtracing/coresight/coresight-stm.c @@ -419,10 +419,10 @@ static ssize_t stm_generic_packet(struct stm_data *stm_data, struct stm_drvdata, stm); if (!(drvdata && local_read(&drvdata->mode))) - return 0; + return -EACCES; if (channel >= drvdata->numsp) - return 0; + return -EINVAL; ch_addr = (unsigned long)stm_channel_addr(drvdata, channel);