From patchwork Tue Nov 29 18:55:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laura Abbott X-Patchwork-Id: 9453025 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B2D6560710 for ; Tue, 29 Nov 2016 19:01:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A0F48283E6 for ; Tue, 29 Nov 2016 19:01:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 937A1283F1; Tue, 29 Nov 2016 19:01:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2C5C7283E6 for ; Tue, 29 Nov 2016 19:01:30 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1cBnd8-00077B-NL; Tue, 29 Nov 2016 18:59:50 +0000 Received: from mail-qk0-f182.google.com ([209.85.220.182]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cBnZi-0004jS-Ms for linux-arm-kernel@lists.infradead.org; Tue, 29 Nov 2016 18:56:24 +0000 Received: by mail-qk0-f182.google.com with SMTP id q130so184715541qke.1 for ; Tue, 29 Nov 2016 10:55:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=EXwI//735avNHNtgaYeJ34AgUjoJ+O6Nc/ExTz778zc=; b=MDar1wL8XVZILICC00o/BRw2Ora/a+SwFsOmw6x1LHPrJz0SBSdGw5aK/5bApZAtKo 62ByhPqakdNGZgB9kndfEsYzQWuXDynF9aEcz8Ze5k6+DPLDK7LgKqPCcAcPwo6L0K9S pRTyTLCkgLYH3IkMja4DZQRMtGK6TcUclhqkSMGozJcjnrgnydBGqnkLZ2kaMkN7BASQ Feyd0DpHtBVkvYc6kaaeUE9tMeEQDMYvw27tOHJgO4gf6POkzNw2/SAnrHllKs4DaKEr C37FbhXdPlFaksFMt1bVfwQpuTkum6ADuLcHYrqyjf08upAg9zMnXvViWu3tKMreptM4 v0Vw== X-Gm-Message-State: AKaTC03GYMd9Xzk8kD2eUVAOB5xPykok6l9keZnzxUP65ia9wzefA+H77cbznkbYeSiLdCPn X-Received: by 10.55.155.146 with SMTP id d140mr24280273qke.127.1480445757368; Tue, 29 Nov 2016 10:55:57 -0800 (PST) Received: from labbott-redhat-machine.redhat.com ([2601:602:9800:177f::df9b]) by smtp.gmail.com with ESMTPSA id p28sm31446489qtb.31.2016.11.29.10.55.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Nov 2016 10:55:56 -0800 (PST) From: Laura Abbott To: Mark Rutland , Ard Biesheuvel , Will Deacon , Catalin Marinas , Eric Biederman Subject: [PATCHv4 07/10] kexec: Switch to __pa_symbol Date: Tue, 29 Nov 2016 10:55:26 -0800 Message-Id: <1480445729-27130-8-git-send-email-labbott@redhat.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1480445729-27130-1-git-send-email-labbott@redhat.com> References: <1480445729-27130-1-git-send-email-labbott@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161129_105619_114041_CB5306BA X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar , "H. Peter Anvin" , Joonsoo Kim , Thomas Gleixner , Laura Abbott , Andrew Morton , linux-arm-kernel@lists.infradead.org, Marek Szyprowski MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP __pa_symbol is the correct api to get the physical address of kernel symbols. Switch to it to allow for better debug checking. Signed-off-by: Laura Abbott Acked-by: "Eric W. Biederman" --- Found during review of the kernel. Untested. --- kernel/kexec_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c index 5616755..e1b625e 100644 --- a/kernel/kexec_core.c +++ b/kernel/kexec_core.c @@ -1397,7 +1397,7 @@ void __weak arch_crash_save_vmcoreinfo(void) phys_addr_t __weak paddr_vmcoreinfo_note(void) { - return __pa((unsigned long)(char *)&vmcoreinfo_note); + return __pa_symbol((unsigned long)(char *)&vmcoreinfo_note); } static int __init crash_save_vmcoreinfo_init(void)