From patchwork Tue Dec 6 07:42:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 9462123 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 51DC56022E for ; Tue, 6 Dec 2016 07:45:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 29FD32815E for ; Tue, 6 Dec 2016 07:45:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1DC922818E; Tue, 6 Dec 2016 07:45:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AEA202815E for ; Tue, 6 Dec 2016 07:45:36 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1cEAPx-0002Jf-OE; Tue, 06 Dec 2016 07:44:01 +0000 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cEAPi-0002D7-0h for linux-arm-kernel@lists.infradead.org; Tue, 06 Dec 2016 07:43:46 +0000 Received: by mail-pg0-x242.google.com with SMTP id e9so19018719pgc.1 for ; Mon, 05 Dec 2016 23:43:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SzjGLjNYmcH/2JaT8XBTrbahXde1J7vEsW9jzExICtE=; b=Fhvs1NqT7qmJXgVirWN5tI9pxEZlvJLfjNZJWJE6grFVO47TVCBS4XWRxG7dGUHMj6 U2FqBYO38k5abpTpl81lq4aZItWOy56fJ2ieIIKII6ksexD+zR8nNHff0fX9SRpRhdiH t7joH7PH0dtgoxUE5X5tgCAfYgrDykPZudpsHfSp6LBdXHLT+yVH2yZb+xn6m8G8uISj eNRZJIPol00qkRf/Ep+0m9Eq3wxoHQjo1q7xpPV7RAgMslpLXAQd/3QeTye33irW6o0e WhL9fO+vPMVuuCyz+zcVxswOb7sFO/SPnXq7aR2cEV+5lVN3UlKf7DWhHY7Zu73+E1J5 pQcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SzjGLjNYmcH/2JaT8XBTrbahXde1J7vEsW9jzExICtE=; b=NT7IEXRugVcs/FtGO9AZP+oft0LPHSQroAcR/iJafjyd8nRccGsirJjBr6g2+K36UH s2V3eg66YCtqY0WMTIdfbKBOL0QTzrsFV2dTDrF7WWuRqi5CzTAtRgchlhsp1Q92zhu8 61mOcEcofggOm/8QP/Umg+VW0E+DaLQKKD4l066KOOHR5kGyU3AkMR9Uwac2RVtXEnSR VqKeLJ+MEclibCSnAq/mUO7vZiwMeBDEg1WcjYm9tK785BvMFNarA3Dmkj9lI449Ic3a iGmSkUBqiIV+iJ9OujVgLXTvfYdRJ+Ikvezb7HBDbVcl3ocCkGYEIzihj96rXRbcL9AJ EWAA== X-Gm-Message-State: AKaTC03SuZpWmZWV2KPSNhVbWGxgG4zll71Gdl58+9Dw224etP3YdlJK6tPq6Vx4SQoIsg== X-Received: by 10.84.218.79 with SMTP id f15mr133024951plm.155.1481010204890; Mon, 05 Dec 2016 23:43:24 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id p26sm32508314pgn.11.2016.12.05.23.43.21 (version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 05 Dec 2016 23:43:24 -0800 (PST) From: Arvind Yadav To: mchehab@kernel.org, kgene@kernel.org, krzk@kernel.org Subject: [PATCH] media/platform/exynos4-is/fimc-is - Unmap region obtained by of_iomap Date: Tue, 6 Dec 2016 13:12:51 +0530 Message-Id: <1481010171-6247-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161205_234346_136346_A1EFDC4C X-CRM114-Status: UNSURE ( 9.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, s.nawrocki@samsung.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Free memory mapping, if fimc_is_probe is not successful. Signed-off-by: Arvind Yadav --- drivers/media/platform/exynos4-is/fimc-is.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/exynos4-is/fimc-is.c b/drivers/media/platform/exynos4-is/fimc-is.c index 32ca55f..10d98a5 100644 --- a/drivers/media/platform/exynos4-is/fimc-is.c +++ b/drivers/media/platform/exynos4-is/fimc-is.c @@ -818,12 +818,13 @@ static int fimc_is_probe(struct platform_device *pdev) is->irq = irq_of_parse_and_map(dev->of_node, 0); if (!is->irq) { dev_err(dev, "no irq found\n"); - return -EINVAL; + ret = -EINVAL; + goto err_iounmap; } ret = fimc_is_get_clocks(is); if (ret < 0) - return ret; + goto err_iounmap; platform_set_drvdata(pdev, is); @@ -877,6 +878,8 @@ err_irq: free_irq(is->irq, is); err_clk: fimc_is_put_clocks(is); +err_iounmap: + iounmap(is->pmu_regs); return ret; } @@ -932,6 +935,7 @@ static int fimc_is_remove(struct platform_device *pdev) fimc_is_unregister_subdevs(is); vb2_dma_contig_clear_max_seg_size(dev); fimc_is_put_clocks(is); + iounmap(is->pmu_regs); fimc_is_debugfs_remove(is); release_firmware(is->fw.f_w); fimc_is_free_cpu_memory(is);