| Message ID | 1482182934-18559-2-git-send-email-lilja.magnus@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Magnus, On Mon, Dec 19, 2016 at 7:28 PM, Magnus Lilja <lilja.magnus@gmail.com> wrote: > Commit 3d8cc00073d6750ffe883685e49b2e4a0f596370 consolidated the two The standard form to specify a commit is 3d8cc00073d6 ("dmaengine: ipu: Consolidate duplicated irq handlers") > interrupts routines into one, but the remaining interrupt routine only > checks the status of the error interrupts, not the normal interrupts. > > This patch fixes that problem (tested on i.MX31 PDK board). > > Signed-off-by: Magnus Lilja <lilja.magnus@gmail.com> Patch looks good, but I have some suggestions: - Subject should start with dmaengine, so something like: Subject: dmaengine: ipu: Make sure the .... - You sent these two patches on a series, but as they touch different subsystems they could be sent separately, each one to the proper maintainer. For dmaengine the maintainer is Vinod. Hint: you can run ./scripts/get_maintainer.pl on your patch and it will list the maintainer and lists the patches should be sent to. You should also add a Fixes tag above your Signed-off-by like this: Fixes: 3d8cc00073d6 ("dmaengine: ipu: Consolidate duplicated irq handlers") Cc: <stable@vger.kernel.org> # 4.3.x
Hi Fabio, On 21 December 2016 at 21:08, Fabio Estevam <festevam@gmail.com> wrote: > Hi Magnus, > > On Mon, Dec 19, 2016 at 7:28 PM, Magnus Lilja <lilja.magnus@gmail.com> wrote: >> Commit 3d8cc00073d6750ffe883685e49b2e4a0f596370 consolidated the two > > The standard form to specify a commit is 3d8cc00073d6 ("dmaengine: > ipu: Consolidate duplicated irq handlers") > >> interrupts routines into one, but the remaining interrupt routine only >> checks the status of the error interrupts, not the normal interrupts. >> >> This patch fixes that problem (tested on i.MX31 PDK board). >> >> Signed-off-by: Magnus Lilja <lilja.magnus@gmail.com> > > Patch looks good, but I have some suggestions: > > - Subject should start with dmaengine, so something like: > Subject: dmaengine: ipu: Make sure the .... > > - You sent these two patches on a series, but as they touch different > subsystems they could be sent separately, each one to the proper > maintainer. For dmaengine the maintainer is Vinod. Hint: you can run > ./scripts/get_maintainer.pl on your patch and it will list the > maintainer and lists the patches should be sent to. > > You should also add a Fixes tag above your Signed-off-by like this: > Fixes: 3d8cc00073d6 ("dmaengine: ipu: Consolidate duplicated irq handlers") > Cc: <stable@vger.kernel.org> # 4.3.x Thanks for review. I will add take care of your comments and send a new standalone patch. Regards, Magnus
diff --git a/drivers/dma/ipu/ipu_irq.c b/drivers/dma/ipu/ipu_irq.c index dd184b5..2846278 100644 --- a/drivers/dma/ipu/ipu_irq.c +++ b/drivers/dma/ipu/ipu_irq.c @@ -272,7 +272,7 @@ static void ipu_irq_handler(struct irq_desc *desc) u32 status; int i, line; - for (i = IPU_IRQ_NR_FN_BANKS; i < IPU_IRQ_NR_BANKS; i++) { + for (i = 0; i < IPU_IRQ_NR_BANKS; i++) { struct ipu_irq_bank *bank = irq_bank + i; raw_spin_lock(&bank_lock);
Commit 3d8cc00073d6750ffe883685e49b2e4a0f596370 consolidated the two interrupts routines into one, but the remaining interrupt routine only checks the status of the error interrupts, not the normal interrupts. This patch fixes that problem (tested on i.MX31 PDK board). Signed-off-by: Magnus Lilja <lilja.magnus@gmail.com> --- drivers/dma/ipu/ipu_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)