From patchwork Mon Dec 19 21:28:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Magnus Lilja X-Patchwork-Id: 9480769 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 47EFE601C2 for ; Mon, 19 Dec 2016 21:31:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 38707284FA for ; Mon, 19 Dec 2016 21:31:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2D7F3284FC; Mon, 19 Dec 2016 21:31:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F2ABF284FA for ; Mon, 19 Dec 2016 21:31:35 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1cJ5Vf-0006EJ-Pn; Mon, 19 Dec 2016 21:30:15 +0000 Received: from mail.lysator.liu.se ([2001:6b0:17:f0a0::3]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cJ5V9-0005ap-TO for linux-arm-kernel@lists.infradead.org; Mon, 19 Dec 2016 21:29:44 +0000 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 0D3D54002A for ; Mon, 19 Dec 2016 22:29:14 +0100 (CET) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id DA0F840045; Mon, 19 Dec 2016 22:29:13 +0100 (CET) Received: from localhost.localdomain (h-38-149.a328.priv.bahnhof.se [46.59.38.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 1999E4000F; Mon, 19 Dec 2016 22:29:13 +0100 (CET) From: Magnus Lilja To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] mfd: mc13xxx: Pass the IRQF_TRIGGER_HIGH flag. Date: Mon, 19 Dec 2016 22:28:54 +0100 Message-Id: <1482182934-18559-3-git-send-email-lilja.magnus@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1482182934-18559-1-git-send-email-lilja.magnus@gmail.com> References: <1482182934-18559-1-git-send-email-lilja.magnus@gmail.com> X-Virus-Scanned: ClamAV using ClamSMTP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161219_132944_202324_34B6EE4D X-CRM114-Status: GOOD ( 12.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: shawnguo@kernel.org, lee.jones@linaro.org, festevam@gmail.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP All supported mc13xxx devices have active high interrupt outputs. Make sure to configure the interrupt as active high by passing the IRQF_TRIGGER_HIGH flag. This is required at least on the i.MX31 PDK board. Signed-off-by: Magnus Lilja --- drivers/mfd/mc13xxx-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c index d7f54e4..4cbe6b7 100644 --- a/drivers/mfd/mc13xxx-core.c +++ b/drivers/mfd/mc13xxx-core.c @@ -440,7 +440,7 @@ int mc13xxx_common_init(struct device *dev) mc13xxx->irq_chip.irqs = mc13xxx->irqs; mc13xxx->irq_chip.num_irqs = ARRAY_SIZE(mc13xxx->irqs); - ret = regmap_add_irq_chip(mc13xxx->regmap, mc13xxx->irq, IRQF_ONESHOT, + ret = regmap_add_irq_chip(mc13xxx->regmap, mc13xxx->irq, IRQF_ONESHOT | IRQF_TRIGGER_HIGH, 0, &mc13xxx->irq_chip, &mc13xxx->irq_data); if (ret) return ret;