| Message ID | 1483500343-27113-1-git-send-email-linux@roeck-us.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jan 4, 2017 at 4:25 AM, Guenter Roeck <linux@roeck-us.net> wrote: > Checking if there is no error followed by a goto if there is one is > confusing. Reverse the logic. > > Signed-off-by: Guenter Roeck <linux@roeck-us.net> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Mon, Jan 09, 2017 at 08:38:03PM +0100, Linus Walleij wrote: > On Wed, Jan 4, 2017 at 4:25 AM, Guenter Roeck <linux@roeck-us.net> wrote: > > > Checking if there is no error followed by a goto if there is one is > > confusing. Reverse the logic. > > > > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Thanks! Guenter
diff --git a/drivers/watchdog/coh901327_wdt.c b/drivers/watchdog/coh901327_wdt.c index a099b77fc0b9..dc97b2fd6c49 100644 --- a/drivers/watchdog/coh901327_wdt.c +++ b/drivers/watchdog/coh901327_wdt.c @@ -360,12 +360,10 @@ static int __init coh901327_probe(struct platform_device *pdev) coh901327_wdt.parent = &pdev->dev; ret = watchdog_register_device(&coh901327_wdt); - if (ret == 0) - dev_info(&pdev->dev, - "initialized. timer margin=%d sec\n", margin); - else + if (ret) goto out_no_wdog; + dev_info(&pdev->dev, "initialized. timer margin=%d sec\n", margin); return 0; out_no_wdog:
Checking if there is no error followed by a goto if there is one is confusing. Reverse the logic. Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- drivers/watchdog/coh901327_wdt.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)