| Message ID | 1484260655-80477-1-git-send-email-christopher.lee.bostic@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jan 12, 2017 at 04:37:35PM -0600, christopher.lee.bostic@gmail.com wrote: > From: Chris Bostic <cbostic@us.ibm.com> > > Signed-off-by: Chris Bostic <cbostic@us.ibm.com> I can not accept patches that have no changelog text, and this one is very odd: > --- > drivers/fsi/fsi-core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c > index 28b82d1..db09836 100644 > --- a/drivers/fsi/fsi-core.c > +++ b/drivers/fsi/fsi-core.c > @@ -42,6 +42,7 @@ > > static DEFINE_IDA(master_ida); > > + Huh? Did something go wrong with your scripts? greg k-h
On Fri, Jan 13, 2017 at 1:15 AM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Thu, Jan 12, 2017 at 04:37:35PM -0600, christopher.lee.bostic@gmail.com wrote: >> From: Chris Bostic <cbostic@us.ibm.com> >> >> Signed-off-by: Chris Bostic <cbostic@us.ibm.com> > > I can not accept patches that have no changelog text, and this one is > very odd: > >> --- >> drivers/fsi/fsi-core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c >> index 28b82d1..db09836 100644 >> --- a/drivers/fsi/fsi-core.c >> +++ b/drivers/fsi/fsi-core.c >> @@ -42,6 +42,7 @@ >> >> static DEFINE_IDA(master_ida); >> >> + > > Huh? > > Did something go wrong with your scripts? Yes, had an error when sending out... Will correct this when I send out version 3 today. Sorry for the confusion. -Chris > > greg k-h
On Fri, Jan 13, 2017 at 1:15 AM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Thu, Jan 12, 2017 at 04:37:35PM -0600, christopher.lee.bostic@gmail.com wrote: >> From: Chris Bostic <cbostic@us.ibm.com> >> >> Signed-off-by: Chris Bostic <cbostic@us.ibm.com> > > I can not accept patches that have no changelog text, and this one is > very odd: Seems like this would be an easy check to add to 0-day. And perhaps missing S-o-B, too. Rob
diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c index 28b82d1..db09836 100644 --- a/drivers/fsi/fsi-core.c +++ b/drivers/fsi/fsi-core.c @@ -42,6 +42,7 @@ static DEFINE_IDA(master_ida); + struct fsi_slave { struct device dev; struct fsi_master *master;