| Message ID | 1484762037-10737-2-git-send-email-fabio.estevam@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 01/18, Fabio Estevam wrote: > Add an entry for the IMX7D_IPG_ROOT clock. > > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> > --- Applied to clk-next
Hi Fabio, On Wed, Jan 18, 2017 at 9:53 AM, Fabio Estevam <fabio.estevam@nxp.com> wrote: > Add an entry for the IMX7D_IPG_ROOT clock. > > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> kernelci.org started detecting boot failures on imx7s-warp in next-20160124[1], and I bisected it down to this patch, which is in linux-next as commit dde08302c083. I verified that reverting that commit on top of next-20160124 gets imx7s-warp booting again. Kevin P.S. Thanks for the donation of the imx7s-warp board, which allows us to catch these failures early. :) [1] https://kernelci.org/boot/id/588747e959b514e08213d106/ > --- > drivers/clk/imx/clk-imx7d.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c > index ae1d31b..1705f44 100644 > --- a/drivers/clk/imx/clk-imx7d.c > +++ b/drivers/clk/imx/clk-imx7d.c > @@ -788,7 +788,7 @@ static void __init imx7d_clocks_init(struct device_node *ccm_node) > clks[IMX7D_WRCLK_ROOT_DIV] = imx_clk_divider2("wrclk_post_div", "wrclk_pre_div", base + 0xbd00, 0, 6); > clks[IMX7D_CLKO1_ROOT_DIV] = imx_clk_divider2("clko1_post_div", "clko1_pre_div", base + 0xbd80, 0, 6); > clks[IMX7D_CLKO2_ROOT_DIV] = imx_clk_divider2("clko2_post_div", "clko2_pre_div", base + 0xbe00, 0, 6); > - > + clks[IMX7D_IPG_ROOT_CLK] = imx_clk_divider2("ipg_root_clk", "ahb_root_clk", base + 0x9080, 0, 2); > clks[IMX7D_ARM_A7_ROOT_CLK] = imx_clk_gate4("arm_a7_root_clk", "arm_a7_div", base + 0x4000, 0); > clks[IMX7D_ARM_M4_ROOT_CLK] = imx_clk_gate4("arm_m4_root_clk", "arm_m4_div", base + 0x4010, 0); > clks[IMX7D_ARM_M0_ROOT_CLK] = imx_clk_gate4("arm_m0_root_clk", "arm_m0_div", base + 0x4020, 0); > -- > 2.7.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Kevin, On Thu, Jan 26, 2017 at 3:24 AM, Kevin Hilman <khilman@baylibre.com> wrote: > Hi Fabio, > > On Wed, Jan 18, 2017 at 9:53 AM, Fabio Estevam <fabio.estevam@nxp.com> wrote: >> Add an entry for the IMX7D_IPG_ROOT clock. >> >> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> > > kernelci.org started detecting boot failures on imx7s-warp in > next-20160124[1], and I bisected it down to this patch, which is in > linux-next as commit dde08302c083. > > I verified that reverting that commit on top of next-20160124 gets > imx7s-warp booting again. Thanks for the report. Stephen, could you please drop this patch from your tree? I will investigate the issue.
On 01/26, Fabio Estevam wrote: > Hi Kevin, > > On Thu, Jan 26, 2017 at 3:24 AM, Kevin Hilman <khilman@baylibre.com> wrote: > > Hi Fabio, > > > > On Wed, Jan 18, 2017 at 9:53 AM, Fabio Estevam <fabio.estevam@nxp.com> wrote: > >> Add an entry for the IMX7D_IPG_ROOT clock. > >> > >> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> > > > > kernelci.org started detecting boot failures on imx7s-warp in > > next-20160124[1], and I bisected it down to this patch, which is in > > linux-next as commit dde08302c083. > > > > I verified that reverting that commit on top of next-20160124 gets > > imx7s-warp booting again. > > Thanks for the report. > > Stephen, could you please drop this patch from your tree? I will > investigate the issue. Sure. I've dropped this patch.
diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c index ae1d31b..1705f44 100644 --- a/drivers/clk/imx/clk-imx7d.c +++ b/drivers/clk/imx/clk-imx7d.c @@ -788,7 +788,7 @@ static void __init imx7d_clocks_init(struct device_node *ccm_node) clks[IMX7D_WRCLK_ROOT_DIV] = imx_clk_divider2("wrclk_post_div", "wrclk_pre_div", base + 0xbd00, 0, 6); clks[IMX7D_CLKO1_ROOT_DIV] = imx_clk_divider2("clko1_post_div", "clko1_pre_div", base + 0xbd80, 0, 6); clks[IMX7D_CLKO2_ROOT_DIV] = imx_clk_divider2("clko2_post_div", "clko2_pre_div", base + 0xbe00, 0, 6); - + clks[IMX7D_IPG_ROOT_CLK] = imx_clk_divider2("ipg_root_clk", "ahb_root_clk", base + 0x9080, 0, 2); clks[IMX7D_ARM_A7_ROOT_CLK] = imx_clk_gate4("arm_a7_root_clk", "arm_a7_div", base + 0x4000, 0); clks[IMX7D_ARM_M4_ROOT_CLK] = imx_clk_gate4("arm_m4_root_clk", "arm_m4_div", base + 0x4010, 0); clks[IMX7D_ARM_M0_ROOT_CLK] = imx_clk_gate4("arm_m0_root_clk", "arm_m0_div", base + 0x4020, 0);
Add an entry for the IMX7D_IPG_ROOT clock. Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> --- drivers/clk/imx/clk-imx7d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)