From patchwork Thu Jan 26 23:37:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerd Hoffmann X-Patchwork-Id: 9540409 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8B94A60429 for ; Thu, 26 Jan 2017 23:45:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8060928306 for ; Thu, 26 Jan 2017 23:45:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 751992830A; Thu, 26 Jan 2017 23:45:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3F1BA28319 for ; Thu, 26 Jan 2017 23:45:01 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cWtis-0002N5-FO; Thu, 26 Jan 2017 23:44:58 +0000 Received: from merlin.infradead.org ([205.233.59.134]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cWteb-0007YI-NZ for linux-arm-kernel@bombadil.infradead.org; Thu, 26 Jan 2017 23:40:33 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by merlin.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cWtcX-0004PF-6q for linux-arm-kernel@lists.infradead.org; Thu, 26 Jan 2017 23:38:25 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 304A9624BA; Thu, 26 Jan 2017 23:37:33 +0000 (UTC) Received: from nilsson.home.kraxel.org (ovpn-116-57.ams2.redhat.com [10.36.116.57]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0QNbW0Y001940; Thu, 26 Jan 2017 18:37:32 -0500 Received: by nilsson.home.kraxel.org (Postfix, from userid 500) id BDEB7810D2; Fri, 27 Jan 2017 00:37:29 +0100 (CET) From: Gerd Hoffmann To: linux-rpi-kernel@lists.infradead.org Subject: [PATCH 05/13] mmc: bcm2835: call bcm2835_block_irq from irqthread Date: Fri, 27 Jan 2017 00:37:18 +0100 Message-Id: <1485473846-24537-6-git-send-email-kraxel@redhat.com> In-Reply-To: <1485473846-24537-1-git-send-email-kraxel@redhat.com> References: <1485473846-24537-1-git-send-email-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 26 Jan 2017 23:37:33 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170126_183825_362527_9EABF405 X-CRM114-Status: GOOD ( 16.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , Ulf Hansson , Florian Fainelli , Scott Branden , Stephen Warren , Ray Jui , Lee Jones , linux-mmc@vger.kernel.org, open list , Eric Anholt , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Gerd Hoffmann , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Gerd Hoffmann --- drivers/mmc/host/bcm2835.c | 31 ++++++++++++++++++++++--------- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c index d25b85a..8270c76 100644 --- a/drivers/mmc/host/bcm2835.c +++ b/drivers/mmc/host/bcm2835.c @@ -168,6 +168,9 @@ struct bcm2835_host { bool use_busy:1; /* Wait for busy interrupt */ bool use_sbc:1; /* Send CMD23 */ + /* for threaded irq handler */ + bool irq_block; + /* DMA part */ struct dma_chan *dma_chan_rx; struct dma_chan *dma_chan_tx; @@ -1035,18 +1038,13 @@ static void bcm2835_data_irq(struct bcm2835_host *host, u32 intmask) } } -static void bcm2835_block_irq(struct bcm2835_host *host, u32 intmask) +static void bcm2835_block_irq(struct bcm2835_host *host) { - if (!host->data) { - dev_err(&host->pdev->dev, - "got block interrupt 0x%08x even though no data operation was in progress.\n", - (unsigned int)intmask); + if (WARN_ON(!host->data)) { bcm2835_dumpregs(host); return; } - bcm2835_check_data_error(host, intmask); - if (!host->dma_desc) { WARN_ON(!host->blocks); if (host->data->error || (--host->blocks == 0)) @@ -1075,8 +1073,9 @@ static irqreturn_t bcm2835_irq(int irq, void *dev_id) host->ioaddr + SDHSTS); if (intmask & SDHSTS_BLOCK_IRPT) { - bcm2835_block_irq(host, intmask); - result = IRQ_HANDLED; + bcm2835_check_data_error(host, intmask); + host->irq_block = true; + result = IRQ_WAKE_THREAD; } if (intmask & SDHSTS_BUSY_IRPT) { @@ -1101,6 +1100,20 @@ static irqreturn_t bcm2835_irq(int irq, void *dev_id) static irqreturn_t bcm2835_threaded_irq(int irq, void *dev_id) { + struct bcm2835_host *host = dev_id; + unsigned long flags; + bool block; + + spin_lock_irqsave(&host->lock, flags); + + block = host->irq_block; + host->irq_block = false; + + if (block) + bcm2835_block_irq(host); + + spin_unlock_irqrestore(&host->lock, flags); + return IRQ_HANDLED; }