From patchwork Tue Jan 31 19:03:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iyappan Subramanian X-Patchwork-Id: 9548137 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 472DE60425 for ; Tue, 31 Jan 2017 19:06:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 388D326224 for ; Tue, 31 Jan 2017 19:06:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2D82527E22; Tue, 31 Jan 2017 19:06:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 370EF26224 for ; Tue, 31 Jan 2017 19:06:43 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cYdlI-0006Bw-Ei; Tue, 31 Jan 2017 19:06:40 +0000 Received: from mail-pf0-x234.google.com ([2607:f8b0:400e:c00::234]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cYdiW-0002AB-Rf for linux-arm-kernel@lists.infradead.org; Tue, 31 Jan 2017 19:03:57 +0000 Received: by mail-pf0-x234.google.com with SMTP id y143so109952221pfb.0 for ; Tue, 31 Jan 2017 11:03:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apm.com; s=apm; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jDWXlSftLektZDyiEi+TU8MevOzbL0IpVVd5ZuFLUvY=; b=VVkp4Nj7feYM1X1mJVWsZpXLGtIA1g9LcnLQz+AmmKk+DxqyKYw0Ru/q8sZLoN/twU C5lUsPqjR6S36BX2IJHbaztWD82AA/4ugH46Xa5PVe9CAiGUU3NynPk64AOkFZH/mr10 fn2fVDQbPBZgoi6oWYEylP28E1IlebqGDhEAU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jDWXlSftLektZDyiEi+TU8MevOzbL0IpVVd5ZuFLUvY=; b=D/6K2Pgir/1pxR9Tz6DAxE7DizfaYdd08SLws4mVnd/6pPLfgaWeRiBoNnVI2xDD1c at2kyfWstXNLzUzY0p7dsJUuqykT+KZ9Wh4UBEKy8K1miMzUS9iMMhx41M3WKEO2ADWS ehvPCGQ5mThFWplx72IimuTLpbMkRKb9nPTbkQVhn49+xJrp7yO9uX2q/Jk7KNOsf4m2 Tk+zWNtAJt0FDQvUM4QcdOxjbn+5hKzO/c5JrtMVkXOZxhBkLzd7KMfMvb2AGOm831oN wYn7SNnrlFH8MYiexgtIdhDjwlrQuvNQPJMXlekEYA4Syg45TxTOSI7DZo9HCkPGi1UA mKMw== X-Gm-Message-State: AIkVDXIrZiRa8aG7HP4TcvF2nIwuGRAScRqM+5hTu10tP84fBN9Ijrmo63o6HVSfvrsM4bkK X-Received: by 10.84.168.3 with SMTP id e3mr41661243plb.144.1485889407860; Tue, 31 Jan 2017 11:03:27 -0800 (PST) Received: from isubrama-dev.amcc.com ([206.80.4.98]) by smtp.gmail.com with ESMTPSA id f65sm43106754pfk.5.2017.01.31.11.03.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 31 Jan 2017 11:03:27 -0800 (PST) From: Iyappan Subramanian To: davem@davemloft.net, netdev@vger.kernel.org Subject: [PATCH net-next 5/6] drivers: net: xgene-v2: Add transmit and receive Date: Tue, 31 Jan 2017 11:03:20 -0800 Message-Id: <1485889401-13909-6-git-send-email-isubramanian@apm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1485889401-13909-1-git-send-email-isubramanian@apm.com> References: <1485889401-13909-1-git-send-email-isubramanian@apm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170131_110349_163428_505FEBC1 X-CRM114-Status: GOOD ( 21.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kchudgar@apm.com, patches@apm.com, linux-arm-kernel@lists.infradead.org, Iyappan Subramanian MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds, - Transmit - Transmit completion poll - Receive poll - NAPI handler and enables the driver. Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar --- drivers/net/ethernet/apm/Kconfig | 1 + drivers/net/ethernet/apm/Makefile | 1 + drivers/net/ethernet/apm/xgene-v2/Kconfig | 11 ++ drivers/net/ethernet/apm/xgene-v2/Makefile | 6 + drivers/net/ethernet/apm/xgene-v2/main.c | 200 ++++++++++++++++++++++++++++- 5 files changed, 218 insertions(+), 1 deletion(-) create mode 100644 drivers/net/ethernet/apm/xgene-v2/Kconfig create mode 100644 drivers/net/ethernet/apm/xgene-v2/Makefile diff --git a/drivers/net/ethernet/apm/Kconfig b/drivers/net/ethernet/apm/Kconfig index ec63d70..59efe5b 100644 --- a/drivers/net/ethernet/apm/Kconfig +++ b/drivers/net/ethernet/apm/Kconfig @@ -1 +1,2 @@ source "drivers/net/ethernet/apm/xgene/Kconfig" +source "drivers/net/ethernet/apm/xgene-v2/Kconfig" diff --git a/drivers/net/ethernet/apm/Makefile b/drivers/net/ethernet/apm/Makefile index 65ce32a..946b2a4 100644 --- a/drivers/net/ethernet/apm/Makefile +++ b/drivers/net/ethernet/apm/Makefile @@ -3,3 +3,4 @@ # obj-$(CONFIG_NET_XGENE) += xgene/ +obj-$(CONFIG_NET_XGENE_V2) += xgene-v2/ diff --git a/drivers/net/ethernet/apm/xgene-v2/Kconfig b/drivers/net/ethernet/apm/xgene-v2/Kconfig new file mode 100644 index 0000000..1205861 --- /dev/null +++ b/drivers/net/ethernet/apm/xgene-v2/Kconfig @@ -0,0 +1,11 @@ +config NET_XGENE_V2 + tristate "APM X-Gene SoC Ethernet-v2 Driver" + depends on HAS_DMA + depends on ARCH_XGENE || COMPILE_TEST + help + This is the Ethernet driver for the on-chip ethernet interface + which uses a linked list of DMA descriptor architecture (v2) for + APM X-Gene SoCs. + + To compile this driver as a module, choose M here. This module will + be called xgene-enet-v2. diff --git a/drivers/net/ethernet/apm/xgene-v2/Makefile b/drivers/net/ethernet/apm/xgene-v2/Makefile new file mode 100644 index 0000000..735309c --- /dev/null +++ b/drivers/net/ethernet/apm/xgene-v2/Makefile @@ -0,0 +1,6 @@ +# +# Makefile for APM X-Gene Ethernet v2 driver +# + +xgene-enet-v2-objs := main.o mac.o enet.o ring.o +obj-$(CONFIG_NET_XGENE_V2) += xgene-enet-v2.o diff --git a/drivers/net/ethernet/apm/xgene-v2/main.c b/drivers/net/ethernet/apm/xgene-v2/main.c index 3881f27..fc90298 100644 --- a/drivers/net/ethernet/apm/xgene-v2/main.c +++ b/drivers/net/ethernet/apm/xgene-v2/main.c @@ -164,9 +164,11 @@ static int xge_refill_buffers(struct net_device *ndev, u32 nbuf) dma_wmb(); raw_desc->m0 = cpu_to_le64(SET_BITS(PKT_ADDRL, dma_addr) | SET_BITS(E, 1)); + ring->skbs[tail] = skb; tail = (tail + 1) & slots; } + xge_wr_csr(pdata, DMARXCTRL, 1); ring->tail = tail; @@ -278,13 +280,14 @@ static int xge_open(struct net_device *ndev) struct xge_pdata *pdata = netdev_priv(ndev); int ret; + napi_enable(&pdata->napi); + ret = xge_request_irq(ndev); if (ret) return ret; xge_intr_enable(pdata); - xge_wr_csr(pdata, DMARXCTRL, 1); xge_mac_enable(pdata); netif_start_queue(ndev); @@ -298,11 +301,204 @@ static int xge_close(struct net_device *ndev) netif_stop_queue(ndev); xge_mac_disable(pdata); + xge_intr_disable(pdata); xge_free_irq(ndev); + napi_disable(&pdata->napi); return 0; } +static netdev_tx_t xge_start_xmit(struct sk_buff *skb, struct net_device *ndev) +{ + struct xge_pdata *pdata = netdev_priv(ndev); + struct device *dev = &pdata->pdev->dev; + static dma_addr_t dma_addr; + struct xge_desc_ring *tx_ring; + struct xge_raw_desc *raw_desc; + u64 addr_lo, addr_hi; + void *pkt_buf; + u8 tail; + u16 len; + + tx_ring = pdata->tx_ring; + tail = tx_ring->tail; + len = skb_headlen(skb); + raw_desc = &tx_ring->raw_desc[tail]; + + /* Tx descriptor not available */ + if (!GET_BITS(E, le64_to_cpu(raw_desc->m0)) || + GET_BITS(PKT_SIZE, le64_to_cpu(raw_desc->m0))) + return NETDEV_TX_BUSY; + + /* Packet buffers should be 64B aligned */ + pkt_buf = dma_alloc_coherent(dev, XGENE_ENET_STD_MTU, &dma_addr, + GFP_ATOMIC); + if (unlikely(!pkt_buf)) + goto out; + + memcpy(pkt_buf, skb->data, len); + + addr_hi = GET_BITS(NEXT_DESC_ADDRH, le64_to_cpu(raw_desc->m1)); + addr_lo = GET_BITS(NEXT_DESC_ADDRL, le64_to_cpu(raw_desc->m1)); + raw_desc->m1 = cpu_to_le64(SET_BITS(NEXT_DESC_ADDRL, addr_lo) | + SET_BITS(NEXT_DESC_ADDRH, addr_hi) | + SET_BITS(PKT_ADDRH, + dma_addr >> PKT_ADDRL_LEN)); + + dma_wmb(); + + raw_desc->m0 = cpu_to_le64(SET_BITS(PKT_ADDRL, dma_addr) | + SET_BITS(PKT_SIZE, len) | + SET_BITS(E, 0)); + + skb_tx_timestamp(skb); + xge_wr_csr(pdata, DMATXCTRL, 1); + + pdata->stats.tx_packets++; + pdata->stats.tx_bytes += skb->len; + + tx_ring->skbs[tail] = skb; + tx_ring->pkt_bufs[tail] = pkt_buf; + tx_ring->tail = (tail + 1) & (XGENE_ENET_NUM_DESC - 1); + +out: + dev_kfree_skb_any(skb); + + return NETDEV_TX_OK; +} + +static void xge_txc_poll(struct net_device *ndev, unsigned int budget) +{ + struct xge_pdata *pdata = netdev_priv(ndev); + struct device *dev = &pdata->pdev->dev; + struct xge_desc_ring *tx_ring; + struct xge_raw_desc *raw_desc; + u64 addr_lo, addr_hi; + dma_addr_t dma_addr; + void *pkt_buf; + bool pktsent; + u32 data; + u8 head; + int i; + + tx_ring = pdata->tx_ring; + head = tx_ring->head; + + data = xge_rd_csr(pdata, DMATXSTATUS); + pktsent = data & TX_PKT_SENT; + if (unlikely(!pktsent)) + return; + + for (i = 0; i < budget; i++) { + raw_desc = &tx_ring->raw_desc[head]; + + if (!GET_BITS(E, le64_to_cpu(raw_desc->m0))) + break; + + dma_rmb(); + + addr_hi = GET_BITS(PKT_ADDRH, le64_to_cpu(raw_desc->m1)); + addr_lo = GET_BITS(PKT_ADDRL, le64_to_cpu(raw_desc->m0)); + dma_addr = (addr_hi << PKT_ADDRL_LEN) | addr_lo; + + pkt_buf = tx_ring->pkt_bufs[head]; + + /* clear pktstart address and pktsize */ + raw_desc->m0 = cpu_to_le64(SET_BITS(E, 1) | + SET_BITS(PKT_SIZE, 0)); + xge_wr_csr(pdata, DMATXSTATUS, 1); + + dma_free_coherent(dev, XGENE_ENET_STD_MTU, pkt_buf, dma_addr); + + head = (head + 1) & (XGENE_ENET_NUM_DESC - 1); + } + + tx_ring->head = head; +} + +static int xge_rx_poll(struct net_device *ndev, unsigned int budget) +{ + struct xge_pdata *pdata = netdev_priv(ndev); + struct device *dev = &pdata->pdev->dev; + dma_addr_t addr_hi, addr_lo, dma_addr; + struct xge_desc_ring *rx_ring; + struct xge_raw_desc *raw_desc; + struct sk_buff *skb; + int i, npkts, ret = 0; + bool pktrcvd; + u32 data; + u8 head; + u16 len; + + rx_ring = pdata->rx_ring; + head = rx_ring->head; + + data = xge_rd_csr(pdata, DMARXSTATUS); + pktrcvd = data & RXSTATUS_RXPKTRCVD; + + if (unlikely(!pktrcvd)) + return 0; + + npkts = 0; + for (i = 0; i < budget; i++) { + raw_desc = &rx_ring->raw_desc[head]; + + if (GET_BITS(E, le64_to_cpu(raw_desc->m0))) + break; + + dma_rmb(); + + addr_hi = GET_BITS(PKT_ADDRH, le64_to_cpu(raw_desc->m1)); + addr_lo = GET_BITS(PKT_ADDRL, le64_to_cpu(raw_desc->m0)); + dma_addr = (addr_hi << PKT_ADDRL_LEN) | addr_lo; + len = GET_BITS(PKT_SIZE, le64_to_cpu(raw_desc->m0)); + + dma_unmap_single(dev, dma_addr, XGENE_ENET_STD_MTU, + DMA_FROM_DEVICE); + + skb = rx_ring->skbs[head]; + skb_put(skb, len); + + skb->protocol = eth_type_trans(skb, ndev); + + pdata->stats.rx_packets++; + pdata->stats.rx_bytes += len; + napi_gro_receive(&pdata->napi, skb); + npkts++; + + ret = xge_refill_buffers(ndev, 1); + xge_wr_csr(pdata, DMARXSTATUS, 1); + + if (ret) + break; + + head = (head + 1) & (XGENE_ENET_NUM_DESC - 1); + } + + rx_ring->head = head; + + return npkts; +} + +static int xge_napi(struct napi_struct *napi, const int budget) +{ + struct net_device *ndev = napi->dev; + struct xge_pdata *pdata = netdev_priv(ndev); + int processed; + + pdata = netdev_priv(ndev); + + xge_txc_poll(ndev, budget); + processed = xge_rx_poll(ndev, budget); + + if (processed < budget) { + napi_complete(napi); + xge_intr_enable(pdata); + } + + return processed; +} + static int xge_set_mac_addr(struct net_device *ndev, void *addr) { struct xge_pdata *pdata = netdev_priv(ndev); @@ -345,6 +541,7 @@ static void xge_get_stats64(struct net_device *ndev, static const struct net_device_ops xgene_ndev_ops = { .ndo_open = xge_open, .ndo_stop = xge_close, + .ndo_start_xmit = xge_start_xmit, .ndo_set_mac_address = xge_set_mac_addr, .ndo_tx_timeout = xge_timeout, .ndo_get_stats64 = xge_get_stats64, @@ -388,6 +585,7 @@ static int xge_probe(struct platform_device *pdev) if (ret) goto err; + netif_napi_add(ndev, &pdata->napi, xge_napi, NAPI_POLL_WEIGHT); ret = register_netdev(ndev); if (ret) { netdev_err(ndev, "Failed to register netdev\n");