From patchwork Fri Feb 3 02:30:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shanker Donthineni X-Patchwork-Id: 9553423 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5E29D604A7 for ; Fri, 3 Feb 2017 02:31:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4D4632847F for ; Fri, 3 Feb 2017 02:31:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 40228284D5; Fri, 3 Feb 2017 02:31:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D38BE2847F for ; Fri, 3 Feb 2017 02:31:15 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cZTed-00016H-5L; Fri, 03 Feb 2017 02:31:15 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cZTea-00014M-7c for linux-arm-kernel@lists.infradead.org; Fri, 03 Feb 2017 02:31:13 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 4F3056087A; Fri, 3 Feb 2017 02:30:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1486089051; bh=k+JZ3kpqHN/vV9BBb/xjWoCu6WH1za9iTRWSAxTZLkM=; h=From:To:Cc:Subject:Date:From; b=UO+9rfHQXctcVT0IIK6CdycMnMDUxOiVLsBVyoJ9labqb/oczDr8dkwJ1GttJiY6h Obj9IPYWBSUCV+EODsTlu9c0X/JYsj+SN5LkRFqwrpuYU1aIcnG+syJTZtCFLuxlFS T8xcFXsjaYTvsFNqGo7lX2asyxbW3kXSh1vYwe5s= Received: from shankerd-ubuntu.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: shankerd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id DBA166070D; Fri, 3 Feb 2017 02:30:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1486089050; bh=k+JZ3kpqHN/vV9BBb/xjWoCu6WH1za9iTRWSAxTZLkM=; h=From:To:Cc:Subject:Date:From; b=INiLcaDbV3wvF3qZw/cx4iD/m+Q08KZqG6Yvo0oXZV5hvxh0N1d/sfSIIw4PXuUNh CPSZb66sDuzhQBBaSDuDh+f3bfWyYg/n/wdKAICs0WDANvrVKctkzjNItaYPlNAvuq ApcnTSeGWONHBF4tkfpPTJD7r1Lc/pVEknN+xw4o= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DBA166070D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=shankerd@codeaurora.org From: Shanker Donthineni To: Marc Zyngier , Christoffer Dall Subject: [PATCH] KVM: arm/arm64: vgic: Stop injecting the MSI occurrence twice Date: Thu, 2 Feb 2017 20:30:03 -0600 Message-Id: <1486089003-413-1-git-send-email-shankerd@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170202_183112_299922_3076EED7 X-CRM114-Status: GOOD ( 10.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vikram Sethi , linux-kernel , Eric Auger , linux-arm-kernel , Paolo Bonzini , Shanker Donthineni MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The IRQFD framework calls the architecture dependent function twice if the corresponding GSI type is edge triggered. For ARM, the function kvm_set_msi() is getting called twice whenever the IRQFD receives the event signal. The rest of the code path is trying to inject the MSI without any validation checks. No need to call the function vgic_its_inject_msi() second time to avoid an unnecessary overhead in IRQ queue logic. It also avoids the possibility of VM seeing the MSI twice. Simple fix, return -1 if the argument 'level' value is zero. Signed-off-by: Shanker Donthineni Reviewed-by: Eric Auger Reviewed-by: Christoffer Dall --- virt/kvm/arm/vgic/vgic-irqfd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/virt/kvm/arm/vgic/vgic-irqfd.c b/virt/kvm/arm/vgic/vgic-irqfd.c index d918dcf..f138ed2 100644 --- a/virt/kvm/arm/vgic/vgic-irqfd.c +++ b/virt/kvm/arm/vgic/vgic-irqfd.c @@ -99,6 +99,9 @@ int kvm_set_msi(struct kvm_kernel_irq_routing_entry *e, if (!vgic_has_its(kvm)) return -ENODEV; + if (!level) + return -1; + return vgic_its_inject_msi(kvm, &msi); }