From patchwork Tue Feb 14 06:51:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 9571321 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BC926601E7 for ; Tue, 14 Feb 2017 06:53:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ABDA320009 for ; Tue, 14 Feb 2017 06:53:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9CF9827CAF; Tue, 14 Feb 2017 06:53:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 471DF20009 for ; Tue, 14 Feb 2017 06:53:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=W4aP5/j27ZpSOY6LhrD/h6ndDPhNVc5hVR3lwgGTMAw=; b=qiMooHmumKzQQkUa1uzQHYBXJO PpAyc+EEMSMi4ewsm7aI3R9zfWgYFTJ+gmEgnYJiF3w6ywfePC04VdT0APaWtKactb944Fq/2LK/k 6J6B3tiPGeOmCsVsQEOLliEERWaNnN+m595CWNDXjaUTZct3rj8XU8PiDpf0QiPv7NIU9mfqa9PDn Ug/ijOZ6ZBLYSq8mBPQU7iUpHUOAEG2szXDBp99YuW8NZcT7WnlkCT1+udQjFXUROKPGzX/VjQRfP BpIwRLGgkVCAOsw7FZRwpp0VpvAhV98uvDR1s5d/NJseBYCdT1kceQlvL836Ev44aT4KoQQNIwe1v Ot1qGF7g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cdWzR-00083Z-DT; Tue, 14 Feb 2017 06:53:29 +0000 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cdWz2-0007Uj-Pp for linux-arm-kernel@lists.infradead.org; Tue, 14 Feb 2017 06:53:06 +0000 Received: by mail-wm0-x232.google.com with SMTP id v186so10022541wmd.0 for ; Mon, 13 Feb 2017 22:52:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=92Sq4I4UInpzq2CbNnJQfee071l2ERx49mmNUjUXieo=; b=d1nF5go4JPVQNH3Y8kpTarhkzuVRU4ZsQAwPlpkNCiiEQMbOmQu3pdTI6B7dAhnGEc b7+N2PauZYqRO1u0L0bR3VzIEhgKCd/+0aobcYZddIYoqGkYYaEr/hF8xGav4SWByhrp vHajLhCEpCxJENHYztm9wstKc2N3QKlTFYw20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=92Sq4I4UInpzq2CbNnJQfee071l2ERx49mmNUjUXieo=; b=X0XZrRrwPYRQlWdx2DXG7ltSjmjxSRsmYUgSbi7cf+IXB/tJqVRbe9P6n1kmB/hf35 3AHnTgovZpNpz0r4Xtcpik1E2DVApmFdEQEyopJqm1AKdg0ZEoVeSSsz0DdmdquVDCOo 9Qrx15OJ4huszNHBYCuqWf+rqHWuxC/aRj+PLj9jv8WPBAspbCS2LEsrNBrGXP+OtGLS 0s746d63sCfKZfMs9krP14GAFFrLCvQ0FnvFjcAuwz5HHECfyrGb+RmBNvtrl8GwytBz zjUPRpBnOx4PBLdZhczqzheQxEFJISX3G9oJQplaWG+lL1yE0edjaqxemy4/WN44geo3 jBcA== X-Gm-Message-State: AMke39lEagHYPXwuRJKmEkxBkwm7l7lGSdJQ6JVjfK5kNvebVYJC3Ks+RXVvYxixLfUlK+5B X-Received: by 10.28.189.195 with SMTP id n186mr1555783wmf.77.1487055162758; Mon, 13 Feb 2017 22:52:42 -0800 (PST) Received: from anup-HP-Compaq-8100-Elite-CMT-PC.dhcp.avagotech.net ([192.19.237.250]) by smtp.gmail.com with ESMTPSA id k195sm8190562wmd.7.2017.02.13.22.52.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 13 Feb 2017 22:52:42 -0800 (PST) From: Anup Patel To: Vinod Koul , Rob Herring , Mark Rutland , Herbert Xu , "David S . Miller" , Jassi Brar Subject: [PATCH v4 2/4] async_tx: Fix DMA_PREP_FENCE usage in do_async_gen_syndrome() Date: Tue, 14 Feb 2017 12:21:50 +0530 Message-Id: <1487055112-5185-3-git-send-email-anup.patel@broadcom.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1487055112-5185-1-git-send-email-anup.patel@broadcom.com> References: <1487055112-5185-1-git-send-email-anup.patel@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170213_225305_062241_F3500E88 X-CRM114-Status: GOOD ( 12.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Anup Patel , Scott Branden , Jon Mason , Ray Jui , linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-crypto@vger.kernel.org, Rob Rice , dmaengine@vger.kernel.org, Dan Williams , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The DMA_PREP_FENCE is to be used when preparing Tx descriptor if output of Tx descriptor is to be used by next/dependent Tx descriptor. The DMA_PREP_FENSE will not be set correctly in do_async_gen_syndrome() when calling dma->device_prep_dma_pq() under following conditions: 1. ASYNC_TX_FENCE not set in submit->flags 2. DMA_PREP_FENCE not set in dma_flags 3. src_cnt (= (disks - 2)) is greater than dma_maxpq(dma, dma_flags) This patch fixes DMA_PREP_FENCE usage in do_async_gen_syndrome() taking inspiration from do_async_xor() implementation. Signed-off-by: Anup Patel Reviewed-by: Ray Jui Reviewed-by: Scott Branden --- crypto/async_tx/async_pq.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/crypto/async_tx/async_pq.c b/crypto/async_tx/async_pq.c index f83de99..56bd612 100644 --- a/crypto/async_tx/async_pq.c +++ b/crypto/async_tx/async_pq.c @@ -62,9 +62,6 @@ do_async_gen_syndrome(struct dma_chan *chan, dma_addr_t dma_dest[2]; int src_off = 0; - if (submit->flags & ASYNC_TX_FENCE) - dma_flags |= DMA_PREP_FENCE; - while (src_cnt > 0) { submit->flags = flags_orig; pq_src_cnt = min(src_cnt, dma_maxpq(dma, dma_flags)); @@ -83,6 +80,8 @@ do_async_gen_syndrome(struct dma_chan *chan, if (cb_fn_orig) dma_flags |= DMA_PREP_INTERRUPT; } + if (submit->flags & ASYNC_TX_FENCE) + dma_flags |= DMA_PREP_FENCE; /* Drivers force forward progress in case they can not provide * a descriptor